From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH] x86/p2m: clear_identity_p2m_entry() must cope with 'relaxed' RDM mode Date: Wed, 12 Aug 2015 17:06:26 +0100 Message-ID: <55CB6F02.10308@citrix.com> References: <55CB7CE7020000780009A345@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZPYXu-00060v-Te for xen-devel@lists.xenproject.org; Wed, 12 Aug 2015 16:06:31 +0000 In-Reply-To: <55CB7CE7020000780009A345@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich , xen-devel Cc: Kevin Tian , Wei Liu , George Dunlap , Yang Z Zhang , "tiejun.chen@intel.com" , Keir Fraser List-Id: xen-devel@lists.xenproject.org On 12/08/15 16:05, Jan Beulich wrote: > Tearing down a 1:1 mapping that was never established isn't really nice > (and in fact hits an ASSERT() in p2m_remove_page()). Convert from a > wrapper macro to a proper function which then can take care of the > situation. > > Also take the opportunity to remove the 'page_order' parameter of > clear_identity_p2m_entry(), to make it match set_identity_p2m_entry(). What about identity mapping with 2MB frames? IMO, the RMRR code is incorrect in assuming that only 4K frames will be wanted, but that is a separate issue. As this at least matches the set_identity side of things, and improves the situation, so Reviewed-by: Andrew Cooper (I presume you intended to include a SoB tag?) ~Andrew