From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH] xen/x86: Fix up rules when forcing -mno-sse
Date: Wed, 12 Aug 2015 17:12:43 +0100
Message-ID: <55CB707B.5010300@citrix.com>
References: <1439392992-17274-1-git-send-email-cardoe@cardoe.com>
	<55CB84A0020000780009A3BF@prv-mh.provo.novell.com>
	<CAFWqQMTsnTTHz7vWKj5zcmUhfps7UKNmZJ1uDcn1K9dORSgNFQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=65958348f=Andrew.Cooper3@citrix.com>)
	id 1ZPYdz-0006sT-LQ
	for xen-devel@lists.xenproject.org; Wed, 12 Aug 2015 16:12:47 +0000
In-Reply-To: <CAFWqQMTsnTTHz7vWKj5zcmUhfps7UKNmZJ1uDcn1K9dORSgNFQ@mail.gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Doug Goldstein <cardoe@cardoe.com>, Jan Beulich <JBeulich@suse.com>
Cc: xen-devel@lists.xenproject.org, nathan@nathanrossi.com
List-Id: xen-devel@lists.xenproject.org

On 12/08/15 17:03, Doug Goldstein wrote:
> On Wed, Aug 12, 2015 at 10:38 AM, Jan Beulich <JBeulich@suse.com> wrote:
>>>>> On 12.08.15 at 17:23, <cardoe@cardoe.com> wrote:
>>> From: Nathan Rossi <nathan.rossi@xilinx.com>
>>>
>>> * When forcing -mno-sse specify -mfpmath=387 to avoid the fallback
>>>   warning
>> "the fallback warning" being what? I've never seen any, and I don't
>> think I've ever heard anyone else say there was one.
>>
>> Apart from that I don't think -mfpmath=387 is what we want - we'd
>> better tell the compiler to not use x87 registers at all.

Agreed.

However, a git grep shows:

crypto/vmac.c:1098:    double cpb;
crypto/vmac.c:1158:             
((double)CLOCKS_PER_SEC*speed_lengths[i]*speed_iters[i]));

which I suspect might need fixing.

>>
>> Jan
>>
> I guess I jumped the gun a bit. When targeting a corei7 based chip, Yocto uses
> the following CFLAGS for the packages it builds:
>
> -march=corei7 -mtune=corei7 -mfpmath=sse -msse4.2
>
> The issue is the -mfpmath value.
>

It seems wrong to set -mfpmath=387, as that implies that floating point
maths is ok.

I cant however find an obvious "no fpmath" option.

Perhaps Xen should specifically filter options such as those out from
the environmental CFLAGS

~Andrew