From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48996)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZPYqW-0002zE-86
	for qemu-devel@nongnu.org; Wed, 12 Aug 2015 12:25:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZPYqQ-0008Cu-PB
	for qemu-devel@nongnu.org; Wed, 12 Aug 2015 12:25:43 -0400
Received: from mail-qk0-x22a.google.com ([2607:f8b0:400d:c09::22a]:33732)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZPYqQ-0008Ci-Lf
	for qemu-devel@nongnu.org; Wed, 12 Aug 2015 12:25:38 -0400
Received: by qkfj126 with SMTP id j126so6885659qkf.0
	for <qemu-devel@nongnu.org>; Wed, 12 Aug 2015 09:25:38 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
References: <1439151229-27747-1-git-send-email-laurent@vivier.eu>
	<1439151229-27747-17-git-send-email-laurent@vivier.eu>
From: Richard Henderson <rth@twiddle.net>
Message-ID: <55CB737E.1000802@twiddle.net>
Date: Wed, 12 Aug 2015 09:25:34 -0700
MIME-Version: 1.0
In-Reply-To: <1439151229-27747-17-git-send-email-laurent@vivier.eu>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH for-2.5 16/30] m68k: Add all access modes
 and data sizes to some 680x0 instructions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Laurent Vivier <laurent@vivier.eu>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, Andreas Schwab <schwab@linux-m68k.org>, gerg@uclinux.org

On 08/09/2015 01:13 PM, Laurent Vivier wrote:
>      case 6: /* cmpi */
>          tcg_gen_mov_i32(dest, src1);
>          tcg_gen_subi_i32(dest, dest, im);
>          gen_update_cc_add(dest, tcg_const_i32(im));
> -        set_cc_op(s, CC_OP_SUB);
> +        SET_CC_OP(opsize, SUB);
>          break;
>      default:
>          abort();
>      }
> -    if (op != 6) {
> -        DEST_EA(env, insn, OS_LONG, dest, &addr);
> -    }
> +    DEST_EA(env, insn, opsize, dest, &addr);

It appears you've lost the if that doesn't write back the result of compare.
Did you intend to change the case 6 break to a return?


r~