Re: [PATCH] xfs/020: use -f option for xfs_repair a fs image

[Eric Sandeen <sandeen@sandeen.net>]

On 8/12/15 12:33 PM, Zorro Lang wrote:
> This case creates a 60t image file on TEST_DIR. Generally
> this's no problem. But if the image sector size is smaller
> than the TEST_DEV sector size, for example we create the
> image on hard 4k TEST_DEV, the test will fail.
> 
> So use -f for xfs_repair will helpful.
> 
> Signed-off-by: Zorro Lang <zlang@redhat.com>
> ---
>  tests/xfs/020 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/xfs/020 b/tests/xfs/020
> index dc305c1..120492d 100755
> --- a/tests/xfs/020
> +++ b/tests/xfs/020
> @@ -55,7 +55,7 @@ fsfile=$TEST_DIR/fsfile.$seq
>  rm -f $fsfile
>  
>  $MKFS_PROG -t xfs -d size=60t,file,name=$fsfile >/dev/null
> -$XFS_REPAIR_PROG -o ag_stride=32 -t 1 $fsfile >/dev/null 2>&1
> +$XFS_REPAIR_PROG -f -o ag_stride=32 -t 1 $fsfile >/dev/null 2>&1

Agreed, but we should audit all tests for this problem, I think.

FWIW, the latest upstream will do this automatically...

So for this change, it's fine:

Reviewed-by: Eric Sandeen <sandeen@redhat.com>

but will you see if other tests should be fixed as well?

-Eric