From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH] x86/hvm: Fix non-onchangeonly CR write
	events logic
Date: Wed, 12 Aug 2015 18:45:13 +0100
Message-ID: <55CB8629.3010709@citrix.com>
References: <1439398804-8524-1-git-send-email-rcojocaru@bitdefender.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=65958348f=Andrew.Cooper3@citrix.com>)
	id 1ZPa5V-0000bv-MK
	for xen-devel@lists.xenproject.org; Wed, 12 Aug 2015 17:45:17 +0000
In-Reply-To: <1439398804-8524-1-git-send-email-rcojocaru@bitdefender.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Razvan Cojocaru <rcojocaru@bitdefender.com>, xen-devel@lists.xenproject.org
Cc: keir@xen.org, jbeulich@suse.com
List-Id: xen-devel@lists.xenproject.org

On 12/08/15 18:00, Razvan Cojocaru wrote:
> hvm_event_crX() already returns a bool_t to tell us whether an
> event will be sent out or not, so the extra check that value != old
> is not only useless, but also prevents non-onchangeonly events from
> being sent.
>
> Signed-off-by: Razvan Cojocaru <rcojocaru@bitdefender.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

I presume this is a 4.6 candidate?  If so, you need to CC the release
manager as we are into the RC's

~Andrew