From mboxrd@z Thu Jan 1 00:00:00 1970 From: Razvan Cojocaru Subject: Re: [PATCH] x86/hvm: Fix non-onchangeonly CR write events logic Date: Wed, 12 Aug 2015 20:48:05 +0300 Message-ID: <55CB86D5.5030606@bitdefender.com> References: <1439398804-8524-1-git-send-email-rcojocaru@bitdefender.com> <55CB8629.3010709@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZPa8J-00013O-F2 for xen-devel@lists.xenproject.org; Wed, 12 Aug 2015 17:48:11 +0000 Received: from smtp02.buh.bitdefender.net (unknown [10.17.80.76]) by mx-sr.buh.bitdefender.com (Postfix) with ESMTP id 56C4680513 for ; Wed, 12 Aug 2015 20:48:07 +0300 (EEST) In-Reply-To: <55CB8629.3010709@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Andrew Cooper , xen-devel@lists.xenproject.org Cc: "wei.liu2@citrix.com" , keir@xen.org, jbeulich@suse.com List-Id: xen-devel@lists.xenproject.org On 08/12/2015 08:45 PM, Andrew Cooper wrote: > On 12/08/15 18:00, Razvan Cojocaru wrote: >> hvm_event_crX() already returns a bool_t to tell us whether an >> event will be sent out or not, so the extra check that value != old >> is not only useless, but also prevents non-onchangeonly events from >> being sent. >> >> Signed-off-by: Razvan Cojocaru > > Reviewed-by: Andrew Cooper > > I presume this is a 4.6 candidate? If so, you need to CC the release > manager as we are into the RC's Yes, it is. I've now CCd Wei, thank you for pointing that out! And sorry for missing this before. Thanks, Razvan