From: Johannes Sixt <j6t@kdbg.org>
To: kusmabite@gmail.com, Johannes Schindelin <johannes.schindelin@gmx.de>
Cc: Git Mailing List <git@vger.kernel.org>,
msysGit <msysgit@googlegroups.com>
Subject: Re: [msysGit] Re: [PATCH bc/connect-plink] t5601-clone: remove broken and pointless check for plink.exe
Date: Wed, 12 Aug 2015 20:31:44 +0200 [thread overview]
Message-ID: <55CB9110.4060005@kdbg.org> (raw)
In-Reply-To: <CABPQNSZHtAKbe6JwxRoK3LpCabfp6r2_kTmF1qokObt_yKnSDg@mail.gmail.com>
Am 12.08.2015 um 13:58 schrieb Erik Faye-Lund:
> On Wed, Aug 12, 2015 at 1:07 PM, Johannes Schindelin
> <johannes.schindelin@gmx.de> wrote:
>> FWIW Git for Windows has this patch (that I wanted to contribute
>> in due time, what with being busy with all those tickets) to solve the
>> problem mentioned in your patch in a different way:
>>
>> https://github.com/git-for-windows/git/commit/2fff4b54a0d4e5c5e2e4638c9b0739d3c1ff1e45
>
> Yuck. On Windows, it's the extension of a file that dictates what kind
> of file it is (and if it's executable or not), not the contents. If we
> get a shell script written with the ".exe"-prefix, it's considered as
> an invalid executable by the system. We should consider it the same
> way, otherwise we're on the path to user-experience schizophrenia.
>
> I'm not sure I consider this commit a step in the right direction.
I, too, think that it is a wrong decision to pessimize git for the sake
of a single test case.
-- Hannes
next prev parent reply other threads:[~2015-08-12 18:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-11 20:51 [PATCH bc/connect-plink] t5601-clone: remove broken and pointless check for plink.exe Johannes Sixt
2015-08-11 22:50 ` Eric Sunshine
2015-08-11 22:53 ` Junio C Hamano
2015-08-11 22:56 ` [msysGit] " Junio C Hamano
2015-08-11 23:26 ` Eric Sunshine
2015-08-12 11:07 ` Johannes Schindelin
2015-08-12 11:58 ` [msysGit] " Erik Faye-Lund
2015-08-12 18:31 ` Johannes Sixt [this message]
2015-08-13 7:30 ` Johannes Schindelin
2015-08-13 18:07 ` [msysGit] " Johannes Sixt
2015-08-13 8:37 ` Johannes Schindelin
2015-08-13 8:56 ` [msysGit] " Erik Faye-Lund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55CB9110.4060005@kdbg.org \
--to=j6t@kdbg.org \
--cc=git@vger.kernel.org \
--cc=johannes.schindelin@gmx.de \
--cc=kusmabite@gmail.com \
--cc=msysgit@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.