From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ig0-x22b.google.com (mail-ig0-x22b.google.com [IPv6:2607:f8b0:4001:c05::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 690EB1A1D49 for ; Thu, 13 Aug 2015 05:06:45 +1000 (AEST) Received: by igbpg9 with SMTP id pg9so118659843igb.0 for ; Wed, 12 Aug 2015 12:06:43 -0700 (PDT) Message-ID: <55CB9942.7050303@gmail.com> Date: Wed, 12 Aug 2015 15:06:42 -0400 From: nick MIME-Version: 1.0 To: Alexander Graf , gleb@kernel.org CC: linuxppc-dev@lists.ozlabs.org, pbonzini@redhat.com, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] kvm:powerpc:Fix incorrect return statement in the function mpic_set_default_irq_routing References: <1438962893-3370-1-git-send-email-xerofoify@gmail.com> <55CB98FE.4060908@suse.de> In-Reply-To: <55CB98FE.4060908@suse.de> Content-Type: text/plain; charset=UTF-8 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 2015-08-12 03:05 PM, Alexander Graf wrote: > > > On 07.08.15 17:54, Nicholas Krause wrote: >> This fixes the incorrect return statement in the function >> mpic_set_default_irq_routing from always returning zero >> to signal success to this function's caller to instead >> return the return value of kvm_set_irq_routing as this >> function can fail and we need to correctly signal the >> caller of mpic_set_default_irq_routing when the call >> to this particular function has failed. >> >> Signed-off-by: Nicholas Krause > > I like the patch, but I don't see it on the kvm-ppc mailing list. It > doesn't show up on patchwork or spinics. Did something go wrong while > sending it out? > > > Alex > Alex, Ask Paolo about it as he would be able to explain it better then I. Nick From mboxrd@z Thu Jan 1 00:00:00 1970 From: nick Subject: Re: [PATCH] kvm:powerpc:Fix incorrect return statement in the function mpic_set_default_irq_routing Date: Wed, 12 Aug 2015 15:06:42 -0400 Message-ID: <55CB9942.7050303@gmail.com> References: <1438962893-3370-1-git-send-email-xerofoify@gmail.com> <55CB98FE.4060908@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: pbonzini@redhat.com, linuxppc-dev@lists.ozlabs.org, kvm-ppc@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org To: Alexander Graf , gleb@kernel.org Return-path: In-Reply-To: <55CB98FE.4060908@suse.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org Sender: "Linuxppc-dev" List-Id: kvm.vger.kernel.org CgpPbiAyMDE1LTA4LTEyIDAzOjA1IFBNLCBBbGV4YW5kZXIgR3JhZiB3cm90ZToKPiAKPiAKPiBP biAwNy4wOC4xNSAxNzo1NCwgTmljaG9sYXMgS3JhdXNlIHdyb3RlOgo+PiBUaGlzIGZpeGVzIHRo ZSBpbmNvcnJlY3QgcmV0dXJuIHN0YXRlbWVudCBpbiB0aGUgZnVuY3Rpb24KPj4gbXBpY19zZXRf ZGVmYXVsdF9pcnFfcm91dGluZyBmcm9tIGFsd2F5cyByZXR1cm5pbmcgemVybwo+PiB0byBzaWdu YWwgc3VjY2VzcyB0byB0aGlzIGZ1bmN0aW9uJ3MgY2FsbGVyIHRvIGluc3RlYWQKPj4gcmV0dXJu IHRoZSByZXR1cm4gdmFsdWUgb2Yga3ZtX3NldF9pcnFfcm91dGluZyBhcyB0aGlzCj4+IGZ1bmN0 aW9uIGNhbiBmYWlsIGFuZCB3ZSBuZWVkIHRvIGNvcnJlY3RseSBzaWduYWwgdGhlCj4+IGNhbGxl ciBvZiBtcGljX3NldF9kZWZhdWx0X2lycV9yb3V0aW5nIHdoZW4gdGhlIGNhbGwKPj4gdG8gdGhp cyBwYXJ0aWN1bGFyIGZ1bmN0aW9uIGhhcyBmYWlsZWQuCj4+Cj4+IFNpZ25lZC1vZmYtYnk6IE5p Y2hvbGFzIEtyYXVzZSA8eGVyb2ZvaWZ5QGdtYWlsLmNvbT4KPiAKPiBJIGxpa2UgdGhlIHBhdGNo LCBidXQgSSBkb24ndCBzZWUgaXQgb24gdGhlIGt2bS1wcGMgbWFpbGluZyBsaXN0LiBJdAo+IGRv ZXNuJ3Qgc2hvdyB1cCBvbiBwYXRjaHdvcmsgb3Igc3Bpbmljcy4gRGlkIHNvbWV0aGluZyBnbyB3 cm9uZyB3aGlsZQo+IHNlbmRpbmcgaXQgb3V0Pwo+IAo+IAo+IEFsZXgKPiAKQWxleCwKQXNrIFBh b2xvIGFib3V0IGl0IGFzIGhlIHdvdWxkIGJlIGFibGUgdG8gZXhwbGFpbiBpdCBiZXR0ZXIgdGhl biBJLgpOaWNrCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CkxpbnV4cHBjLWRldiBtYWlsaW5nIGxpc3QKTGludXhwcGMtZGV2QGxpc3RzLm96bGFicy5vcmcK aHR0cHM6Ly9saXN0cy5vemxhYnMub3JnL2xpc3RpbmZvL2xpbnV4cHBjLWRldg==