From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Borntraeger Subject: Re: [PATCH v2 5/5] KVM: refactor asynchronous vcpu ioctl dispatch Date: Wed, 12 Aug 2015 22:03:08 +0200 Message-ID: <55CBA67C.1050703@de.ibm.com> References: <1438792381-19453-1-git-send-email-rkrcmar@redhat.com> <1438792381-19453-6-git-send-email-rkrcmar@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: kvm@vger.kernel.org, Paolo Bonzini To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , linux-kernel@vger.kernel.org Return-path: In-Reply-To: <1438792381-19453-6-git-send-email-rkrcmar@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org Am 05.08.2015 um 18:33 schrieb Radim Kr=C4=8Dm=C3=A1=C5=99: > I find the switch easier to read and modify. yes. > Signed-off-by: Radim Kr=C4=8Dm=C3=A1=C5=99 > --- > v2: new >=20 > virt/kvm/kvm_main.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) >=20 > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > index d7ffe6090520..71598554deed 100644 > --- a/virt/kvm/kvm_main.c > +++ b/virt/kvm/kvm_main.c > @@ -2252,12 +2252,15 @@ static long kvm_vcpu_ioctl(struct file *filp, > * Special cases: vcpu ioctls that are asynchronous to vcpu executi= on, > * so vcpu_load() would break it. > */ > + switch (ioctl) { > #if defined(CONFIG_S390) || defined(CONFIG_PPC) || defined(CONFIG_MI= PS) > - if (ioctl =3D=3D KVM_S390_INTERRUPT || ioctl =3D=3D KVM_S390_IRQ ||= ioctl =3D=3D KVM_INTERRUPT) > - return kvm_arch_vcpu_ioctl(filp, ioctl, arg); > + case KVM_S390_INTERRUPT: > + case KVM_S390_IRQ: > + case KVM_INTERRUPT: When you are it you might want to put the KVM_S390* withing CONFIG_S390= and KVM_INTERRUPT within CONFIG_PPC || CONFIG_MIPS This might speed up the switch statement for s390/ppc/mips a tiny bit. = It will add another ifdef, though. Paolo? > #endif > - if (ioctl =3D=3D KVM_USER_EXIT) > + case KVM_USER_EXIT: > return kvm_arch_vcpu_ioctl(filp, ioctl, arg); > + } >=20 > r =3D vcpu_load(vcpu); > if (r) >=20