Re: [PATCH RFC v3 14/16] media: add a generic function to remove a link

[Shuah Khan <shuahkh@osg.samsung.com>]

On 08/12/2015 02:52 PM, Mauro Carvalho Chehab wrote:
> Em Wed, 12 Aug 2015 14:45:52 -0600
> Shuah Khan <shuahkhan@gmail.com> escreveu:
> 
>> On Wed, Aug 12, 2015 at 2:14 PM, Mauro Carvalho Chehab
>> <mchehab@osg.samsung.com> wrote:
>>> Removing a link is simple. Yet, better to have a separate
>>> function for it, as we'll be also sharing it with a
>>> public API call.
>>>
>>> Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
>>
>> One thing to think about is whether or not we need some kind of callback
>> mechanism to alert the entity on the other side of the link and other entities
>> associated with the media device when a link is removed.
>>
>> This patch is fine for now and we can enhance it as and when we have the
>> need for such notifications.
> 
> Well, now, all elements of the graph are of the type media_graph_obj.
> 
> One of the things it is stored there is the media_device. It would
> be very easy to add a notify function[1] that would call a callback
> when a new object is created or removed. A single callback function
> could be used for any topology change.
> 
> So, I think that it is now simpler to track topology changes than
> before ;)
> 
> [1] Actually, I would implement a list with notification callbacks
> as more than one driver may want to be notified about topology
> changes.
> 

Right. It has to be a list as opposed to a single call.

-- Shuah


-- 
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@osg.samsung.com | (970) 217-8978