From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751976AbbHMGvf (ORCPT <rfc822;w@1wt.eu>);
	Thu, 13 Aug 2015 02:51:35 -0400
Received: from mga11.intel.com ([192.55.52.93]:9692 "EHLO mga11.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751442AbbHMGve (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 13 Aug 2015 02:51:34 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.15,667,1432623600"; 
   d="scan'208";a="747654812"
Message-ID: <55CC3DD5.6010607@intel.com>
Date: Thu, 13 Aug 2015 09:48:53 +0300
From: Adrian Hunter <adrian.hunter@intel.com>
Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki,
 Business Identity Code: 0357606 - 4, Domiciled in Helsinki 
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0
MIME-Version: 1.0
To: Arnaldo Carvalho de Melo <acme@kernel.org>
CC: Ingo Molnar <mingo@kernel.org>, linux-kernel@vger.kernel.org,
        Jiri Olsa <jolsa@redhat.com>
Subject: Re: [PATCH V8 03/25] perf tools: Add Intel PT instruction decoder
References: <1437150840-31811-1-git-send-email-adrian.hunter@intel.com> <1437150840-31811-4-git-send-email-adrian.hunter@intel.com> <20150812205541.GA30356@kernel.org>
In-Reply-To: <20150812205541.GA30356@kernel.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 12/08/15 23:55, Arnaldo Carvalho de Melo wrote:
> Em Fri, Jul 17, 2015 at 07:33:38PM +0300, Adrian Hunter escreveu:
>> Add support for decoding instructions for Intel Processor Trace.  The
>> kernel x86 instruction decoder is copied for this.
>>
>> This essentially provides intel_pt_get_insn() which takes a binary
>> buffer, uses the kernel's x86 instruction decoder to get details of the
>> instruction and then categorizes it for consumption by an Intel PT
>> decoder.
> 
> 
> [acme@felicio linux]$ rm -rf /tmp/build/perf ; mkdir -p /tmp/build/perf ; make -C tools/perf O=/tmp/build/perf install-bin
> make: Entering directory `/home/acme/git/linux/tools/perf'
>   BUILD:   Doing 'make -j4' parallel build
> 
> Auto-detecting system features:
> ...                         dwarf: [ on  ]
> ...                         glibc: [ on  ]
> ...                          gtk2: [ on  ]
> ...                      libaudit: [ on  ]
> ...                        libbfd: [ on  ]
> ...                        libelf: [ on  ]
> ...                       libnuma: [ on  ]
> ...                       libperl: [ on  ]
> ...                     libpython: [ on  ]
> ...                      libslang: [ on  ]
> ...                     libunwind: [ on  ]
> ...            libdw-dwarf-unwind: [ on  ]
> ...                          zlib: [ on  ]
> ...                          lzma: [ on  ]
> 
> <SNIP>
> 
>   CC       /tmp/build/perf/util/thread-stack.o
>   MKDIR    /tmp/build/perf/ui/tui/
>   CC       /tmp/build/perf/ui/tui/setup.o
>   CC       /tmp/build/perf/util/auxtrace.o
>   MKDIR    /tmp/build/perf/ui/browsers/
>   MKDIR    /tmp/build/perf/util/intel-pt-decoder/
>   CC       /tmp/build/perf/ui/browsers/hists.o
>   CC       /tmp/build/perf/util/intel-pt-decoder/intel-pt-pkt-decoder.o
>   MKDIR    /tmp/build/perf/ui/tui/
>   CC       /tmp/build/perf/ui/tui/util.o
>   GEN      /tmp/build/perf/util/intel-pt-decoder/inat-tables.c
>   MKDIR    /tmp/build/perf/util/scripting-engines/
>   CC       /tmp/build/perf/util/scripting-engines/trace-event-perl.o
>   CC       /tmp/build/perf/util/intel-pt-decoder/intel-pt-insn-decoder.o
>   CC       /tmp/build/perf/ui/tui/helpline.o
>   CC       /tmp/build/perf/ui/browsers/map.o
>   CC       /tmp/build/perf/ui/browsers/scripts.o
>   CC       /tmp/build/perf/ui/tui/progress.o
>   MKDIR    /tmp/build/perf/util/scripting-engines/
>   CC       /tmp/build/perf/util/scripting-engines/trace-event-python.o
> util/intel-pt-decoder/intel-pt-insn-decoder.c:26:18: fatal error: insn.c: No such file or directory
>  #include <insn.c>
>                   ^
> compilation terminated.

I had a fix for this already but for some reason it fell in with the "for
later" patches.

I will roll the fix in and send V9 of this patch.