From: David Vrabel <david.vrabel@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>,
Xen-devel <xen-devel@lists.xenproject.org>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Dario Faggioli <dario.faggioli@citrix.com>,
Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH for-4.6 2/3] xl: fix vNUMA vcpus parsing
Date: Thu, 13 Aug 2015 10:26:45 +0100 [thread overview]
Message-ID: <55CC62D5.7010706@citrix.com> (raw)
In-Reply-To: <1439408161-15015-3-git-send-email-wei.liu2@citrix.com>
On 12/08/15 20:36, Wei Liu wrote:
> Originally, if user didn't specify maxvcpus= in xl config file, the
> maximum size of vcpu bitmap was always equal to maximum number of pcpus.
> This might not be what user wants.
>
> Calculate the maximum number of vcpus before allocating vcpu bitmap.
> This requires parsing the same config options twice. Extra a macro to do
> that.
[...]
> +#define PARSE_VNUMA_SPEC(body)
Just when I though libxl/xl's macro craziness couldn't get any worse...
Do you want anyone else to be able to understand this code?
It looks like you can parse the option into a list of (option, value)
tuples and then iterate over this list twice.
David
next prev parent reply other threads:[~2015-08-13 9:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-12 19:35 [PATCH for-4.6 0/3] More vNUMA fixes Wei Liu
2015-08-12 19:35 ` [PATCH for-4.6 1/3] xl: fix vNUMA vdistance parsing Wei Liu
2015-08-13 8:35 ` Dario Faggioli
2015-08-12 19:36 ` [PATCH for-4.6 2/3] xl: fix vNUMA vcpus parsing Wei Liu
2015-08-13 9:26 ` David Vrabel [this message]
2015-08-13 9:32 ` Dario Faggioli
2015-08-13 9:47 ` Wei Liu
2015-08-13 9:42 ` Ian Campbell
2015-08-13 9:54 ` Wei Liu
2015-08-13 10:07 ` Ian Campbell
2015-08-13 10:28 ` Wei Liu
2015-08-13 10:40 ` Ian Campbell
2015-08-12 19:36 ` [PATCH for-4.6 3/3] libxc: fix vNUMA memory allocation Wei Liu
2015-08-13 8:34 ` Dario Faggioli
2015-08-13 20:23 ` Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55CC62D5.7010706@citrix.com \
--to=david.vrabel@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=dario.faggioli@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.