From: Paolo Bonzini <pbonzini@redhat.com>
To: "Christian Borntraeger" <borntraeger@de.ibm.com>,
"Radim Krčmář" <rkrcmar@redhat.com>,
linux-kernel@vger.kernel.org
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH v2 5/5] KVM: refactor asynchronous vcpu ioctl dispatch
Date: Thu, 13 Aug 2015 11:29:16 +0200 [thread overview]
Message-ID: <55CC636C.9080202@redhat.com> (raw)
In-Reply-To: <55CBA67C.1050703@de.ibm.com>
On 12/08/2015 22:03, Christian Borntraeger wrote:
>> > #if defined(CONFIG_S390) || defined(CONFIG_PPC) || defined(CONFIG_MIPS)
>> > - if (ioctl == KVM_S390_INTERRUPT || ioctl == KVM_S390_IRQ || ioctl == KVM_INTERRUPT)
>> > - return kvm_arch_vcpu_ioctl(filp, ioctl, arg);
>> > + case KVM_S390_INTERRUPT:
>> > + case KVM_S390_IRQ:
>> > + case KVM_INTERRUPT:
> When you are it you might want to put the KVM_S390* withing CONFIG_S390 and
> KVM_INTERRUPT within CONFIG_PPC || CONFIG_MIPS
>
> This might speed up the switch statement for s390/ppc/mips a tiny bit. It will add
> another ifdef, though. Paolo?
Sure. I wasn't sure of KVM_INTERRUPT's usage on s390.
I'm okay with keeping the switch inline too, but if Radim prefers a
function that's also fine.
Paolo
prev parent reply other threads:[~2015-08-13 9:29 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-05 16:32 [PATCH v2 0/5] KVM: optimize userspace exits with a new ioctl Radim Krčmář
2015-08-05 16:32 ` [PATCH v2 1/5] KVM: add kvm_has_request wrapper Radim Krčmář
2015-08-12 19:57 ` Christian Borntraeger
2015-08-13 9:11 ` Radim Krčmář
2015-08-13 9:29 ` Paolo Bonzini
2015-08-13 10:03 ` Christian Borntraeger
2015-08-14 8:42 ` Radim Krčmář
2015-08-05 16:32 ` [PATCH v2 2/5] KVM: add KVM_REQ_EXIT request for userspace exit Radim Krčmář
2015-08-05 16:32 ` [PATCH v2 3/5] KVM: x86: add request_exits debug counter Radim Krčmář
2015-08-05 16:33 ` [PATCH v2 4/5] KVM: add KVM_USER_EXIT vcpu ioctl for userspace exit Radim Krčmář
2015-08-05 16:36 ` Paolo Bonzini
2015-08-06 13:44 ` Radim Krčmář
2015-08-06 13:52 ` Paolo Bonzini
2015-08-06 17:21 ` Radim Krčmář
2015-08-16 20:27 ` Avi Kivity
2015-08-17 13:15 ` Paolo Bonzini
2015-08-18 18:30 ` Avi Kivity
2015-08-18 19:57 ` Paolo Bonzini
2015-08-19 6:43 ` Avi Kivity
2015-08-05 16:33 ` [PATCH v2 5/5] KVM: refactor asynchronous vcpu ioctl dispatch Radim Krčmář
2015-08-12 20:03 ` Christian Borntraeger
2015-08-13 8:53 ` Radim Krčmář
2015-08-13 9:29 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55CC636C.9080202@redhat.com \
--to=pbonzini@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.