From: Shuah Khan <shuahkh@osg.samsung.com>
To: Naresh Kamboju <naresh.kamboju@linaro.org>,
Tyler Baker <tyler.baker@linaro.org>
Cc: alexey.kodanev@oracle.com,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
lsk-team@linaro.org, Kevin Hilman <khilman@linaro.org>,
Milosz Wasilewski <milosz.wasilewski@linaro.org>,
Shuah Khan <shuahkh@osg.samsung.com>
Subject: Re: [PATCH] selftests/zram: Adding zram tests
Date: Thu, 13 Aug 2015 13:36:19 -0600 [thread overview]
Message-ID: <55CCF1B3.40900@osg.samsung.com> (raw)
In-Reply-To: <CA+G9fYs0+tr2f6nasFAH-mVU_=eysegB48Aozmp8M0QPVeti-w@mail.gmail.com>
On 08/13/2015 01:08 PM, Naresh Kamboju wrote:
> Hi Tyler,
>
> On 23 July 2015 at 05:30, Tyler Baker <tyler.baker@linaro.org> wrote:
>> Hi Naresh,
>>
>> On 7 July 2015 at 05:03, <naresh.kamboju@linaro.org> wrote:
>>> From: Naresh Kamboju <naresh.kamboju@linaro.org>
>>>
>>> zram_lib.sh: create library with initialization/cleanup functions
>>> zram01.sh: creates general purpose ram disks with different filesystems
>>> zram02.sh: creates block device for swap
>>> README: ZRAM introduction and Kconfig required.
>>> Makefile: To run zram tests
>>
>> (./zram01.sh && echo "selftests: zram01.sh [PASS]") || echo
>> "selftests: zram01.sh [FAIL]"
>> (./zram02.sh && echo "selftests: zram02.sh [PASS]") || echo
>> "selftests: zram02.sh [FAIL]"
>> (./zram_lib.sh && echo "selftests: zram_lib.sh [PASS]") || echo
>> "selftests: zram_lib.sh [FAIL]"
>>
>> Above is the output from the run_kselftests.sh. Do we want to run
>> zram_lib.sh as a test case as it just a library?
>
> zram_lib.sh is not a test as it just a library.
> run_kselftest.sh should not pick this file as test case. Any idea howto ?
>
TEST_PROGS := zram01.sh zram02.sh zram_lib.sh
The above tells run_kselftest.sh to run these.
You will have to add zram_lib.h to TEST_FILES instead.
Please take a look at other tests that do this. e.g: net/Makefile
thanks,
-- Shuah
--
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@osg.samsung.com | (970) 217-8978
next prev parent reply other threads:[~2015-08-13 19:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-07 12:03 [PATCH] selftests/zram: Adding zram tests naresh.kamboju
2015-07-23 0:00 ` Tyler Baker
2015-07-23 15:03 ` Shuah Khan
2015-08-13 19:21 ` Naresh Kamboju
2015-08-13 19:39 ` Shuah Khan
2015-08-13 19:08 ` Naresh Kamboju
2015-08-13 19:36 ` Shuah Khan [this message]
[not found] ` <CADRr18PYhpcget82C1u_yODVpzLAt0W=DiexCRwn99Wjz5ZqJg@mail.gmail.com>
2015-07-27 1:46 ` Alex Shi
2015-08-14 11:44 ` Alexey Kodanev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55CCF1B3.40900@osg.samsung.com \
--to=shuahkh@osg.samsung.com \
--cc=alexey.kodanev@oracle.com \
--cc=khilman@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lsk-team@linaro.org \
--cc=milosz.wasilewski@linaro.org \
--cc=naresh.kamboju@linaro.org \
--cc=tyler.baker@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.