From mboxrd@z Thu Jan  1 00:00:00 1970
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [PATCH for-4.6 3/3] libxc: fix vNUMA memory
	allocation
Date: Thu, 13 Aug 2015 16:23:09 -0400
Message-ID: <55CCFCAD.2090906@oracle.com>
References: <1439408161-15015-1-git-send-email-wei.liu2@citrix.com>
	<1439408161-15015-4-git-send-email-wei.liu2@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <boris.ostrovsky@oracle.com>) id 1ZPz2j-00011d-SZ
	for xen-devel@lists.xenproject.org; Thu, 13 Aug 2015 20:24:05 +0000
In-Reply-To: <1439408161-15015-4-git-send-email-wei.liu2@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>, Xen-devel <xen-devel@lists.xenproject.org>
Cc: Dario Faggioli <dario.faggioli@citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Ian Campbell <ian.campbell@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 08/12/2015 03:36 PM, Wei Liu wrote:
> We should use new_memflags in xc_domain_populate_physmap. That variable
> contains node information.
>
> Reported-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>

Tested-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>

> ---
>   tools/libxc/xc_hvm_build_x86.c | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/tools/libxc/xc_hvm_build_x86.c b/tools/libxc/xc_hvm_build_x86.c
> index ec11f15..ea250dd 100644
> --- a/tools/libxc/xc_hvm_build_x86.c
> +++ b/tools/libxc/xc_hvm_build_x86.c
> @@ -486,7 +486,8 @@ static int setup_guest(xc_interface *xch,
>   
>                   done = xc_domain_populate_physmap(xch, dom, nr_extents,
>                                                     SUPERPAGE_1GB_SHIFT,
> -                                                  memflags, sp_extents);
> +                                                  new_memflags,
> +                                                  sp_extents);
>   
>                   if ( done > 0 )
>                   {
> @@ -526,7 +527,8 @@ static int setup_guest(xc_interface *xch,
>   
>                       done = xc_domain_populate_physmap(xch, dom, nr_extents,
>                                                         SUPERPAGE_2MB_SHIFT,
> -                                                      memflags, sp_extents);
> +                                                      new_memflags,
> +                                                      sp_extents);
>   
>                       if ( done > 0 )
>                       {