From: Ben YoungTae Kim <ytkim@qca.qualcomm.com>
To: Marcel Holtmann <marcel@holtmann.org>,
Ben Young Tae Kim <ytkim@qca.qualcomm.com>
Cc: <linux-bluetooth@vger.kernel.org>
Subject: Re: Bluetooth: hciuart: Fix to use boolean flag with u32 type
Date: Thu, 13 Aug 2015 22:05:30 -0700 [thread overview]
Message-ID: <55CD771A.4000704@qualcomm.com> (raw)
In-Reply-To: <8F5EF1AB-8CAF-45B0-85CC-AC3C565728D9@holtmann.org>
Hi Marcel,
On 8/13/15 9:14 PM, Marcel Holtmann wrote:
> Hi Ben,
>
>> debugfs_create_bool is asking to put u32 type pointer instead of bool
>> so that passing bool type with u32* cast will cause memory corruption
>> to read that value since it is handled by 4 bytes instead of 1 byte
>> inside.
>>
>> Signed-off-by: Ben Young Tae Kim <ytkim@qca.qualcomm.com>
>> ---
>> drivers/bluetooth/hci_qca.c | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
> this patch does not apply against bluetooth-next tree.
Looks like tabs in patch body was converted with space on email client again since that was sent on new setup(desktop). It was applied properly on my side against bluetooth-next tree. I'll send another one. Sorry for bothering you again.
> Regards
>
> Marcel
>
prev parent reply other threads:[~2015-08-14 5:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-13 23:06 Bluetooth: hciuart: Fix to use boolean flag with u32 type Ben Young Tae Kim
2015-08-14 4:14 ` Marcel Holtmann
2015-08-14 5:05 ` Ben YoungTae Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55CD771A.4000704@qualcomm.com \
--to=ytkim@qca.qualcomm.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.