From: Ian Abbott <abbotti@mev.co.uk>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] staging: comedi: me4000: use bitwise AND instead of logical
Date: Fri, 14 Aug 2015 10:29:05 +0000 [thread overview]
Message-ID: <55CDC2F1.8080704@mev.co.uk> (raw)
In-Reply-To: <20150814085405.GB30728@mwanda>
On 14/08/15 09:54, Dan Carpenter wrote:
> This was supposed to bitwise AND but there is a typo.
>
> Fixes: 1a02387063fb ('staging: comedi: me4000: remove 'board' from me4000_ai_insn_read()')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/staging/comedi/drivers/me4000.c b/drivers/staging/comedi/drivers/me4000.c
> index 5aa1780..15a5320 100644
> --- a/drivers/staging/comedi/drivers/me4000.c
> +++ b/drivers/staging/comedi/drivers/me4000.c
> @@ -480,7 +480,7 @@ static int me4000_ai_insn_read(struct comedi_device *dev,
>
> entry = chan | ME4000_AI_LIST_RANGE(range);
> if (aref = AREF_DIFF) {
> - if (!(s->subdev_flags && SDF_DIFF)) {
> + if (!(s->subdev_flags & SDF_DIFF)) {
> dev_err(dev->class_dev,
> "Differential inputs are not available\n");
> return -EINVAL;
> @@ -559,7 +559,7 @@ static int me4000_ai_check_chanlist(struct comedi_device *dev,
> }
>
> if (aref = AREF_DIFF) {
> - if (!(s->subdev_flags && SDF_DIFF)) {
> + if (!(s->subdev_flags & SDF_DIFF)) {
> dev_err(dev->class_dev,
> "Differential inputs are not available\n");
> return -EINVAL;
>
Thanks for catching that.
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
next prev parent reply other threads:[~2015-08-14 10:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-14 8:54 [patch] staging: comedi: me4000: use bitwise AND instead of logical Dan Carpenter
2015-08-14 10:29 ` Ian Abbott [this message]
2015-08-14 17:40 ` Hartley Sweeten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55CDC2F1.8080704@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.