From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans Verkuil Subject: Re: [PATCH v4 1/6] media: get rid of unused "extra_links" param on media_entity_init() Date: Fri, 14 Aug 2015 16:59:52 +0200 Message-ID: <55CE0268.9050400@xs4all.nl> References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-sh-owner@vger.kernel.org To: Mauro Carvalho Chehab , Linux Media Mailing List Cc: Mauro Carvalho Chehab , Jonathan Corbet , Harry Wei , Hans Verkuil , Sakari Ailus , Lars-Peter Clausen , Laurent Pinchart , Kyungmin Park , Heungjun Kim , Prabhakar Lad , Andrzej Hajda , Mats Randgaard , Sylwester Nawrocki , Kukjin Kim , Krzysztof Kozlowski , Hyun Kwon , Michal Simek , =?UTF-8?B?U8O2cmVuIEJyaW5rbWFubg==?= , Greg Kroah-Hartman , Joe Perches , Boris BREZILLON List-Id: linux-samsung-soc@vger.kernel.org On 08/14/2015 04:56 PM, Mauro Carvalho Chehab wrote: > Currently, media_entity_init() creates an array with the links, > allocated at init time. It provides a parameter (extra_links) > that would allocate more links than the current needs, but this > is not used by any driver. > > As we want to be able to do dynamic link allocation/removal, > we'll need to change the implementation of the links. So, > before doing that, let's first remove that extra unused > parameter, in order to cleanup the interface first. > > Signed-off-by: Mauro Carvalho Chehab > Acked-by: Sakari Ailus Acked-by: Hans Verkuil Thanks! Hans From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans Verkuil Date: Fri, 14 Aug 2015 14:59:52 +0000 Subject: Re: [PATCH v4 1/6] media: get rid of unused "extra_links" param on media_entity_init() Message-Id: <55CE0268.9050400@xs4all.nl> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org On 08/14/2015 04:56 PM, Mauro Carvalho Chehab wrote: > Currently, media_entity_init() creates an array with the links, > allocated at init time. It provides a parameter (extra_links) > that would allocate more links than the current needs, but this > is not used by any driver. > > As we want to be able to do dynamic link allocation/removal, > we'll need to change the implementation of the links. So, > before doing that, let's first remove that extra unused > parameter, in order to cleanup the interface first. > > Signed-off-by: Mauro Carvalho Chehab > Acked-by: Sakari Ailus Acked-by: Hans Verkuil Thanks! Hans From mboxrd@z Thu Jan 1 00:00:00 1970 From: hverkuil@xs4all.nl (Hans Verkuil) Date: Fri, 14 Aug 2015 16:59:52 +0200 Subject: [PATCH v4 1/6] media: get rid of unused "extra_links" param on media_entity_init() In-Reply-To: References: Message-ID: <55CE0268.9050400@xs4all.nl> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 08/14/2015 04:56 PM, Mauro Carvalho Chehab wrote: > Currently, media_entity_init() creates an array with the links, > allocated at init time. It provides a parameter (extra_links) > that would allocate more links than the current needs, but this > is not used by any driver. > > As we want to be able to do dynamic link allocation/removal, > we'll need to change the implementation of the links. So, > before doing that, let's first remove that extra unused > parameter, in order to cleanup the interface first. > > Signed-off-by: Mauro Carvalho Chehab > Acked-by: Sakari Ailus Acked-by: Hans Verkuil Thanks! Hans From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from lb2-smtp-cloud2.xs4all.net ([194.109.24.25]:48125 "EHLO lb2-smtp-cloud2.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755465AbbHNPAd (ORCPT ); Fri, 14 Aug 2015 11:00:33 -0400 Message-ID: <55CE0268.9050400@xs4all.nl> Date: Fri, 14 Aug 2015 16:59:52 +0200 From: Hans Verkuil MIME-Version: 1.0 To: Mauro Carvalho Chehab , Linux Media Mailing List CC: Mauro Carvalho Chehab , Jonathan Corbet , Harry Wei , Hans Verkuil , Sakari Ailus , Lars-Peter Clausen , Laurent Pinchart , Kyungmin Park , Heungjun Kim , Prabhakar Lad , Andrzej Hajda , Mats Randgaard , Sylwester Nawrocki , Kukjin Kim , Krzysztof Kozlowski , Hyun Kwon , Michal Simek , =?UTF-8?B?U8O2cmVuIEJyaW5rbWFubg==?= , Greg Kroah-Hartman , Joe Perches , Boris BREZILLON , Javier Martinez Canillas , Guennadi Liakhovetski , Ricardo Ribalda Delgado , Axel Lin , Scott Jiang , Bryan Wu , Jacek Anaszewski , Aya Mahfouz , Haneen Mohammed , Tapasweni Pathak , anuvazhayil , Mahati Chamarthy , Navya Sri Nizamkari , linux-doc@vger.kernel.org, linux-kernel@zh-kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-sh@vger.kernel.org, devel@driverdev.osuosl.org Subject: Re: [PATCH v4 1/6] media: get rid of unused "extra_links" param on media_entity_init() References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: On 08/14/2015 04:56 PM, Mauro Carvalho Chehab wrote: > Currently, media_entity_init() creates an array with the links, > allocated at init time. It provides a parameter (extra_links) > that would allocate more links than the current needs, but this > is not used by any driver. > > As we want to be able to do dynamic link allocation/removal, > we'll need to change the implementation of the links. So, > before doing that, let's first remove that extra unused > parameter, in order to cleanup the interface first. > > Signed-off-by: Mauro Carvalho Chehab > Acked-by: Sakari Ailus Acked-by: Hans Verkuil Thanks! Hans