All of lore.kernel.org
 help / color / mirror / Atom feed
From: York Sun <yorksun@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] armv7/fsl-ls102xa: Workaround for DDR erratum A008514
Date: Fri, 14 Aug 2015 10:23:51 -0700	[thread overview]
Message-ID: <55CE2427.7000501@freescale.com> (raw)
In-Reply-To: <1439535264-41637-1-git-send-email-yao.yuan@freescale.com>



On 08/13/2015 11:54 PM, Yuan Yao wrote:
> Affects: DDR
> Description: Memory controller performance is not optimal with default
> internal target queue register values.
> Impact: Memory controller performance is not optimal.
> Workaround: Write a value of 63b2_0002h to address: 157_020Ch.
> 
> Signed-off-by: Yuan Yao <yao.yuan@freescale.com>
> ---
>  arch/arm/include/asm/arch-ls102xa/immap_ls102xa.h |  2 +-
>  board/freescale/ls1021aqds/ls1021aqds.c           | 10 ++++++++++
>  board/freescale/ls1021atwr/ls1021atwr.c           | 10 ++++++++++
>  3 files changed, 21 insertions(+), 1 deletion(-)

Yuan,

This is a wrong place to implement this workaround. It is a SoC erratum, not a
board erratum. This erratum applies to both LS1021A and LS2085A. The workaround
for LS2085A is already implemented in drivers/ddr/fsl/fsl_ddr_gen4.c. LS1021A
supports both DDR3 and DDR4 modes. I started a discussion (CC'ed you) with the
designer to clarify if both modes are impacted. If yes, you can add the
workaround in drivers/ddr/fsl/arm_ddr_gen3.c, and make sure to add proper
address offset in drivers/ddr/fsl/fsl_ddr_gen4.c.

York

      parent reply	other threads:[~2015-08-14 17:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-14  6:54 [U-Boot] [PATCH 1/3] armv7/fsl-ls102xa: Workaround for DDR erratum A008514 Yuan Yao
2015-08-14  6:54 ` [U-Boot] [PATCH 2/3] LS102XA:workaround:disable priorities within DDR Yuan Yao
2015-08-14 16:28   ` Sinan Akman
2015-08-18 19:13   ` York Sun
2015-08-14  6:54 ` [U-Boot] [PATCH 3/3] ls102xa: Enable snoop and DVM message requests Yuan Yao
2015-08-18 19:15   ` York Sun
2015-08-14 16:28 ` [U-Boot] [PATCH 1/3] armv7/fsl-ls102xa: Workaround for DDR erratum A008514 Sinan Akman
2015-08-17  2:37   ` Yao Yuan
2015-08-14 17:23 ` York Sun [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55CE2427.7000501@freescale.com \
    --to=yorksun@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.