All of lore.kernel.org
 help / color / mirror / Atom feed
From: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Bart Van Assche <bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
Cc: Sagi Grimberg <sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] IB/core, cma: Make __attribute_const__ declarations sparse-friendly
Date: Fri, 14 Aug 2015 15:27:08 -0400	[thread overview]
Message-ID: <55CE410C.7080002@redhat.com> (raw)
In-Reply-To: <55BF9E80.3030306-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 813 bytes --]

On 08/03/2015 01:01 PM, Bart Van Assche wrote:
> Move the __attribute_const__ declarations such that sparse understands
> that these apply to the function itself and not to the return type.
> This avoids that sparse reports error messages like the following:
> 
> drivers/infiniband/core/verbs.c:73:12: error: symbol 'ib_event_msg' redeclared with different type (originally declared at include/rdma/ib_verbs.h:470) - different modifiers
> 
> Fixes: 2b1b5b601230 ("IB/core, cma: Nice log-friendly string helpers")
> Signed-off-by: Bart Van Assche <bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
> Cc: Sagi Grimberg <sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

Thanks, applied.

-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
              GPG KeyID: 0E572FDD



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]

  parent reply	other threads:[~2015-08-14 19:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-03 17:01 [PATCH] IB/core, cma: Make __attribute_const__ declarations sparse-friendly Bart Van Assche
     [not found] ` <55BF9E80.3030306-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2015-08-04 16:54   ` Sagi Grimberg
2015-08-14 19:27   ` Doug Ledford [this message]
     [not found]     ` <55CE410C.7080002-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-10-29 21:16       ` Bart Van Assche
     [not found]         ` <56328C9A.1030105-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2015-10-30 22:00           ` Doug Ledford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55CE410C.7080002@redhat.com \
    --to=dledford-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.