All of lore.kernel.org
 help / color / mirror / Atom feed
From: Randy MacLeod <randy.macleod@windriver.com>
To: Robert Yang <liezhi.yang@windriver.com>,
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/3] toolchain-shar-extract.sh: add a space in the end
Date: Fri, 14 Aug 2015 21:23:34 -0400	[thread overview]
Message-ID: <55CE9496.6040401@windriver.com> (raw)
In-Reply-To: <67e4fb4b7a8dc0c7e955e5ea5e4fc2048961f61b.1439449078.git.liezhi.yang@windriver.com>

Nit pick on logs...

In the short log:
s/add a space in the end/
  /Add a space after asking a question/

On 2015-08-13 03:37 AM, Robert Yang wrote:
> For a clear look when input.
This is a sentence fragment. It will read better if you repeat yourself:

Add a space at the end of a line when asking a question.
This makes it easier to read.

../Randy
>
> [YOCTO #8089]
>
> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> ---
>   meta/files/toolchain-shar-extract.sh |    4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/files/toolchain-shar-extract.sh b/meta/files/toolchain-shar-extract.sh
> index 0a33ee8..3a50991 100644
> --- a/meta/files/toolchain-shar-extract.sh
> +++ b/meta/files/toolchain-shar-extract.sh
> @@ -92,11 +92,11 @@ fi
>
>   if [ -e "$target_sdk_dir/environment-setup-@REAL_MULTIMACH_TARGET_SYS@" ]; then
>   	echo "The directory \"$target_sdk_dir\" already contains a SDK for this architecture."
> -	printf "If you continue, existing files will be overwritten! Proceed[y/N]?"
> +	printf "If you continue, existing files will be overwritten! Proceed[y/N]? "
>
>   	default_answer="n"
>   else
> -	printf "You are about to install the SDK to \"$target_sdk_dir\". Proceed[Y/n]?"
> +	printf "You are about to install the SDK to \"$target_sdk_dir\". Proceed[Y/n]? "
>
>   	default_answer="y"
>   fi
>


-- 
# Randy MacLeod. SMTS, Linux, Wind River
Direct: 613.963.1350 | 350 Terry Fox Drive, Suite 200, Ottawa, ON, 
Canada, K2K 2W5


  reply	other threads:[~2015-08-15  1:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-13  7:37 [PATCH 0/3] populate_sdk_base.bbclass: fixes for multilib sdk Robert Yang
2015-08-13  7:37 ` [PATCH 1/3] toolchain-shar-extract.sh: add a space in the end Robert Yang
2015-08-15  1:23   ` Randy MacLeod [this message]
2015-08-17  2:27     ` Robert Yang
2015-08-13  7:37 ` [PATCH 2/3] populate_sdk_base.bbclass: help rpm to pull in multilib toolchain Robert Yang
2015-08-15  8:55   ` Richard Purdie
2015-08-17  2:27     ` Robert Yang
2015-08-13  7:37 ` [PATCH 3/3] packagegroup-core-standalone-sdk-target: remove qemuwrapper-cross Robert Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55CE9496.6040401@windriver.com \
    --to=randy.macleod@windriver.com \
    --cc=liezhi.yang@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.