Re: [PATCH] IB/mlx4: Fix possible incorrect cq completions flushing in internal error state

[Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1113 bytes --]

On 08/09/2015 04:16 AM, Sagi Grimberg wrote:
> From: Ariel Nahum <arieln-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> 
> When handling a device internal error, the driver is responsible to
> drain the completion queue with flush errors.
> 
> In case a completion queue was assigned to multiple send queues, the
> driver iterates over the send queues and generates flush errors of
> inflight wqes. The driver must correctly pass the wc array with an
> offset as a result of the previous send queue iteration. Not doing so
> will overwrite previously set completions and return a wrong number
> of polled completions which includes ones which were not correctly set.
> 
> Fixes: 35f05dabf95a (IB/mlx4: Reset flow support for IB kernel ULPs)
> Signed-off-by: Ariel Nahum <arieln-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> Signed-off-by: Sagi Grimberg <sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> Cc: Yishai Hadas <yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

Applied, thanks.


-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
              GPG KeyID: 0E572FDD



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]