All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2 06/10] fat: ffconf.h changes for U-Boot port
Date: Fri, 14 Aug 2015 21:40:48 -0600	[thread overview]
Message-ID: <55CEB4C0.4000200@wwwdotorg.org> (raw)
In-Reply-To: <20150814184744.GG25532@bill-the-cat>

On 08/14/2015 12:47 PM, Tom Rini wrote:
> On Tue, Aug 11, 2015 at 08:55:41AM -0600, Stephen Warren wrote:
>> Turn on _FS_NORTC: This means we don't have to implement
>> get_fattime() which simplifies life for now.
>> 
>> Automatically set _FS_READONLY based on CONFIG_FAT_WRITE. This
>> requires including <config.h> since we reference CONFIG_*.
>> 
>> Set _USE_LFN to enable long filename handling; an essential
>> feature.
>> 
>> Set _FS_RPATH so that paths components "." and ".." are correctly
>> parsed and handled. This enables paths such as "/extlinux/../foo"
>> to work.
>> 
>> Set _USE_LABEL so that volume labels can be read.
> 
> Hmm, is there some way to wrap volume label support in Kconfig?
> I'm sure this is useful in some cases, but maybe something that
> boards that are already on the cusp of their size limit would want
> off?

It's certainly possible; ffconf.h's definition of _FS_READONLY is
already driven by CONFIG_FAT_WRITE in this series.

I'm not sure if it's worth it though; on the RPi, turning off volume
label support only saves ~0.5K of .text, 0 .data, and 8 bytes .bss. If
so, I can certainly throw in another patch to allow it to be configured.

  reply	other threads:[~2015-08-15  3:40 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-11 14:55 [U-Boot] [PATCH V2 00/10] Replace the FAT filesystem code Stephen Warren
2015-08-11 14:55 ` [U-Boot] [PATCH V2 01/10] disk: support host devices in dev_print() Stephen Warren
2015-08-11 14:55 ` [U-Boot] [PATCH V2 02/10] fat: move to a different directory Stephen Warren
2015-08-11 14:55 ` [U-Boot] [PATCH V2 03/10] fat: add ff.c implementation Stephen Warren
2015-08-11 14:55 ` [U-Boot] [PATCH V2 04/10] fat: apply upstream bugfix to ff.c Stephen Warren
2015-08-11 14:55 ` [U-Boot] [PATCH V2 05/10] fat: ff: add ifdef to avoid unused function warning Stephen Warren
2015-08-11 14:55 ` [U-Boot] [PATCH V2 06/10] fat: ffconf.h changes for U-Boot port Stephen Warren
2015-08-14 18:47   ` Tom Rini
2015-08-15  3:40     ` Stephen Warren [this message]
2015-08-15 13:07       ` Tom Rini
2015-08-19  4:01         ` Stephen Warren
2015-08-11 14:55 ` [U-Boot] [PATCH V2 07/10] fat: port integer.h to U-Boot types Stephen Warren
2015-08-11 14:55 ` [U-Boot] [PATCH V2 08/10] fat: add U-Boot to ff.c API conversion wrapper Stephen Warren
2015-08-11 14:55 ` [U-Boot] [PATCH V2 09/10] fat: switch to new FAT implementation Stephen Warren
2015-08-11 14:55 ` [U-Boot] [PATCH V2 10/10] fat: remove old implementation Stephen Warren
2015-08-13  2:56 ` [U-Boot] [PATCH V2 00/10] Replace the FAT filesystem code Simon Glass
2015-08-15  3:36   ` Stephen Warren
2015-08-14 19:29 ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55CEB4C0.4000200@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.