From: Stephen Warren <swarren@wwwdotorg.org>
To: Eric Anholt <eric@anholt.net>
Cc: linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rpi-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Lee Jones <lee@kernel.org>,
Stephen Boyd <sboyd@codeaurora.org>,
Mike Turquette <mturquette@linaro.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v5 3/3] ARM: bcm2835: Add DT for the firmware clocks driver.
Date: Fri, 14 Aug 2015 22:13:31 -0600 [thread overview]
Message-ID: <55CEBC6B.9070001@wwwdotorg.org> (raw)
In-Reply-To: <1439507142-2965-4-git-send-email-eric@anholt.net>
On 08/13/2015 05:05 PM, Eric Anholt wrote:
> Signed-off-by: Eric Anholt <eric@anholt.net>
> Acked-by: Lee Jones <lee@kernel.org>
A patch description might be nice, although admittedly the subject seems
clear enough.
> diff --git a/arch/arm/boot/dts/bcm2835-rpi.dtsi b/arch/arm/boot/dts/bcm2835-rpi.dtsi
> + firmware_clocks: firmware-clocks {
> + compatible = "raspberrypi,bcm2835-firmware-clocks";
> + #clock-cells = <1>;
> + raspberrypi,firmware = <&firmware>;
> + };
No need to resend for this, but just a background note: DT node names
usually contain a device type not a device identity, so "clocks" not
"firmware-clocks" would be typical.
This patch,
Acked-by: Stephen Warren <swarren@wwwdotorg.org>
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 3/3] ARM: bcm2835: Add DT for the firmware clocks driver.
Date: Fri, 14 Aug 2015 22:13:31 -0600 [thread overview]
Message-ID: <55CEBC6B.9070001@wwwdotorg.org> (raw)
In-Reply-To: <1439507142-2965-4-git-send-email-eric@anholt.net>
On 08/13/2015 05:05 PM, Eric Anholt wrote:
> Signed-off-by: Eric Anholt <eric@anholt.net>
> Acked-by: Lee Jones <lee@kernel.org>
A patch description might be nice, although admittedly the subject seems
clear enough.
> diff --git a/arch/arm/boot/dts/bcm2835-rpi.dtsi b/arch/arm/boot/dts/bcm2835-rpi.dtsi
> + firmware_clocks: firmware-clocks {
> + compatible = "raspberrypi,bcm2835-firmware-clocks";
> + #clock-cells = <1>;
> + raspberrypi,firmware = <&firmware>;
> + };
No need to resend for this, but just a background note: DT node names
usually contain a device type not a device identity, so "clocks" not
"firmware-clocks" would be typical.
This patch,
Acked-by: Stephen Warren <swarren@wwwdotorg.org>
next prev parent reply other threads:[~2015-08-15 4:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-13 23:05 Rasperry Pi clock support Eric Anholt
2015-08-13 23:05 ` Eric Anholt
2015-08-13 23:05 ` Eric Anholt
2015-08-13 23:05 ` [PATCH v5 1/3] clk: bcm2835: Add binding docs for the Raspberry Pi clock provider Eric Anholt
2015-08-13 23:05 ` Eric Anholt
2015-08-13 23:05 ` Eric Anholt
2015-08-25 0:31 ` Eric Anholt
2015-08-25 0:31 ` Eric Anholt
2015-08-25 0:31 ` Eric Anholt
2015-08-13 23:05 ` [PATCH v5 2/3] clk: Add a Raspberry Pi-specific clock driver Eric Anholt
2015-08-13 23:05 ` Eric Anholt
2015-08-15 4:28 ` Stephen Warren
2015-08-15 4:28 ` Stephen Warren
2015-08-15 4:28 ` Stephen Warren
2015-08-13 23:05 ` [PATCH v5 3/3] ARM: bcm2835: Add DT for the firmware clocks driver Eric Anholt
2015-08-13 23:05 ` Eric Anholt
2015-08-15 4:13 ` Stephen Warren [this message]
2015-08-15 4:13 ` Stephen Warren
2015-08-27 10:48 ` Lee Jones
2015-08-27 10:48 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55CEBC6B.9070001@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=devicetree@vger.kernel.org \
--cc=eric@anholt.net \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=mturquette@linaro.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.