From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1ZQUWV-0005g0-Cr for mharc-grub-devel@gnu.org; Sat, 15 Aug 2015 02:00:55 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46606) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZQUWT-0005fD-6V for grub-devel@gnu.org; Sat, 15 Aug 2015 02:00:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZQUWO-0001x4-6k for grub-devel@gnu.org; Sat, 15 Aug 2015 02:00:53 -0400 Received: from ppsw-50.csi.cam.ac.uk ([131.111.8.150]:38538) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZQUWO-0001wK-11 for grub-devel@gnu.org; Sat, 15 Aug 2015 02:00:48 -0400 X-Cam-AntiVirus: no malware found X-Cam-ScannerInfo: http://www.cam.ac.uk/cs/email/scanner/ Received: from 173-160-221-205-washington.hfc.comcastbusiness.net ([173.160.221.205]:59192 helo=[192.168.22.166]) by ppsw-50.csi.cam.ac.uk (smtp.hermes.cam.ac.uk [131.111.8.158]:465) with esmtpsa (PLAIN:amc96) (TLSv1.2:DHE-RSA-AES128-SHA:128) id 1ZQUWH-00080C-rV (Exim 4.82_3-c0e5623) (return-path ); Sat, 15 Aug 2015 07:00:41 +0100 Message-ID: <55CED583.7000303@citrix.com> Date: Sat, 15 Aug 2015 07:00:35 +0100 From: Andrew Cooper User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Jan Beulich , Daniel Kiper , Konrad Rzeszutek Wilk Subject: Re: [Xen-devel] [PATCH v2 08/23] x86: add multiboot2 protocol support References: <1437402558-7313-1-git-send-email-daniel.kiper@oracle.com> <1437402558-7313-9-git-send-email-daniel.kiper@oracle.com> <20150810191747.GE13576@l.oracle.com> <20150813192212.GI3503@olila.local.net-space.pl> <55CDD8F4020000780009AF3C@prv-mh.provo.novell.com> In-Reply-To: <55CDD8F4020000780009AF3C@prv-mh.provo.novell.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: Andrew Cooper X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 131.111.8.150 Cc: Juergen Gross , grub-devel@gnu.org, wei.liu2@citrix.com, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, phcoder@gmail.com, roy.franz@linaro.org, ning.sun@intel.com, david.vrabel@citrix.com, xen-devel@lists.xenproject.org, qiaowei.ren@intel.com, keir@xen.org, richard.l.maliszewski@intel.com, gang.wei@intel.com, fu.wei@linaro.org X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 15 Aug 2015 06:00:54 -0000 On 14/08/15 11:03, Jan Beulich wrote: >>>> On 13.08.15 at 21:22, wrote: >> On Mon, Aug 10, 2015 at 03:17:48PM -0400, Konrad Rzeszutek Wilk wrote: >>> On Mon, Jul 20, 2015 at 04:29:03PM +0200, Daniel Kiper wrote: >>>> @@ -34,6 +57,42 @@ multiboot1_header_start: /*** MULTIBOOT1 HEADER ****/ >>>> .long -(MULTIBOOT_HEADER_MAGIC + MULTIBOOT_HEADER_FLAGS) >>>> multiboot1_header_end: >>>> >>>> +/*** MULTIBOOT2 HEADER ****/ >>>> +/* Some ideas are taken from grub-2.00/grub-core/tests/boot/kernel-i386.S file. */ >>>> + .align MULTIBOOT2_HEADER_ALIGN >>>> + >>>> +.Lmultiboot2_header: >>> How come you use .L? It makes this hidden while the multiboot1 headers >>> are visible? Makes it a bit harder to see the contents of this under >>> an debugger. >> Good point. IIRC, Jan asked about that. I will remove .L if he does not >> object. > For this particular one I think it's okay to drop the .L, but generally > I'd like to see .L used more widely for any auxiliary labels (i.e. only > "main" labels - function entry points and data objects - should have > their labels present in the final symbol table). In general I would agree. However, the multiboot 1 and 2 headers are special. They are binary data included in the .text section, so having non-local lables makes the disassembly easier to read. ~Andrew