From: David Ahern <dsa@cumulusnetworks.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Miller <davem@davemloft.net>, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] ipv4: fix refcount leak in fib_check_nh()
Date: Sat, 15 Aug 2015 14:36:09 -0600 [thread overview]
Message-ID: <55CFA2B9.50207@cumulusnetworks.com> (raw)
In-Reply-To: <1439661247.7258.10.camel@edumazet-glaptop2.roam.corp.google.com>
On 8/15/15 11:54 AM, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@google.com>
>
> fib_lookup() forces FIB_LOOKUP_NOREF flag, while fib_table_lookup()
> does not.
>
> This patch solves the typical message at reboot time or device
> dismantle :
>
> unregister_netdevice: waiting for eth0 to become free. Usage count = 4
>
> Fixes: 3bfd847203c6 ("net: Use passed in table for nexthop lookups")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: David Ahern <dsa@cumulusnetworks.com>
Still puzzled why I was not seeing the refcnt problem at reboot though I
did see the extra dev_hold when I instrumented the hold and put.
Anyways, thanks for resolving, Eric.
Acked-by: David Ahern <dsa@cumulusnetworks.com>
next prev parent reply other threads:[~2015-08-15 20:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-14 21:14 [BUG net-next] infamous dev refcnt leak... again Eric Dumazet
2015-08-14 23:14 ` Eric Dumazet
2015-08-14 23:19 ` David Ahern
2015-08-14 23:31 ` Eric Dumazet
2015-08-15 0:26 ` Eric Dumazet
2015-08-15 17:54 ` [PATCH net-next] ipv4: fix refcount leak in fib_check_nh() Eric Dumazet
2015-08-15 20:36 ` David Ahern [this message]
2015-08-17 5:14 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55CFA2B9.50207@cumulusnetworks.com \
--to=dsa@cumulusnetworks.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.