All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-watchdog@vger.kernel.org, Wim Van Sebroeck <wim@iguana.be>,
	linux-kernel@vger.kernel.org,
	Timo Kokkonen <timo.kokkonen@offcode.fi>,
	linux-doc@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>
Subject: Re: [PATCH v2 4/8] watchdog: Make set_timeout function optional
Date: Sat, 15 Aug 2015 16:41:31 -0700	[thread overview]
Message-ID: <55CFCE2B.9010802@roeck-us.net> (raw)
In-Reply-To: <20150814190535.GV9999@pengutronix.de>

Hi Uwe,

On 08/14/2015 12:05 PM, Uwe Kleine-König wrote:
> Hello Guenter,
>
> On Fri, Aug 07, 2015 at 10:02:43PM -0700, Guenter Roeck wrote:
>> For some watchdogs, the hardware timeout is fixed, and the
>> watchdog driver depends on the watchdog core to handle the
>> actual timeout. In this situation, the watchdog driver might
>> only set the 'timeout' variable but do nothing else.
>> This can as well be handled by the infrastructure, so make
>> the set_timeout callback optional. If WDIOF_SETTIMEOUT is
>> configured but the .set_timeout callback is not available,
>> update the timeout variable in the infrastructure code.
>>
>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>

Thanks!
Guenter



  reply	other threads:[~2015-08-15 23:41 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-08  5:02 [PATCH v2 0/8] watchdog: Add support for keepalives triggered by infrastructure Guenter Roeck
2015-08-08  5:02 ` [PATCH v2 1/8] watchdog: watchdog_dev: Use single variable name for struct watchdog_device Guenter Roeck
2015-08-08  5:02 ` [PATCH v2 2/8] watchdog: Introduce hardware maximum timeout in watchdog core Guenter Roeck
2015-08-13 21:13   ` Uwe Kleine-König
2015-08-15 23:17     ` Guenter Roeck
2015-08-14 11:23   ` Uwe Kleine-König
2015-08-15 23:21     ` Guenter Roeck
2015-08-08  5:02 ` [PATCH v2 3/8] watchdog: Introduce WDOG_RUNNING flag Guenter Roeck
2015-08-14 19:04   ` Uwe Kleine-König
2015-08-15 23:38     ` Guenter Roeck
2015-08-08  5:02 ` [PATCH v2 4/8] watchdog: Make set_timeout function optional Guenter Roeck
2015-08-14 19:05   ` Uwe Kleine-König
2015-08-15 23:41     ` Guenter Roeck [this message]
2015-08-08  5:02 ` [PATCH v2 5/8] watchdog: imx2: Convert to use infrastructure triggered keepalives Guenter Roeck
2015-08-08  5:02 ` [PATCH v2 6/8] watchdog: retu: " Guenter Roeck
2015-08-08  5:02 ` [PATCH v2 7/8] watchdog: gpio_wdt: " Guenter Roeck
2015-08-08  5:02 ` [PATCH v2 8/8] watchdog: at91sam9: " Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55CFCE2B.9010802@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=corbet@lwn.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=timo.kokkonen@offcode.fi \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=wim@iguana.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.