All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Chanwoo Choi <cw00.choi@samsung.com>,
	s.nawrocki@samsung.com, tomasz.figa@gmail.com, kgene@kernel.org
Cc: mturquette@baylibre.com, sboyd@codeaurora.org,
	linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/4] clk: samsung: exynos3250: Add UART2 clock
Date: Mon, 17 Aug 2015 10:01:03 +0900	[thread overview]
Message-ID: <55D1324F.1040908@samsung.com> (raw)
In-Reply-To: <1439264784-30322-2-git-send-email-cw00.choi@samsung.com>

On 11.08.2015 12:46, Chanwoo Choi wrote:
> This patch add the UART2 clocks (mux, divider, gate) of Exynos3250 SoC.

I could not confirm the exact numbers used ("reserved" in my datasheet)
but the patch itself looks correct.

Assuming that numbers/addresses are good:
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>


Best regards,
Krzysztof

> 
> Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>
> Cc: Tomasz Figa <tomasz.figa@gmail.com>
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> ---
>  drivers/clk/samsung/clk-exynos3250.c   | 6 ++++++
>  include/dt-bindings/clock/exynos3250.h | 6 +++++-
>  2 files changed, 11 insertions(+), 1 deletion(-)
> 


WARNING: multiple messages have this Message-ID (diff)
From: k.kozlowski@samsung.com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] clk: samsung: exynos3250: Add UART2 clock
Date: Mon, 17 Aug 2015 10:01:03 +0900	[thread overview]
Message-ID: <55D1324F.1040908@samsung.com> (raw)
In-Reply-To: <1439264784-30322-2-git-send-email-cw00.choi@samsung.com>

On 11.08.2015 12:46, Chanwoo Choi wrote:
> This patch add the UART2 clocks (mux, divider, gate) of Exynos3250 SoC.

I could not confirm the exact numbers used ("reserved" in my datasheet)
but the patch itself looks correct.

Assuming that numbers/addresses are good:
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>


Best regards,
Krzysztof

> 
> Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>
> Cc: Tomasz Figa <tomasz.figa@gmail.com>
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> ---
>  drivers/clk/samsung/clk-exynos3250.c   | 6 ++++++
>  include/dt-bindings/clock/exynos3250.h | 6 +++++-
>  2 files changed, 11 insertions(+), 1 deletion(-)
> 

  reply	other threads:[~2015-08-17  1:01 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-11  3:46 [PATCH 0/4] ARM: dts: exynos3250: Add UART2 and MMC2 dt node with related clocks Chanwoo Choi
2015-08-11  3:46 ` Chanwoo Choi
2015-08-11  3:46 ` [PATCH 1/4] clk: samsung: exynos3250: Add UART2 clock Chanwoo Choi
2015-08-11  3:46   ` Chanwoo Choi
2015-08-11  3:46   ` Chanwoo Choi
2015-08-17  1:01   ` Krzysztof Kozlowski [this message]
2015-08-17  1:01     ` Krzysztof Kozlowski
2015-08-17  3:29   ` [1/4] " Pankaj Dubey
2015-08-17  3:29     ` Pankaj Dubey
2015-08-11  3:46 ` [PATCH 2/4] clk: samsung: exynos3250: Add MMC2 clock Chanwoo Choi
2015-08-11  3:46   ` Chanwoo Choi
2015-08-11  3:46   ` Chanwoo Choi
2015-08-17  1:48   ` Krzysztof Kozlowski
2015-08-17  1:48     ` Krzysztof Kozlowski
2015-08-11  3:46 ` [PATCH 3/4] ARM: dts: Add UART2 dt node for Exynos3250 SoC Chanwoo Choi
2015-08-11  3:46   ` Chanwoo Choi
2015-08-17  2:11   ` Krzysztof Kozlowski
2015-08-17  2:11     ` Krzysztof Kozlowski
2015-08-17  3:33   ` [3/4] " Pankaj Dubey
2015-08-17  3:33     ` Pankaj Dubey
2015-08-11  3:46 ` [PATCH 4/4] ARM: dts: Add MSHC2 " Chanwoo Choi
2015-08-11  3:46   ` Chanwoo Choi
2015-08-17  2:13   ` Krzysztof Kozlowski
2015-08-17  2:13     ` Krzysztof Kozlowski
2015-08-17  0:33 ` [PATCH 0/4] ARM: dts: exynos3250: Add UART2 and MMC2 dt node with related clocks Krzysztof Kozlowski
2015-08-17  0:33   ` Krzysztof Kozlowski
2015-08-17  0:36   ` Chanwoo Choi
2015-08-17  0:36     ` Chanwoo Choi
2015-08-17  0:37     ` Krzysztof Kozlowski
2015-08-17  0:37       ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55D1324F.1040908@samsung.com \
    --to=k.kozlowski@samsung.com \
    --cc=cw00.choi@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kgene@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=s.nawrocki@samsung.com \
    --cc=sboyd@codeaurora.org \
    --cc=tomasz.figa@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.