Re: [PATCH v2] ASoC: ics43432: Add codec driver for InvenSense ICS-43432

[Lars-Peter Clausen <lars@metafoo.de>]

On 08/17/2015 09:09 AM, Ricard Wanderlof wrote:
> 
> On Fri, 14 Aug 2015, Mark Brown wrote:
> 
>> On Fri, Aug 14, 2015 at 11:10:10AM +0200, Ricard Wanderlof wrote:
>>>
>>> V2: Update after comments from Lars-Peter yesterday: set rate to 
>>> CONTINUOUS and let ALSA figure out the details, also removing hw_params as 
>>> it is then not needed.
>>
>> Please add any non-changelog content like this after the --- as covered
>> in SubmittingPatches.
> 
> Ok, sorry.
> 
>>> +static int ics43432_set_dai_fmt(struct snd_soc_dai *dai, unsigned int fmt)
>>> +{
>>> +	switch (fmt & SND_SOC_DAIFMT_INV_MASK) {
>>
>> This still seems redundant (IIRC Lars mentioned this...).
> 
> I though Lars was referring solely to the hw_params function, not 
> set_dai_fmt, but of course I could have misunderstood him.

Yes, I was. In my opinion this set_dai_fmt() implementation is useful to
have as a mechanism to detect invalid configurations. E.g. if you don't
implement the callback the CODEC will accept any setting while with he
callback it will error out with the wrong configuration. Given that a I2S
link typically at least somewhat works, even if you have the wrong setting,
I think it makes sense to keep it to catch errors early on.