From: Andrey Ryabinin <ryabinin.a.a@gmail.com>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [RFC PATCH V1 7/8] powerpc/mm: kasan: Add kasan support for ppc64
Date: Mon, 17 Aug 2015 15:13:27 +0300 [thread overview]
Message-ID: <55D1CFE7.2070801@gmail.com> (raw)
In-Reply-To: <1439793400-18147-8-git-send-email-aneesh.kumar@linux.vnet.ibm.com>
On 08/17/2015 09:36 AM, Aneesh Kumar K.V wrote:
> We use the region with region ID 0xe as the kasan shadow region. Since
> we use hash page table, we can't have the early zero page based shadow
> region support. Hence we disable kasan in the early code and runtime
> enable this. We could imporve the condition using static keys. (but
> that is for a later patch). We also can't support inline instrumentation
> because our kernel mapping doesn't give us a large enough free window
> to map the entire range. For VMALLOC and VMEMMAP region we just
> return a zero page instead of having a translation bolted into the
> htab. This simplifies handling VMALLOC and VMEMAP area. Kasan is not
> tracking both the region as of now
>
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
> ---
> arch/powerpc/include/asm/kasan.h | 74 ++++++++++++++++++++++++++++++++
> arch/powerpc/include/asm/pgtable-ppc64.h | 1 +
> arch/powerpc/include/asm/ppc_asm.h | 10 +++++
> arch/powerpc/include/asm/string.h | 13 ++++++
> arch/powerpc/kernel/Makefile | 1 +
> arch/powerpc/kernel/prom_init_check.sh | 2 +-
> arch/powerpc/kernel/setup_64.c | 3 ++
> arch/powerpc/lib/mem_64.S | 6 ++-
> arch/powerpc/lib/memcpy_64.S | 3 +-
> arch/powerpc/lib/ppc_ksyms.c | 10 +++++
> arch/powerpc/mm/Makefile | 3 ++
> arch/powerpc/mm/kasan_init.c | 44 +++++++++++++++++++
> arch/powerpc/mm/slb_low.S | 4 ++
> arch/powerpc/platforms/Kconfig.cputype | 1 +
> 14 files changed, 171 insertions(+), 4 deletions(-)
> create mode 100644 arch/powerpc/include/asm/kasan.h
> create mode 100644 arch/powerpc/mm/kasan_init.c
>
Did you disable stack instrumentation (in scripts/Makefile.kasa),
or you version of gcc doesn't support it (e.g. like 4.9.x on x86) ?
Because this can't work with stack instrumentation as you don't have shadow for stack in early code.
But this should be doable, as I think. All you need is to setup shadow for init task's
stack before executing any instrumented function.
next prev parent reply other threads:[~2015-08-17 12:13 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-17 6:36 [RFC PATCH V1 0/8] KASAN ppc64 support Aneesh Kumar K.V
2015-08-17 6:36 ` [RFC PATCH V1 1/8] powerpc/mm: Add virt_to_pfn and use this instead of opencoding Aneesh Kumar K.V
2015-08-17 6:36 ` [RFC PATCH V1 2/8] kasan: MODULE_VADDR is not available on all archs Aneesh Kumar K.V
2015-08-17 6:36 ` [RFC PATCH V1 3/8] kasan: Rename kasan_enabled to kasan_report_enabled Aneesh Kumar K.V
2015-08-17 6:36 ` [RFC PATCH V1 4/8] kasan: Don't use kasan shadow pointer in generic functions Aneesh Kumar K.V
2015-08-17 11:36 ` Andrey Ryabinin
2015-08-18 5:29 ` Aneesh Kumar K.V
2015-08-18 9:12 ` Andrey Ryabinin
2015-08-17 6:36 ` [RFC PATCH V1 5/8] kasan: Enable arch to hook into kasan callbacks Aneesh Kumar K.V
2015-08-17 6:36 ` [RFC PATCH V1 6/8] kasan: Allow arch to overrride kasan shadow offsets Aneesh Kumar K.V
2015-08-17 6:36 ` [RFC PATCH V1 7/8] powerpc/mm: kasan: Add kasan support for ppc64 Aneesh Kumar K.V
2015-08-17 12:13 ` Andrey Ryabinin [this message]
2015-08-17 12:17 ` Andrey Ryabinin
2015-08-18 5:36 ` Aneesh Kumar K.V
2015-08-18 8:40 ` Andrey Ryabinin
2015-08-18 5:34 ` Aneesh Kumar K.V
2015-08-17 6:36 ` [RFC PATCH V1 8/8] powerpc: Disable kasan for kernel/ and mm/ directory Aneesh Kumar K.V
2015-08-17 6:54 ` [RFC PATCH V1 0/8] KASAN ppc64 support Benjamin Herrenschmidt
2015-08-17 9:50 ` Aneesh Kumar K.V
2015-08-17 10:01 ` Benjamin Herrenschmidt
2015-08-17 10:50 ` Aneesh Kumar K.V
2015-08-17 11:21 ` Benjamin Herrenschmidt
2015-08-17 11:29 ` Andrey Ryabinin
2015-08-18 5:42 ` Aneesh Kumar K.V
2015-08-18 8:50 ` Andrey Ryabinin
2015-08-18 9:21 ` Aneesh Kumar K.V
2015-08-18 9:30 ` Andrey Ryabinin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55D1CFE7.2070801@gmail.com \
--to=ryabinin.a.a@gmail.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.