From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olivier MATZ Subject: Re: [PATCH] mbuf & mempool: explicit typecast on function return Date: Mon, 17 Aug 2015 14:50:57 +0200 Message-ID: <55D1D8B1.1090604@6wind.com> References: <1439370664-25728-1-git-send-email-balabanovsv@ecotelecom.ru> <55D197E8.5040501@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable To: Joongi Kim , Sergey Balabanov , dev@dpdk.org Return-path: Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id A40888DA0 for ; Mon, 17 Aug 2015 14:51:08 +0200 (CEST) In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Joongi, On 08/17/2015 02:28 PM, Joongi Kim wrote: > I already have fixed this issue > at http://dpdk.org/dev/patchwork/patch/6068/ . > There is another issue related to "underlying type" for enum > declarations http://dpdk.org/dev/patchwork/patch/6067/, for C++11 compi= lers. >=20 > In the second patch I missed updating headers for architectures other > than x86, > so it needs to be updated before applying to the master branch. >=20 > It would be great for me to have this fixed on the master branch, > as I am manually applying above patches whenever I pull the latest code= s. >=20 +CC Thomas. Sorry, I missed your previous patches. I think it would indeed be helpful to have them included before the release to allow compilation of C++ programs. I'm wondering if we should add a C++ example in dpdk/examples: people would see the problem before commiting, or if they miss it, I know some people are doing automatic compilation tests every day. Regards, Olivier > Regards, > Joongi >=20 > 2015=EB=85=84 8=EC=9B=94 17=EC=9D=BC (=EC=9B=94) =EC=98=A4=ED=9B=84 5:1= 5, Olivier MATZ >=EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1: >=20 > Hi Sergey, >=20 > On 08/12/2015 11:11 AM, Sergey Balabanov wrote: > > When DPDK is being compiled in C++ project using g++ then > > 'invalid conversion from' error appears. Added explicit > > typecast on function return to get rid of the error. > > > > Signed-off-by: Sergey Balabanov > >=20 >=20 > Fixes: 7755baae8378 ("mbuf: silence warning on pointer arithmetic") > Fixes: 6cf14ce4ce6c ("mempool: silence warning on pointer arithmeti= c") >=20 > Acked-by: Olivier Matz > >=20 > Thanks >=20