Re: [Xenomai] analogy calibration issue(s)

[Jorge Ramirez Ortiz <jro@xenomai.org>]

On 08/17/2015 09:39 AM, Jorge Ramirez Ortiz wrote:
> On 08/17/2015 09:22 AM, Jorge Ramirez Ortiz wrote:
>> On 08/17/2015 12:11 AM, Yogi A. Patel wrote:
>>>
>>>>> please pull again from http://git.xenomai.org/xenomai-jro.git/log/?h=devel
>>> It took some time, but I was able to get the process to *run* - but not work.
>>>
>>> I had to make the following modifications to the calibration.c file to get this
>>> to work on 3 different machines:
>>
>> none of these modifications are really valid.
>> you are probably forcing analogy to swallow an invalid calibration file.
>>
>>>
> 
>>
>>> @@ -226,7 +229,7 @@ int a4l_read_calibration_file(char *name, struct
>>> a4l_calibration_data *data)
>>>                 if (nb_elements < 0 ) {
>>>                         /* AO is optional */
>>>                         if (!strncmp(subdevice[k], AO_SUBD_STR,
>>> sizeof(AO_SUBD_STR)))
>>> -                            break;
>>> +                               return 0;
>>
> 
> actually I am obviously wrong here. this is needed.
> it went unnoticed on my tests (it is unusual not to have an A0 subdevice)
> will pick it.
> 

ok, so finally I had a look at the code in mainline and yes, this is not needed
either (I was looking at some changes I am working on so this code might change)
in any case this can not have caused you any problems (after it breaks the loop,
it returns 0 which is just what your patch does).



-- 
jro