From: Guenter Roeck <linux@roeck-us.net>
To: Bjorn Andersson <bjorn.andersson@sonymobile.com>,
Wim Van Sebroeck <wim@iguana.be>
Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] watchdog: at91rm9200: Correct check for syscon_node_to_regmap() errors
Date: Mon, 17 Aug 2015 09:33:26 -0700 [thread overview]
Message-ID: <55D20CD6.90709@roeck-us.net> (raw)
In-Reply-To: <1439828343-6679-1-git-send-email-bjorn.andersson@sonymobile.com>
On 08/17/2015 09:19 AM, Bjorn Andersson wrote:
> syscon_node_to_regmap() returns a regmap or an ERR_PTR().
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
Acked-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/at91rm9200_wdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/at91rm9200_wdt.c b/drivers/watchdog/at91rm9200_wdt.c
> index 9ba1153465ae..e12a797cb820 100644
> --- a/drivers/watchdog/at91rm9200_wdt.c
> +++ b/drivers/watchdog/at91rm9200_wdt.c
> @@ -244,7 +244,7 @@ static int at91wdt_probe(struct platform_device *pdev)
> }
>
> regmap_st = syscon_node_to_regmap(parent->of_node);
> - if (!regmap_st)
> + if (IS_ERR(regmap_st))
> return -ENODEV;
>
> res = misc_register(&at91wdt_miscdev);
>
prev parent reply other threads:[~2015-08-17 16:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-17 16:19 [PATCH] watchdog: at91rm9200: Correct check for syscon_node_to_regmap() errors Bjorn Andersson
2015-08-17 16:33 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55D20CD6.90709@roeck-us.net \
--to=linux@roeck-us.net \
--cc=bjorn.andersson@sonymobile.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.