From: Dave Gordon <david.s.gordon@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH igt] lib/igt_core: use print("%s", #expr) instead of print(#expr)
Date: Mon, 17 Aug 2015 17:42:25 +0100 [thread overview]
Message-ID: <55D20EF1.9020905@intel.com> (raw)
In-Reply-To: <1439486267-18516-1-git-send-email-paulo.r.zanoni@intel.com>
On 13/08/15 18:17, Paulo Zanoni wrote:
> If I have a program with the following:
>
> igt_skip_on(i % 2 == 0);
> igt_skip_on_f(i % 2 == 0, "i:%d\n", i);
> igt_require(i % 2 == 0);
> igt_require_f(i % 2 == 0, "i:%d\n", i);
>
> then I'll get compiler error messages complaining about format
> conversions related to the '%' character used in the mod operation. So
> put the whole string as a %s argument to avoid interpreting '%' and
> any other possible chars.
>
> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Reviewed-by: Dave Gordon <david.s.gordon@intel.com>
... and I found a similar issue in the i915 driver's macros; see the
patch I just posted:
[PATCH] drm/i915: fix driver's versions of WARN_ON & WARN_ON_ONCE
.Dave.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2015-08-17 16:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-13 17:17 [PATCH igt] lib/igt_core: use print("%s", #expr) instead of print(#expr) Paulo Zanoni
2015-08-17 16:42 ` Dave Gordon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55D20EF1.9020905@intel.com \
--to=david.s.gordon@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.