From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH 0/2] xen: arm: Ensure all PTE bits have a known value Date: Mon, 17 Aug 2015 11:23:57 -0700 Message-ID: <55D226BD.3050702@citrix.com> References: <4EE5B48738DDED408878C97C8E050A8B1D7EC7CC@SJEXCHMB05.corp.ad.broadcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4EE5B48738DDED408878C97C8E050A8B1D7EC7CC@SJEXCHMB05.corp.ad.broadcom.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: "Chris (Christopher) Brand" , "xen-devel@lists.xen.org" Cc: "stefano.stabellini@citrix.com" , "Ian Campbell (ian.campbell@citrix.com)" List-Id: xen-devel@lists.xenproject.org On 14/08/2015 14:41, Chris (Christopher) Brand wrote: > Hi, Hi Chris, Thank you for the patch. > This is more-or-less what Julien requested. He noted that pt.contig was never > set to zero. When I looked further, I found other bits that were also never > given a value. Looking at the callsites, they almost all seem to assume a value > of zero, so that's what I went with. > > Patch 1 re-orders the assignments to match the declaration, making it clearer > which ones are missing. Patch 2 then adds the missing bits. > > Chris > P.S. Apologies for any threading issues - I have not yet managed to get git > send-email working properly. I'm usually using git format-patch to get a list of files (one per patch) and my cover letter (--cover-letter). Then I use git send-email *.patch which will send the patch correctly threading. Regards, -- Julien Grall