From: Guenter Roeck <linux@roeck-us.net>
To: Jeremy Linton <jeremy.linton@arm.com>,
Steve Glendinning <steve.glendinning@shawell.net>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] smsc911x: Fix crash seen if neither ACPI nor OF is configured or used
Date: Mon, 17 Aug 2015 15:14:56 -0700 [thread overview]
Message-ID: <55D25CE0.6040203@roeck-us.net> (raw)
In-Reply-To: <55D24FEE.8040505@arm.com>
On 08/17/2015 02:19 PM, Jeremy Linton wrote:
> On 08/17/2015 03:45 PM, Guenter Roeck wrote:
>> Commit 0b50dc4fc971 ("Convert smsc911x to use ACPI as well as DT") makes
>> the call to smsc911x_probe_config() unconditional, and no longer fails if
>> there is no device node. device_get_phy_mode() is called unconditionally,
>> and if there is no phy node configured returns an error code. This error
>> code is assigned to phy_interface, and interpreted elsewhere in the code
>> as valid phy mode. This in turn causes qemu to crash when running a
>> variant of realview_pb_defconfig.
>
> Thanks for catching that! I have a couple other minor cleanups per the reviewers.
>
One nitpick I noticed after sending my patch: dev can never be NULL in
smsc911x_probe_config(), so it does not really make sense to check if it is NULL.
Guenter
next prev parent reply other threads:[~2015-08-17 22:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-17 20:45 [PATCH -next] smsc911x: Fix crash seen if neither ACPI nor OF is configured or used Guenter Roeck
2015-08-17 21:06 ` David Miller
2015-08-17 21:19 ` Jeremy Linton
2015-08-17 22:14 ` Guenter Roeck [this message]
2015-08-17 22:35 ` Jeremy Linton
2015-08-26 17:04 ` Tony Lindgren
2015-08-26 17:31 ` Jeremy Linton
2015-08-26 17:48 ` Tony Lindgren
2015-08-26 17:36 ` Guenter Roeck
2015-08-26 17:57 ` Tony Lindgren
2015-08-26 18:34 ` Guenter Roeck
2015-08-26 20:16 ` Tony Lindgren
2015-08-26 20:55 ` Guenter Roeck
2015-08-26 21:40 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55D25CE0.6040203@roeck-us.net \
--to=linux@roeck-us.net \
--cc=jeremy.linton@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=steve.glendinning@shawell.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.