From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38765) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZRa4c-0000fe-TC for qemu-devel@nongnu.org; Tue, 18 Aug 2015 02:08:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZRa4Z-0004LC-Nx for qemu-devel@nongnu.org; Tue, 18 Aug 2015 02:08:38 -0400 Received: from mx2.suse.de ([195.135.220.15]:45269) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZRa4Z-0004Kv-I7 for qemu-devel@nongnu.org; Tue, 18 Aug 2015 02:08:35 -0400 Message-ID: <55D2CBE2.4040401@suse.de> Date: Tue, 18 Aug 2015 08:08:34 +0200 From: Hannes Reinecke MIME-Version: 1.0 References: <1439854945-5597-1-git-send-email-abezzubikov@ispras.ru> <1439854945-5597-3-git-send-email-abezzubikov@ispras.ru> In-Reply-To: <1439854945-5597-3-git-send-email-abezzubikov@ispras.ru> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH RFC 02/11] ide: necessary fields for ATAPI-SCSI bridge added List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Bezzubikov , qemu-devel@nongnu.org Cc: jsnow@redhat.com, abezzubikov@ispras.ru On 08/18/2015 01:42 AM, Alexander Bezzubikov wrote: > Signed-off-by: Alexander Bezzubikov > --- > hw/ide/internal.h | 3 +++ > 1 file changed, 3 insertions(+) >=20 > diff --git a/hw/ide/internal.h b/hw/ide/internal.h > index f2999ce..3ebc63c 100644 > --- a/hw/ide/internal.h > +++ b/hw/ide/internal.h > @@ -429,6 +429,8 @@ struct IDEState { > uint8_t *smart_selftest_data; > /* AHCI */ > int ncq_queues; > + /* ATAPI-SCSI bridge */ > + SCSIRequest *cur_req; > }; > =20 > struct IDEDMAOps { > @@ -493,6 +495,7 @@ struct IDEDevice { > char *serial; > char *model; > uint64_t wwn; > + SCSIBus *scsi_bus; > }; > =20 > /* These are used for the error_status field of IDEBus */ >=20 Hmm. I would rather merge this with the patch where the fields are used; as it stands it looks a bit pointless. Cheers, Hannes --=20 Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg GF: J. Hawn, J. Guild, F. Imend=F6rffer, HRB 16746 (AG N=FCrnberg)