From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40695) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZRaE6-0007EU-SN for qemu-devel@nongnu.org; Tue, 18 Aug 2015 02:18:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZRaE1-0001zC-NL for qemu-devel@nongnu.org; Tue, 18 Aug 2015 02:18:26 -0400 Received: from mx2.suse.de ([195.135.220.15]:45588) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZRaE1-0001z7-Hd for qemu-devel@nongnu.org; Tue, 18 Aug 2015 02:18:21 -0400 Message-ID: <55D2CE2C.3060406@suse.de> Date: Tue, 18 Aug 2015 08:18:20 +0200 From: Hannes Reinecke MIME-Version: 1.0 References: <1439854945-5597-1-git-send-email-abezzubikov@ispras.ru> <1439854945-5597-10-git-send-email-abezzubikov@ispras.ru> In-Reply-To: <1439854945-5597-10-git-send-email-abezzubikov@ispras.ru> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH RFC 09/11] ide: ide_bridge_do_transfer is treated as PIO transfer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Bezzubikov , qemu-devel@nongnu.org Cc: jsnow@redhat.com, abezzubikov@ispras.ru On 08/18/2015 01:42 AM, Alexander Bezzubikov wrote: > Signed-off-by: Alexander Bezzubikov > --- > hw/ide/bridge.c | 2 +- > hw/ide/bridge.h | 1 + > hw/ide/core.c | 4 +++- > 3 files changed, 5 insertions(+), 2 deletions(-) >=20 > diff --git a/hw/ide/bridge.c b/hw/ide/bridge.c > index 3a534de..4a5251b 100644 > --- a/hw/ide/bridge.c > +++ b/hw/ide/bridge.c > @@ -1,6 +1,6 @@ > #include "hw/ide/bridge.h" > =20 > -static void ide_bridge_do_transfer(IDEState *s) > +void ide_bridge_do_transfer(IDEState *s) > { > SCSIDiskReq *r =3D DO_UPCAST(SCSIDiskReq, req, s->cur_req); > =20 > diff --git a/hw/ide/bridge.h b/hw/ide/bridge.h > index dca5d73..59f2f25 100644 > --- a/hw/ide/bridge.h > +++ b/hw/ide/bridge.h > @@ -5,5 +5,6 @@ > =20 > void ide_bridge_start_transfer(SCSIRequest *req, uint32_t len); > void ide_bridge_complete(SCSIRequest *req, uint32_t status, size_t res= id); > +void ide_bridge_do_transfer(IDEState *s); > =20 > #endif > diff --git a/hw/ide/core.c b/hw/ide/core.c > index d017d4e..99b955b 100644 > --- a/hw/ide/core.c > +++ b/hw/ide/core.c > @@ -34,6 +34,7 @@ > #include "sysemu/block-backend.h" > =20 > #include > +#include "hw/ide/bridge.h" > =20 > /* These values were based on a Seagate ST3500418AS but have been modi= fied > to make more sense in QEMU */ > @@ -2002,7 +2003,8 @@ static bool ide_is_pio_out(IDEState *s) > } else if (s->end_transfer_func =3D=3D ide_sector_read || > s->end_transfer_func =3D=3D ide_transfer_stop || > s->end_transfer_func =3D=3D ide_atapi_cmd_reply_end || > - s->end_transfer_func =3D=3D ide_dummy_transfer_stop) { > + s->end_transfer_func =3D=3D ide_dummy_transfer_stop || > + s->end_transfer_func =3D=3D ide_bridge_do_transfer) { > return true; > } > =20 >=20 Patch is okay, but could benefit from a more detailed description. Cheers, Hannes --=20 Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg GF: J. Hawn, J. Guild, F. Imend=F6rffer, HRB 16746 (AG N=FCrnberg)