From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41776) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZRaHN-00019U-0V for qemu-devel@nongnu.org; Tue, 18 Aug 2015 02:21:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZRaHI-0003TR-1Z for qemu-devel@nongnu.org; Tue, 18 Aug 2015 02:21:48 -0400 Received: from mx2.suse.de ([195.135.220.15]:45682) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZRaHH-0003TL-RN for qemu-devel@nongnu.org; Tue, 18 Aug 2015 02:21:43 -0400 Message-ID: <55D2CEF6.6090105@suse.de> Date: Tue, 18 Aug 2015 08:21:42 +0200 From: Hannes Reinecke MIME-Version: 1.0 References: <1439854945-5597-1-git-send-email-abezzubikov@ispras.ru> In-Reply-To: <1439854945-5597-1-git-send-email-abezzubikov@ispras.ru> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH RFC 00/11] QEMU ATAPI-SCSI bridge GSoC project List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Bezzubikov , qemu-devel@nongnu.org Cc: jsnow@redhat.com, abezzubikov@ispras.ru On 08/18/2015 01:42 AM, Alexander Bezzubikov wrote: > This is my QEMU Google Summer of Code project. > Here I introduce new device - ATAPI-SCSI bridge. > Its purpose is to unify IDE ATAPI CD-ROM emulation > with SCSI CD-ROM emulation to reduce code duplication and squash bugs. > It's purpose is simple - it just forwards ATAPI commands > to SCSI side for parsing and execution. >=20 > Example of using: > qemu-system-x86_64 \ > -drive if=3Dnone,file=3D,id=3Dcdrom \ > -drive if=3Dnone,id=3Dfake \ > -device ide-bridge,id=3Dbridge,drive=3Dfake \ > -device scsi-cd,drive=3Dcdrom,bus=3Dbridge.0 \ > -hda diskimage \ > -m 1024=20 >=20 > Alexander Bezzubikov (11): > ide: ATAPI-SCSI bridge TypeInfo and init function created > ide: necessary fields for ATAPI-SCSI bridge added > ide: necessary checks corrected to treat ATAPI-SCSI bridge as CDROM > scsi: Added function to enable ATAPI-SCSI bridge send SCSI requests > ide: bridge 'transfer' and 'complete' functions added > ide: ATAPI-SCSI bridge can now forward requests to SCSI > ide: Makefile corrected due to bridge creation > scsi: SCSIDiskReq declaration moved to header > ide: ide_bridge_do_transfer is treated as PIO transfer > ide: corrected ATAPI checks to be ignored by ATAPI-SCSI bridge > ide: bridge functions assigned to SCSIBusInfo, bridge is OK now >=20 > hw/ide/Makefile.objs | 2 +- > hw/ide/atapi.c | 22 +++++++++- > hw/ide/bridge.c | 114 +++++++++++++++++++++++++++++++++++++++++= ++++++++ > hw/ide/bridge.h | 10 +++++ > hw/ide/core.c | 28 +++++++----- > hw/ide/internal.h | 6 ++- > hw/ide/qdev.c | 42 +++++++++++++++++- > hw/scsi/scsi-disk.c | 55 ++++++++++++++++++------ > include/hw/scsi/scsi.h | 16 +++++++ > 9 files changed, 267 insertions(+), 28 deletions(-) > create mode 100644 hw/ide/bridge.c > create mode 100644 hw/ide/bridge.h >=20 In general a very nice patchset, looking quite closely to what I had in mind. Congrats. But I would prefer to reshuffle the patches somewhat; this will make review easier. Cheers, Hannes --=20 Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg GF: J. Hawn, J. Guild, F. Imend=F6rffer, HRB 16746 (AG N=FCrnberg)