From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 6B2AEE009F3; Tue, 18 Aug 2015 09:40:02 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low * trust * [209.85.212.176 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Received: from mail-wi0-f176.google.com (mail-wi0-f176.google.com [209.85.212.176]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id E62B9E008EC for ; Tue, 18 Aug 2015 09:39:58 -0700 (PDT) Received: by wicne3 with SMTP id ne3so99996427wic.0 for ; Tue, 18 Aug 2015 09:39:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=Ias2FpcTTQYG3QAWS8k2/7GtarT5wjgIzVeL/mqUPmM=; b=B+UbPkU4FCL4rEfT3TeqjX5XFhBLGnuQ0AOEGSHI8N84tyrpq7Jozqi+fisWnxyi6H a6THUkT78PP73QOeM2dVw99Gs8UIfb/7hlkVdC0k16zPSsn1kv/8rRDs3B6YBXfdwgAX 7NOKs/97N6V1Y+GhmpxffT19pdTLcEfIZ3llCmTKLArU+6AfVQdKyFU+IwpjAK0KHPhl DLXKJJefWjXYWqCitpOOP1Mq3nAJgMe36z9ezlnhtYCoda1/siKtDrZaN871ECC7zUyM oahBXWTFg5C7yWRCQZdieHk3ooDctLNwk+XnSltV8B+DEFUiVJmijA+rSVqGn2Hbs4BS 8tFA== X-Gm-Message-State: ALoCoQkHXaY6JPSCp7oBzb6oi/q3wnpn+3Zp9Y49UG2zHgaZZY4LeO/3Ym0OJM4odsd9+ReHj3XC X-Received: by 10.194.113.101 with SMTP id ix5mr15345597wjb.66.1439915997455; Tue, 18 Aug 2015 09:39:57 -0700 (PDT) Received: from [192.168.0.30] ([90.200.212.221]) by smtp.googlemail.com with ESMTPSA id yu4sm27197596wjc.43.2015.08.18.09.39.55 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 18 Aug 2015 09:39:56 -0700 (PDT) Message-ID: <55D35FDB.1010406@intel.com> Date: Tue, 18 Aug 2015 17:39:55 +0100 From: Michael Wood User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: "Damian, Alexandru" References: <55B8BAE6.8070703@intel.com> <55CE10DB.3050203@intel.com> In-Reply-To: Cc: "toaster@yoctoproject.org" Subject: Re: [review-request] adamian/bug_fixes X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Aug 2015 16:40:02 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Submitted upstream With the exception of ad0470144bcfb19065fa90512bd533754bd26a28 toaster: refactor checksettings.pyThat patch caused the toasterconf.json not to be found and had conflicts when rebased on master so was omitted. Thanks, Michael On 17/08/15 12:19, Damian, Alexandru wrote: > Hi, > > Yep, I made a merge mistake. I fixed the issue and rebased everything > on top of poky. > > adamian/20150817_bug_fixes_poky > > Can you please review and merge ? > > Cheers, > Alex > > On Fri, Aug 14, 2015 at 5:01 PM, Michael Wood > > wrote: > > The branch fails the unit tests because you've removed a used > import in d73cc179f3e12a3d3b33a6b0c3884bcea9be84a3 > > Could future branches be based on poky please as it's easier for > me to do testing. > > Thanks, > > Michael > > On 13/08/15 17:36, Damian, Alexandru wrote: > > I pushed new version with the requested changes, rebased on > the latest master. > > The branch is the same: > > adamian/bug_fixes > > Cheers, > Alex > > > On Wed, Jul 29, 2015 at 12:37 PM, Michael Wood > > >> wrote: > > On 27/07/15 13:08, Barros Pena, Belen wrote: > > > On 27/07/2015 12:45, "Damian, Alexandru" > > >> > wrote: > > Re-pushed the same branch with IN PROGRESS fixed > applied > to both build > pages. > > Now it seems to be working in both places. > > Thanks! > > Belén > > > Cheers, > Alex > > > On Mon, Jul 27, 2015 at 12:08 PM, Barros Pena, Belen > > >> wrote: > > Thanks for the poky-based branch Alex! A couple of > comments below. > > On 24/07/2015 18:10, > "toaster-bounces@yoctoproject.org > > > on behalf of > Damian, Alexandru" > > > on behalf of > alexandru.damian@intel.com > > >> wrote: > > > ​Hi, > > > This is a review request for adamian/bug_fixes > > u > g_fixes>​ > > > ​It contains a previously submitted patchset, > and a > fix for #7995 > > > bc4ea83f93657d876b43b751549735b683c33040 > > The builds in progress no longer show in the all > builds > page, but they > still show in the project builds page. > > On the bright side, I know that because I can now > reach > the project builds > page :) so the patch for 7995 works for me. > > Thanks! > > Belén > > > Please review and submit when possible. > > > Cheers, > Alex​ > > > > > -- > Alex Damian > Yocto Project > > SSG / OTC > > > > > > > > > > > > > -- Alex Damian > Yocto Project > > SSG / OTC > > > > > > Can you squash these two: > ba72e1666796987bdec1bbf34d31a41ecf605936 > and 9cce8032cbb70f0047f5819127c0c220963f2ce2 > > > > a125f3ab34a82eb684c46d5f01ee3544535ab5f4 > > > > diff --git > a/lib/toaster/bldcontrol/management/commands/checksettings.py > b/lib/toaster/bldcontrol/management/commands/checksettings.py > index 3858b9e..b2631c4 100644 > --- > a/lib/toaster/bldcontrol/management/commands/checksettings.py > +++ > b/lib/toaster/bldcontrol/management/commands/checksettings.py > @@ -99,10 +99,11 @@ class Command(NoArgsCommand): > # find configuration files > config_files = [] > + selected_dirs = [] > for dirname in > self._recursive_list_directories(be.sourcedir,2): > if os.path.exists(os.path.join(dirname, > ".templateconf")): > import subprocess > - proc = subprocess.Popen('bash -c ". > '+os.path.join(dirname, ".templateconf")+r'; echo > \"$TEMPLATECONF\""', shell=True, stdout=subprocess.PIPE) > + proc = subprocess.Popen('bash -c ". > '+os.path.join(dirname, ".templateconf")+r'; echo > \"\$TEMPLATECONF\""', shell=True, stdout=subprocess.PIPE) > conffilepath, stderroroutput = > proc.communicate() > proc.wait() > if proc.returncode != 0: > @@ -114,6 +115,15 @@ class Command(NoArgsCommand): > continue > if os.path.exists(candidatefilepath): > config_files.append(candidatefilepath) > + selected_dirs.append(dirname) > + > + for dirname in > self._recursive_list_directories(be.sourcedir,2): > > > This for loop seems to be duplicated from the one above it > checksettings.py (line 103 and 120) can they not be combined? > However do we actually need to do all this searching? To > simplify > this couldn't we find "meta-yocto/conf/toasterconf.json" > in the > poky dir, if that doesn't exist then try the openembedded > one, if > that doesn't exist, ask? if people want to specify their own > config we could have a -config option to bin/toaster. > > Thanks, > > Michael > > > > > > > > -- _______________________________________________ > toaster mailing list > toaster@yoctoproject.org > > > https://lists.yoctoproject.org/listinfo/toaster > > > > > -- > Alex Damian > Yocto Project > SSG / OTC > > --------------------------------------------------------------------- > Intel Corporation (UK) Limited > Registered No. 1134945 (England) > Registered Office: Pipers Way, Swindon SN3 1RJ > VAT No: 860 2173 47 > > This e-mail and any attachments may contain confidential > material for > the sole use of the intended recipient(s). Any review or > distribution > by others is strictly prohibited. If you are not the intended > recipient, please contact the sender and delete all copies. > > > --------------------------------------------------------------------- > Intel Corporation (UK) Limited > Registered No. 1134945 (England) > Registered Office: Pipers Way, Swindon SN3 1RJ > VAT No: 860 2173 47 > > This e-mail and any attachments may contain confidential material for > the sole use of the intended recipient(s). Any review or distribution > by others is strictly prohibited. If you are not the intended > recipient, please contact the sender and delete all copies. > > > > > -- > Alex Damian > Yocto Project > SSG / OTC > > --------------------------------------------------------------------- > Intel Corporation (UK) Limited > Registered No. 1134945 (England) > Registered Office: Pipers Way, Swindon SN3 1RJ > VAT No: 860 2173 47 > > This e-mail and any attachments may contain confidential material for > the sole use of the intended recipient(s). Any review or distribution > by others is strictly prohibited. If you are not the intended > recipient, please contact the sender and delete all copies. >