From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 2EEC2E00A4D; Fri, 24 Jul 2015 10:11:11 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,HTML_MESSAGE, RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low * trust * [209.85.213.171 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * 0.0 HTML_MESSAGE BODY: HTML included in message Received: from mail-ig0-f171.google.com (mail-ig0-f171.google.com [209.85.213.171]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id C0BFCE00942 for ; Fri, 24 Jul 2015 10:11:04 -0700 (PDT) Received: by igbpg9 with SMTP id pg9so21780195igb.0 for ; Fri, 24 Jul 2015 10:11:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to :content-type; bh=y0nd9K8y5ckoCb1Ut/Kv3/GX/avMB/SASG9iXv18y8Q=; b=LOTBWCh0sZHCHMjuG7GQIuI8EzHj8nAA+sjmia31zgd4U8HrYIFMO+nTdIdMw4Ny8v 7bZfOsfVarb2aorLwq26rsLCS9zPKAVC3g7TYpTJEg25vj9O4G470K9/CqcR/rGIM1d6 /dmiQkTLVTVSxVbvhISJYNgElbSto7xLhqRScdqW8ekrvUgkG2rSu6SOh3Dih53dZVdm Dlr6V3tAwOo8uNHJ4IkqJ77TAh8INFpLyVWmTv5q3JiTCisEY1BLY/pIr4HKQLJekEuM dl4Pf8NlurAPpXEmFIqDNRVx9M2zTu3CCCyzaAX5rZMe36H3frEft8bWQKmeCX6l6gl/ FWAg== X-Gm-Message-State: ALoCoQmEV5xnHZoTC36jgy5QmO6DDnpiJGtXC4pB+BaxaoovMk3NeC/eNmmvuqhus6NsQyEOp88z X-Received: by 10.107.37.134 with SMTP id l128mr26306908iol.92.1437757864098; Fri, 24 Jul 2015 10:11:04 -0700 (PDT) MIME-Version: 1.0 Received: by 10.79.65.207 with HTTP; Fri, 24 Jul 2015 10:10:44 -0700 (PDT) From: "Damian, Alexandru" Date: Fri, 24 Jul 2015 18:10:44 +0100 Message-ID: To: "toaster@yoctoproject.org" Subject: [review-request] adamian/bug_fixes X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jul 2015 17:11:11 -0000 Content-Type: multipart/alternative; boundary=001a1140ea86c357bf051ba2164e --001a1140ea86c357bf051ba2164e Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable =E2=80=8BHi, This is a review request for adamian/bug_fixes =E2=80=8B =E2=80=8BIt contains a previously submitted patchset, and a fix for #7995 Please review and submit when possible. Cheers, Alex=E2=80=8B --=20 Alex Damian Yocto Project SSG / OTC --001a1140ea86c357bf051ba2164e Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

=E2=80=8BHi,

This is a review request= for=C2=A0adamian/bug_fixes=E2=80=8B

=E2=80=8BIt cont= ains a previously submitted patchset, and a fix for #7995

Please revie= w and submit when possible.

Cheers,
Alex=E2=80=8B

--
Alex DamianYocto Project
SSG / OTC=C2=A0
--001a1140ea86c357bf051ba2164e-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id F1049E00A26; Mon, 27 Jul 2015 03:44:40 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/, high * trust * [134.134.136.65 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 9EF88E0049B for ; Mon, 27 Jul 2015 03:44:37 -0700 (PDT) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP; 27 Jul 2015 03:44:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,553,1432623600"; d="scan'208";a="530802280" Received: from irsmsx108.ger.corp.intel.com ([163.33.3.3]) by FMSMGA003.fm.intel.com with ESMTP; 27 Jul 2015 03:44:36 -0700 Received: from irsmsx110.ger.corp.intel.com ([169.254.15.29]) by IRSMSX108.ger.corp.intel.com ([169.254.11.22]) with mapi id 14.03.0224.002; Mon, 27 Jul 2015 11:44:35 +0100 From: "Barros Pena, Belen" To: "Damian, Alexandru" , "toaster@yoctoproject.org" Thread-Topic: [Toaster] [review-request] adamian/bug_fixes Thread-Index: AQHQxjPHlnszvAbap0i0Jj/TLi1sb53vJgqA Date: Mon, 27 Jul 2015 10:44:34 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/14.5.3.150624 x-originating-ip: [10.237.224.80] MIME-Version: 1.0 Subject: Re: [review-request] adamian/bug_fixes X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Jul 2015 10:44:41 -0000 Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 DQoNCk9uIDI0LzA3LzIwMTUgMTg6MTAsICJ0b2FzdGVyLWJvdW5jZXNAeW9jdG9wcm9qZWN0Lm9y ZyBvbiBiZWhhbGYgb2YNCkRhbWlhbiwgQWxleGFuZHJ1IiA8dG9hc3Rlci1ib3VuY2VzQHlvY3Rv cHJvamVjdC5vcmcgb24gYmVoYWxmIG9mDQphbGV4YW5kcnUuZGFtaWFuQGludGVsLmNvbT4gd3Jv dGU6DQoNCj4NCj4NCj7igItIaSwNCj4NCj4NCj5UaGlzIGlzIGEgcmV2aWV3IHJlcXVlc3QgZm9y IGFkYW1pYW4vYnVnX2ZpeGVzDQo+PGh0dHBzOi8vZ2l0LnlvY3RvcHJvamVjdC5vcmcvY2dpdC9j Z2l0LmNnaS9wb2t5LWNvbnRyaWIvbG9nLz9oPWFkYW1pYW4vYnUNCj5nX2ZpeGVzPuKAiw0KDQpI aSBBbGV4LA0KDQpJIHdvdWxkIGxpa2UgdG8gaGF2ZSBhIGxvb2sgYXQgdGhlIGZpeCBmb3IgNzk5 NSBhbmQgdGhlIGlzc3VlIHdpdGgNCmRpc3BsYXlpbmcgYnVpbGRzIGluIHByb2dyZXNzIGluIHRo ZSBhbGwgYnVpbGRzIHRhYmxlLCBidXQgdGhlIGJyYW5jaCB5b3UNCnBvc3RlZCBpbiBiYXNlZCBv biBCaXRCYWtlLCBub3QgcG9reSwgd2hpY2ggbWFrZXMgaXQgaGFyZCBmb3IgbWUgdG8gdGVzdC4N CkFueSBjaGFuY2UgeW91IGNvdWxkIHBvc3QgYSBicmFuY2ggYmFzZWQgb24gcG9reT8NCg0KVGhh bmtzIQ0KDQpCZWzDqW4NCg0KPg0KPg0KPuKAi0l0IGNvbnRhaW5zIGEgcHJldmlvdXNseSBzdWJt aXR0ZWQgcGF0Y2hzZXQsIGFuZCBhIGZpeCBmb3IgIzc5OTUNCj4NCj4NCj5QbGVhc2UgcmV2aWV3 IGFuZCBzdWJtaXQgd2hlbiBwb3NzaWJsZS4NCj4NCj4NCj5DaGVlcnMsDQo+QWxleOKAiw0KPg0K Pg0KPg0KPg0KPi0tIA0KPkFsZXggRGFtaWFuDQo+WW9jdG8gUHJvamVjdA0KPg0KPlNTRyAvIE9U QyANCj4NCj4NCj4NCg0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id DC3F9E00A26; Mon, 27 Jul 2015 03:49:42 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,HTML_MESSAGE, RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * 0.0 HTML_MESSAGE BODY: HTML included in message * -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low * trust * [209.85.213.170 listed in list.dnswl.org] Received: from mail-ig0-f170.google.com (mail-ig0-f170.google.com [209.85.213.170]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id AD6D4E0049B for ; Mon, 27 Jul 2015 03:49:38 -0700 (PDT) Received: by igbpg9 with SMTP id pg9so71209076igb.0 for ; Mon, 27 Jul 2015 03:49:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=aMc9w72qzaeDm7ObDSt+Sr4FxN24SPjxzk68Vl4/OME=; b=Kl6CuluBTPOV3ht5rjoi1v1KgULILhKOpwmFZUcCV+wCqmTm8EhITKAWTmORvnHPmM faDbIreyQ9LanPrqJPaxD6+Q4McTSsvpybj7feTAJw8s1UNIXTDSoTHYHjiF+npyiMOH /iZcYdgToH4PcRMmsUbBGCHSaIY6blVwc2Dne+ejrmAfRvD6NndDKINFL/nA+OQZyDBk 6c+8K1bgMKyM3HVm2ptvc1H/WrzkHjDKFUacPEnYjtHzsGvcFeJ4Z3xd2TDtxqXuBNSp sHqvO/i/uw0Febd2GWVXPycthNDvV5l4QQciS3GJ/KnGUsdI+a9su+rLjkQazMHPiZHc gWBw== X-Gm-Message-State: ALoCoQkViYHO9aOYyymyq1VUcx27t5OdE5sn1k30Uqf0pyhgRoxt46iSmbVTAwPpAu9h5Dn2WLZ+ X-Received: by 10.107.37.134 with SMTP id l128mr45739185iol.92.1437994178464; Mon, 27 Jul 2015 03:49:38 -0700 (PDT) MIME-Version: 1.0 Received: by 10.79.65.207 with HTTP; Mon, 27 Jul 2015 03:49:18 -0700 (PDT) In-Reply-To: References: From: "Damian, Alexandru" Date: Mon, 27 Jul 2015 11:49:18 +0100 Message-ID: To: "Barros Pena, Belen" Cc: "toaster@yoctoproject.org" Subject: Re: [review-request] adamian/bug_fixes X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Jul 2015 10:49:42 -0000 Content-Type: multipart/alternative; boundary=001a1140ea863269e5051bd91c81 --001a1140ea863269e5051bd91c81 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Done, the branch is: adamian/20150727_bug_fixes_review Thank you, Alex On Mon, Jul 27, 2015 at 11:44 AM, Barros Pena, Belen < belen.barros.pena@intel.com> wrote: > > > On 24/07/2015 18:10, "toaster-bounces@yoctoproject.org on behalf of > Damian, Alexandru" alexandru.damian@intel.com> wrote: > > > > > > >=E2=80=8BHi, > > > > > >This is a review request for adamian/bug_fixes > >< > https://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=3Dadamian/= bu > >g_fixes>=E2=80=8B > > Hi Alex, > > I would like to have a look at the fix for 7995 and the issue with > displaying builds in progress in the all builds table, but the branch you > posted in based on BitBake, not poky, which makes it hard for me to test. > Any chance you could post a branch based on poky? > > Thanks! > > Bel=C3=A9n > > > > > > >=E2=80=8BIt contains a previously submitted patchset, and a fix for #799= 5 > > > > > >Please review and submit when possible. > > > > > >Cheers, > >Alex=E2=80=8B > > > > > > > > > >-- > >Alex Damian > >Yocto Project > > > >SSG / OTC > > > > > > > > --=20 Alex Damian Yocto Project SSG / OTC --001a1140ea863269e5051bd91c81 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Done, the branch is:

adamian/20150727_bug_fixes_review

Tha= nk you,
Alex

On Mon, Jul 27, 2015 at 11:44 AM, Barros Pena, Belen <belen.barros.pena@intel.com> wrote:


On 24/07/2015 18:10, "toaster-bounces@yoctoproject.org on behalf of
Damian, Alexandru" <toaster-bounces@yoctoproject.org on behalf of
alexandru.damian@intel.com> wrote:

>
>
>=E2=80=8BHi,
>
>
>This is a review request for adamian/bug_fixes
><https://git.yocto= project.org/cgit/cgit.cgi/poky-contrib/log/?h=3Dadamian/bu
>g_fixes>=E2=80=8B

Hi Alex,

I would like to have a look at the fix for 7995 and the issue with
displaying builds in progress in the all builds table, but the branch you posted in based on BitBake, not poky, which makes it hard for me to test. Any chance you could post a branch based on poky?

Thanks!

Bel=C3=A9n

>
>
>=E2=80=8BIt contains a previously submitted patchset, and a fix for #79= 95
>
>
>Please review and submit when possible.
>
>
>Cheers,
>Alex=E2=80=8B
>
>
>
>
>--
>Alex Damian
>Yocto Project
>
>SSG / OTC
>
>
>




--
=
Alex Damian
Yocto Proje= ct
SSG / OTC=C2=A0
--001a1140ea863269e5051bd91c81-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id C5755E00A54; Mon, 27 Jul 2015 04:09:11 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, TRACKER_ID autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/, high * trust * [192.55.52.93 listed in list.dnswl.org] * 1.3 TRACKER_ID BODY: Incorporates a tracking ID number * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 3181FE0049B for ; Mon, 27 Jul 2015 04:08:02 -0700 (PDT) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 27 Jul 2015 04:08:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,553,1432623600"; d="scan'208";a="770444675" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by fmsmga002.fm.intel.com with ESMTP; 27 Jul 2015 04:08:02 -0700 Received: from irsmsx110.ger.corp.intel.com ([169.254.15.29]) by IRSMSX104.ger.corp.intel.com ([169.254.5.131]) with mapi id 14.03.0224.002; Mon, 27 Jul 2015 12:08:00 +0100 From: "Barros Pena, Belen" To: "Damian, Alexandru" , "toaster@yoctoproject.org" Thread-Topic: [Toaster] [review-request] adamian/bug_fixes Thread-Index: AQHQxjPHlnszvAbap0i0Jj/TLi1sb53vLJaA Date: Mon, 27 Jul 2015 11:08:00 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/14.5.3.150624 x-originating-ip: [10.237.224.80] MIME-Version: 1.0 Subject: Re: [review-request] adamian/bug_fixes X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Jul 2015 11:09:11 -0000 Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-ID: <9984EBF5F11414409DBD0B8C5CB44D0D@intel.com> Content-Transfer-Encoding: base64 VGhhbmtzIGZvciB0aGUgcG9reS1iYXNlZCBicmFuY2ggQWxleCEgQSBjb3VwbGUgb2YgY29tbWVu dHMgYmVsb3cuDQoNCk9uIDI0LzA3LzIwMTUgMTg6MTAsICJ0b2FzdGVyLWJvdW5jZXNAeW9jdG9w cm9qZWN0Lm9yZyBvbiBiZWhhbGYgb2YNCkRhbWlhbiwgQWxleGFuZHJ1IiA8dG9hc3Rlci1ib3Vu Y2VzQHlvY3RvcHJvamVjdC5vcmcgb24gYmVoYWxmIG9mDQphbGV4YW5kcnUuZGFtaWFuQGludGVs LmNvbT4gd3JvdGU6DQoNCj4NCj4NCj7igItIaSwNCj4NCj4NCj5UaGlzIGlzIGEgcmV2aWV3IHJl cXVlc3QgZm9yIGFkYW1pYW4vYnVnX2ZpeGVzDQo+PGh0dHBzOi8vZ2l0LnlvY3RvcHJvamVjdC5v cmcvY2dpdC9jZ2l0LmNnaS9wb2t5LWNvbnRyaWIvbG9nLz9oPWFkYW1pYW4vYnUNCj5nX2ZpeGVz PuKAiw0KPg0KPg0KPuKAi0l0IGNvbnRhaW5zIGEgcHJldmlvdXNseSBzdWJtaXR0ZWQgcGF0Y2hz ZXQsIGFuZCBhIGZpeCBmb3IgIzc5OTUNCg0KDQpiYzRlYTgzZjkzNjU3ZDg3NmI0M2I3NTE1NDk3 MzViNjgzYzMzMDQwDQoNClRoZSBidWlsZHMgaW4gcHJvZ3Jlc3Mgbm8gbG9uZ2VyIHNob3cgaW4g dGhlIGFsbCBidWlsZHMgcGFnZSwgYnV0IHRoZXkNCnN0aWxsIHNob3cgaW4gdGhlIHByb2plY3Qg YnVpbGRzIHBhZ2UuDQoNCk9uIHRoZSBicmlnaHQgc2lkZSwgSSBrbm93IHRoYXQgYmVjYXVzZSBJ IGNhbiBub3cgcmVhY2ggdGhlIHByb2plY3QgYnVpbGRzDQpwYWdlIDopIHNvIHRoZSBwYXRjaCBm b3IgNzk5NSB3b3JrcyBmb3IgbWUuDQoNClRoYW5rcyENCg0KQmVsw6luDQoNCj4NCj4NCj5QbGVh c2UgcmV2aWV3IGFuZCBzdWJtaXQgd2hlbiBwb3NzaWJsZS4NCj4NCj4NCj5DaGVlcnMsDQo+QWxl eOKAiw0KPg0KPg0KPg0KPg0KPi0tIA0KPkFsZXggRGFtaWFuDQo+WW9jdG8gUHJvamVjdA0KPg0K PlNTRyAvIE9UQyANCj4NCj4NCj4NCg0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 95084E00A26; Mon, 27 Jul 2015 04:45:57 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00,HTML_MESSAGE, RCVD_IN_DNSWL_LOW,TRACKER_ID autolearn=no version=3.3.1 X-Spam-HAM-Report: * -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low * trust * [209.85.213.176 listed in list.dnswl.org] * 1.3 TRACKER_ID BODY: Incorporates a tracking ID number * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * 0.0 HTML_MESSAGE BODY: HTML included in message Received: from mail-ig0-f176.google.com (mail-ig0-f176.google.com [209.85.213.176]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 3F0A2E0049B for ; Mon, 27 Jul 2015 04:45:55 -0700 (PDT) Received: by igk11 with SMTP id 11so57571270igk.1 for ; Mon, 27 Jul 2015 04:45:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=69LvbkVOUPcbN7rg0HRY+v3/F8urSIXzM8/liPo2w0k=; b=Uo/Ye4P4oyY8D2g5RDYNItBa/GJmBFd9YN+iRaN6FMcKQCQ/hCeFZEBi+ZzkaIa5ru 72VLWty3BAr1AKO/xzFamhTlkFzF17gk4Lufklscqc5AVVkQGUwAj8WP79tOTW38xF6w rybR8wh2yl7twJTjnIyO58dttX4OLZ2euCuOX6MCp3aibYIdxGD5FX40vg1UIvopK56i 8zNA/XoxB+2V3MWSP88Ncf1GTxEQZX+1+2/ggezc3/zS19DYZ8lNDu7C+7ueDeKxxRsH AmE1WS3ZGsHhgxmJIHj6K1KyK/H4WYIpCEcY0k/d2l5bAnUw6624jrAKkuU52zQniPx8 5M0Q== X-Gm-Message-State: ALoCoQnV/0zkjFrYJNr5q/BomFsnBukSjO4b1V8DHr/M1cg7CB07SgYFxjycZHRaBiCD42qrL4Bv X-Received: by 10.107.16.169 with SMTP id 41mr39646101ioq.117.1437997555178; Mon, 27 Jul 2015 04:45:55 -0700 (PDT) MIME-Version: 1.0 Received: by 10.79.65.207 with HTTP; Mon, 27 Jul 2015 04:45:35 -0700 (PDT) In-Reply-To: References: From: "Damian, Alexandru" Date: Mon, 27 Jul 2015 12:45:35 +0100 Message-ID: To: "Barros Pena, Belen" Cc: "toaster@yoctoproject.org" Subject: Re: [review-request] adamian/bug_fixes X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Jul 2015 11:45:57 -0000 Content-Type: multipart/alternative; boundary=001a113edac4770513051bd9e5b1 --001a113edac4770513051bd9e5b1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Re-pushed the same branch with IN PROGRESS fixed applied to both build pages. Cheers, Alex On Mon, Jul 27, 2015 at 12:08 PM, Barros Pena, Belen < belen.barros.pena@intel.com> wrote: > Thanks for the poky-based branch Alex! A couple of comments below. > > On 24/07/2015 18:10, "toaster-bounces@yoctoproject.org on behalf of > Damian, Alexandru" alexandru.damian@intel.com> wrote: > > > > > > >=E2=80=8BHi, > > > > > >This is a review request for adamian/bug_fixes > >< > https://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=3Dadamian/= bu > >g_fixes>=E2=80=8B > > > > > >=E2=80=8BIt contains a previously submitted patchset, and a fix for #799= 5 > > > bc4ea83f93657d876b43b751549735b683c33040 > > The builds in progress no longer show in the all builds page, but they > still show in the project builds page. > > On the bright side, I know that because I can now reach the project build= s > page :) so the patch for 7995 works for me. > > Thanks! > > Bel=C3=A9n > > > > > > >Please review and submit when possible. > > > > > >Cheers, > >Alex=E2=80=8B > > > > > > > > > >-- > >Alex Damian > >Yocto Project > > > >SSG / OTC > > > > > > > > --=20 Alex Damian Yocto Project SSG / OTC --001a113edac4770513051bd9e5b1 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Re-pushed the same branch with IN PROGRESS fixed applied to both= build pages.

Cheers,
Alex

On Mon, Jul 27, 2015 at 12:08 PM, Barros Pena, Belen= <belen.barros.pena@intel.com> wrote:
Thanks for the poky-based branch Alex! A couple of co= mments below.

On 24/07/2015 18:10, "toaster-bounces@yoctoproject.org on behalf of
Damian, Alexandru" <toaster-bounces@yoctoproject.org on behalf of
alexandru.damian@intel.com> wrote:

>
>
>=E2=80=8BHi,
>
>
>This is a review request for adamian/bug_fixes
><https://git.yocto= project.org/cgit/cgit.cgi/poky-contrib/log/?h=3Dadamian/bu
>g_fixes>=E2=80=8B
>
>
>=E2=80=8BIt contains a previously submitted patchset, and a fix for #79= 95


bc4ea83f93657d876b43b751549735b683c33040

The builds in progress no longer show in the all builds page, but they
still show in the project builds page.

On the bright side, I know that because I can now reach the project builds<= br> page :) so the patch for 7995 works for me.

Thanks!

Bel=C3=A9n

>
>
>Please review and submit when possible.
>
>
>Cheers,
>Alex=E2=80=8B
>
>
>
>
>--
>Alex Damian
>Yocto Project
>
>SSG / OTC
>
>
>




--
=
Alex Damian
Yocto Proje= ct
SSG / OTC=C2=A0
--001a113edac4770513051bd9e5b1-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 5AE65E00A3B; Mon, 27 Jul 2015 05:08:32 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/, high * trust * [192.55.52.93 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id D4E61E009D6 for ; Mon, 27 Jul 2015 05:08:30 -0700 (PDT) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP; 27 Jul 2015 05:08:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,553,1432623600"; d="scan'208";a="755630540" Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by fmsmga001.fm.intel.com with ESMTP; 27 Jul 2015 05:08:29 -0700 Received: from irsmsx110.ger.corp.intel.com ([169.254.15.29]) by IRSMSX103.ger.corp.intel.com ([169.254.3.149]) with mapi id 14.03.0224.002; Mon, 27 Jul 2015 13:08:28 +0100 From: "Barros Pena, Belen" To: "Damian, Alexandru" Thread-Topic: [Toaster] [review-request] adamian/bug_fixes Thread-Index: AQHQxjPHlnszvAbap0i0Jj/TLi1sb53vLJaA///5voCAABcmAA== Date: Mon, 27 Jul 2015 12:08:26 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/14.5.3.150624 x-originating-ip: [10.237.224.80] MIME-Version: 1.0 Cc: "toaster@yoctoproject.org" Subject: Re: [review-request] adamian/bug_fixes X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Jul 2015 12:08:32 -0000 Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-ID: <6A00390E2E362F4B8BA694BF4BC9A809@intel.com> Content-Transfer-Encoding: base64 DQoNCk9uIDI3LzA3LzIwMTUgMTI6NDUsICJEYW1pYW4sIEFsZXhhbmRydSIgPGFsZXhhbmRydS5k YW1pYW5AaW50ZWwuY29tPg0Kd3JvdGU6DQoNCj5SZS1wdXNoZWQgdGhlIHNhbWUgYnJhbmNoIHdp dGggSU4gUFJPR1JFU1MgZml4ZWQgYXBwbGllZCB0byBib3RoIGJ1aWxkDQo+cGFnZXMuDQoNCk5v dyBpdCBzZWVtcyB0byBiZSB3b3JraW5nIGluIGJvdGggcGxhY2VzLg0KDQpUaGFua3MhDQoNCkJl bMOpbg0KDQo+DQo+DQo+Q2hlZXJzLA0KPkFsZXgNCj4NCj4NCj5PbiBNb24sIEp1bCAyNywgMjAx NSBhdCAxMjowOCBQTSwgQmFycm9zIFBlbmEsIEJlbGVuDQo+PGJlbGVuLmJhcnJvcy5wZW5hQGlu dGVsLmNvbT4gd3JvdGU6DQo+DQo+VGhhbmtzIGZvciB0aGUgcG9reS1iYXNlZCBicmFuY2ggQWxl eCEgQSBjb3VwbGUgb2YgY29tbWVudHMgYmVsb3cuDQo+DQo+T24gMjQvMDcvMjAxNSAxODoxMCwg InRvYXN0ZXItYm91bmNlc0B5b2N0b3Byb2plY3Qub3JnIG9uIGJlaGFsZiBvZg0KPkRhbWlhbiwg QWxleGFuZHJ1IiA8dG9hc3Rlci1ib3VuY2VzQHlvY3RvcHJvamVjdC5vcmcgb24gYmVoYWxmIG9m DQo+YWxleGFuZHJ1LmRhbWlhbkBpbnRlbC5jb20+IHdyb3RlOg0KPg0KPj4NCj4+DQo+PuKAi0hp LA0KPj4NCj4+DQo+PlRoaXMgaXMgYSByZXZpZXcgcmVxdWVzdCBmb3IgYWRhbWlhbi9idWdfZml4 ZXMNCj4+PGh0dHBzOi8vZ2l0LnlvY3RvcHJvamVjdC5vcmcvY2dpdC9jZ2l0LmNnaS9wb2t5LWNv bnRyaWIvbG9nLz9oPWFkYW1pYW4vYg0KPj51DQo+PmdfZml4ZXM+4oCLDQo+Pg0KPj4NCj4+4oCL SXQgY29udGFpbnMgYSBwcmV2aW91c2x5IHN1Ym1pdHRlZCBwYXRjaHNldCwgYW5kIGEgZml4IGZv ciAjNzk5NQ0KPg0KPg0KPmJjNGVhODNmOTM2NTdkODc2YjQzYjc1MTU0OTczNWI2ODNjMzMwNDAN Cj4NCj5UaGUgYnVpbGRzIGluIHByb2dyZXNzIG5vIGxvbmdlciBzaG93IGluIHRoZSBhbGwgYnVp bGRzIHBhZ2UsIGJ1dCB0aGV5DQo+c3RpbGwgc2hvdyBpbiB0aGUgcHJvamVjdCBidWlsZHMgcGFn ZS4NCj4NCj5PbiB0aGUgYnJpZ2h0IHNpZGUsIEkga25vdyB0aGF0IGJlY2F1c2UgSSBjYW4gbm93 IHJlYWNoIHRoZSBwcm9qZWN0IGJ1aWxkcw0KPnBhZ2UgOikgc28gdGhlIHBhdGNoIGZvciA3OTk1 IHdvcmtzIGZvciBtZS4NCj4NCj5UaGFua3MhDQo+DQo+QmVsw6luDQo+DQo+Pg0KPj4NCj4+UGxl YXNlIHJldmlldyBhbmQgc3VibWl0IHdoZW4gcG9zc2libGUuDQo+Pg0KPj4NCj4+Q2hlZXJzLA0K Pj5BbGV44oCLDQo+Pg0KPj4NCj4+DQo+Pg0KPj4tLQ0KPj5BbGV4IERhbWlhbg0KPj5Zb2N0byBQ cm9qZWN0DQo+Pg0KPj5TU0cgLyBPVEMNCj4+DQo+Pg0KPj4NCj4NCj4NCj4NCj4NCj4NCj4NCj4N Cj4NCj4NCj4NCj4tLSANCj5BbGV4IERhbWlhbg0KPllvY3RvIFByb2plY3QNCj4NCj5TU0cgLyBP VEMgDQo+DQo+DQo+DQoNCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id A6658E00A80; Wed, 29 Jul 2015 04:37:17 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, TRACKER_ID autolearn=no version=3.3.1 X-Spam-HAM-Report: * -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low * trust * [209.85.212.179 listed in list.dnswl.org] * 1.3 TRACKER_ID BODY: Incorporates a tracking ID number * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Received: from mail-wi0-f179.google.com (mail-wi0-f179.google.com [209.85.212.179]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 7949DE009EB for ; Wed, 29 Jul 2015 04:37:13 -0700 (PDT) Received: by wibxm9 with SMTP id xm9so196950975wib.0 for ; Wed, 29 Jul 2015 04:37:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=xXHhkAeLzdkRnbqeJ667OMs7Wz4+Y55nRLVBDxcJxvM=; b=eLlIt4tuqTfiHOwFe78CU7CTxmyut79GyUUdaXT754chx1XfX3GAlJzLlOeSSmrKwI NsAEnNvyjMmSzF9HjiYiphUc4Cm9Tfv3u6ZOK7VrDn/tvej5irAavpDG/QF9klf5Yyi3 tP/MNdtLi7pI3+cFYV8o7aMHuhlUyConSdSMHIlDjMRx7XAtnbT2W3m9IpQmtUyCbjTn AcUBV4ws1N+TO47xFV0EEWk/WJz4aSc29DMZsS4Q93KwnDfI1fjMEvq7Ec8RyQYC7E4i NWGqZJhxGMXw2njr6cpRDpPxLVml+gXZdBNz6F5ovi5ihFFa1w98EFwAKKmF+J+nKBfE hqmA== X-Gm-Message-State: ALoCoQkgkco1wcw2ykwojPutZKckx7aZAxIXEUDUE4rVttrDHlvBs5U+SzRm6lWojNxZj+URyMBk X-Received: by 10.180.78.73 with SMTP id z9mr16616649wiw.64.1438169832756; Wed, 29 Jul 2015 04:37:12 -0700 (PDT) Received: from [192.168.2.72] ([83.217.123.106]) by smtp.googlemail.com with ESMTPSA id ft5sm23943236wib.4.2015.07.29.04.37.11 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 29 Jul 2015 04:37:11 -0700 (PDT) Message-ID: <55B8BAE6.8070703@intel.com> Date: Wed, 29 Jul 2015 12:37:10 +0100 From: Michael Wood User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: toaster@yoctoproject.org References: In-Reply-To: Subject: Re: [review-request] adamian/bug_fixes X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jul 2015 11:37:17 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit On 27/07/15 13:08, Barros Pena, Belen wrote: > > On 27/07/2015 12:45, "Damian, Alexandru" > wrote: > >> Re-pushed the same branch with IN PROGRESS fixed applied to both build >> pages. > Now it seems to be working in both places. > > Thanks! > > Belén > >> >> Cheers, >> Alex >> >> >> On Mon, Jul 27, 2015 at 12:08 PM, Barros Pena, Belen >> wrote: >> >> Thanks for the poky-based branch Alex! A couple of comments below. >> >> On 24/07/2015 18:10, "toaster-bounces@yoctoproject.org on behalf of >> Damian, Alexandru" > alexandru.damian@intel.com> wrote: >> >>> >>> ​Hi, >>> >>> >>> This is a review request for adamian/bug_fixes >>> >> u >>> g_fixes>​ >>> >>> >>> ​It contains a previously submitted patchset, and a fix for #7995 >> >> bc4ea83f93657d876b43b751549735b683c33040 >> >> The builds in progress no longer show in the all builds page, but they >> still show in the project builds page. >> >> On the bright side, I know that because I can now reach the project builds >> page :) so the patch for 7995 works for me. >> >> Thanks! >> >> Belén >> >>> >>> Please review and submit when possible. >>> >>> >>> Cheers, >>> Alex​ >>> >>> >>> >>> >>> -- >>> Alex Damian >>> Yocto Project >>> >>> SSG / OTC >>> >>> >>> >> >> >> >> >> >> >> >> >> >> -- >> Alex Damian >> Yocto Project >> >> SSG / OTC >> >> >> Can you squash these two: ba72e1666796987bdec1bbf34d31a41ecf605936 and 9cce8032cbb70f0047f5819127c0c220963f2ce2 a125f3ab34a82eb684c46d5f01ee3544535ab5f4 diff --git a/lib/toaster/bldcontrol/management/commands/checksettings.py b/lib/toaster/bldcontrol/management/commands/checksettings.py index 3858b9e..b2631c4 100644 --- a/lib/toaster/bldcontrol/management/commands/checksettings.py +++ b/lib/toaster/bldcontrol/management/commands/checksettings.py @@ -99,10 +99,11 @@ class Command(NoArgsCommand): # find configuration files config_files = [] + selected_dirs = [] for dirname in self._recursive_list_directories(be.sourcedir,2): if os.path.exists(os.path.join(dirname, ".templateconf")): import subprocess - proc = subprocess.Popen('bash -c ". '+os.path.join(dirname, ".templateconf")+r'; echo \"$TEMPLATECONF\""', shell=True, stdout=subprocess.PIPE) + proc = subprocess.Popen('bash -c ". '+os.path.join(dirname, ".templateconf")+r'; echo \"\$TEMPLATECONF\""', shell=True, stdout=subprocess.PIPE) conffilepath, stderroroutput = proc.communicate() proc.wait() if proc.returncode != 0: @@ -114,6 +115,15 @@ class Command(NoArgsCommand): continue if os.path.exists(candidatefilepath): config_files.append(candidatefilepath) + selected_dirs.append(dirname) + + for dirname in self._recursive_list_directories(be.sourcedir,2): This for loop seems to be duplicated from the one above it checksettings.py (line 103 and 120) can they not be combined? However do we actually need to do all this searching? To simplify this couldn't we find "meta-yocto/conf/toasterconf.json" in the poky dir, if that doesn't exist then try the openembedded one, if that doesn't exist, ask? if people want to specify their own config we could have a -config option to bin/toaster. Thanks, Michael From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 66946E00973; Thu, 13 Aug 2015 09:36:36 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00,HTML_MESSAGE, RCVD_IN_DNSWL_LOW,TRACKER_ID autolearn=no version=3.3.1 X-Spam-HAM-Report: * 1.3 TRACKER_ID BODY: Incorporates a tracking ID number * -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low * trust * [209.85.213.172 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * 0.0 HTML_MESSAGE BODY: HTML included in message Received: from mail-ig0-f172.google.com (mail-ig0-f172.google.com [209.85.213.172]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 07808E0095C for ; Thu, 13 Aug 2015 09:36:34 -0700 (PDT) Received: by igui7 with SMTP id i7so86296428igu.1 for ; Thu, 13 Aug 2015 09:36:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=+0IrdGP1PvHVnWng6JNWT23iMdI0x2EeWbnGGIE8f+E=; b=D0R5vbAiPtdn/AaHmJ8B4kfUU9Y7x7R8cmQXvB39ZLje5RdTNMRhXSglo2/T4GBfzI k1QdLnkDx5zDVGLrzt26V5dJ0XLbjowySFi4OIbjARgVEzfDj14WaIUZEWFZPkC7w2q6 dzbHNnRXucclsrr2h3PBwCcz1vP/Zfg2t8Ilb1QtJe9+tOTjrGh/L/mxLDPzDEN56jCF sL2uo6eFv7W6Ep7PGmzU5x99grwnIK7W5y8Fptz9hD35YkUnr51cHPt66WVmMs+UYb/C nuk9seYVBVKOmmuemtbm/NvjbDrbADx4waEwuRg3uzO5jUwz+bA5azAwxHcqdBnxDau9 PtAg== X-Gm-Message-State: ALoCoQmMYqT4HTQPRRu9nQ/dBfrS2nZ+pWbdDG84nMExJ1+/zu1pO7/9VmyONsedmwUPSHs6JgYl X-Received: by 10.50.72.6 with SMTP id z6mr4106788igu.65.1439483793903; Thu, 13 Aug 2015 09:36:33 -0700 (PDT) MIME-Version: 1.0 Received: by 10.79.114.208 with HTTP; Thu, 13 Aug 2015 09:36:14 -0700 (PDT) In-Reply-To: <55B8BAE6.8070703@intel.com> References: <55B8BAE6.8070703@intel.com> From: "Damian, Alexandru" Date: Thu, 13 Aug 2015 17:36:14 +0100 Message-ID: To: Michael Wood Cc: "toaster@yoctoproject.org" Subject: Re: [review-request] adamian/bug_fixes X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Aug 2015 16:36:36 -0000 Content-Type: multipart/alternative; boundary=047d7bdc189a322ee1051d33f022 --047d7bdc189a322ee1051d33f022 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable I pushed new version with the requested changes, rebased on the latest master. The branch is the same: adamian/bug_fixes Cheers, Alex On Wed, Jul 29, 2015 at 12:37 PM, Michael Wood wrote: > On 27/07/15 13:08, Barros Pena, Belen wrote: > >> >> On 27/07/2015 12:45, "Damian, Alexandru" >> wrote: >> >> Re-pushed the same branch with IN PROGRESS fixed applied to both build >>> pages. >>> >> Now it seems to be working in both places. >> >> Thanks! >> >> Bel=C3=A9n >> >> >>> Cheers, >>> Alex >>> >>> >>> On Mon, Jul 27, 2015 at 12:08 PM, Barros Pena, Belen >>> wrote: >>> >>> Thanks for the poky-based branch Alex! A couple of comments below. >>> >>> On 24/07/2015 18:10, "toaster-bounces@yoctoproject.org on behalf of >>> Damian, Alexandru" >> alexandru.damian@intel.com> wrote: >>> >>> >>>> =E2=80=8BHi, >>>> >>>> >>>> This is a review request for adamian/bug_fixes >>>> < >>>> https://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=3Dadami= an/b >>>> u >>>> g_fixes>=E2=80=8B >>>> >>>> >>>> =E2=80=8BIt contains a previously submitted patchset, and a fix for #7= 995 >>>> >>> >>> bc4ea83f93657d876b43b751549735b683c33040 >>> >>> The builds in progress no longer show in the all builds page, but they >>> still show in the project builds page. >>> >>> On the bright side, I know that because I can now reach the project >>> builds >>> page :) so the patch for 7995 works for me. >>> >>> Thanks! >>> >>> Bel=C3=A9n >>> >>> >>>> Please review and submit when possible. >>>> >>>> >>>> Cheers, >>>> Alex=E2=80=8B >>>> >>>> >>>> >>>> >>>> -- >>>> Alex Damian >>>> Yocto Project >>>> >>>> SSG / OTC >>>> >>>> >>>> >>>> >>> >>> >>> >>> >>> >>> >>> >>> >>> -- >>> Alex Damian >>> Yocto Project >>> >>> SSG / OTC >>> >>> >>> >>> > > Can you squash these two: ba72e1666796987bdec1bbf34d31a41ecf605936 and > 9cce8032cbb70f0047f5819127c0c220963f2ce2 > > > > a125f3ab34a82eb684c46d5f01ee3544535ab5f4 > > > > diff --git a/lib/toaster/bldcontrol/management/commands/checksettings.py > b/lib/toaster/bldcontrol/management/commands/checksettings.py > index 3858b9e..b2631c4 100644 > --- a/lib/toaster/bldcontrol/management/commands/checksettings.py > +++ b/lib/toaster/bldcontrol/management/commands/checksettings.py > @@ -99,10 +99,11 @@ class Command(NoArgsCommand): > # find configuration files > config_files =3D [] > + selected_dirs =3D [] > for dirname in self._recursive_list_directories(be.sourcedir,2): > if os.path.exists(os.path.join(dirname, ".templateconf")): > import subprocess > - proc =3D subprocess.Popen('bash -c ". > '+os.path.join(dirname, ".templateconf")+r'; echo \"$TEMPLATECONF\""', > shell=3DTrue, stdout=3Dsubprocess.PIPE) > + proc =3D subprocess.Popen('bash -c ". > '+os.path.join(dirname, ".templateconf")+r'; echo \"\$TEMPLATECONF\""', > shell=3DTrue, stdout=3Dsubprocess.PIPE) > conffilepath, stderroroutput =3D proc.communicate() > proc.wait() > if proc.returncode !=3D 0: > @@ -114,6 +115,15 @@ class Command(NoArgsCommand): > continue > if os.path.exists(candidatefilepath): > config_files.append(candidatefilepath) > + selected_dirs.append(dirname) > + > + for dirname in self._recursive_list_directories(be.sourcedir,2): > > > This for loop seems to be duplicated from the one above it > checksettings.py (line 103 and 120) can they not be combined? > However do we actually need to do all this searching? To simplify this > couldn't we find "meta-yocto/conf/toasterconf.json" in the poky dir, if > that doesn't exist then try the openembedded one, if that doesn't exist, > ask? if people want to specify their own config we could have a -config > option to bin/toaster. > > Thanks, > > Michael > > > > > > > > -- > _______________________________________________ > toaster mailing list > toaster@yoctoproject.org > https://lists.yoctoproject.org/listinfo/toaster > --=20 Alex Damian Yocto Project SSG / OTC --047d7bdc189a322ee1051d33f022 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
I pushed new version with the requested changes, rebased on the = latest master.

The branch is the same:

adamian/bug_fixes
<= br>
Cheers,
Alex


On Wed, Jul 29, 2015 at 12:37 PM, Michael Wood <michael.g.wood@intel.com> wrote:
On 27/07/15 13:08, Barros P= ena, Belen wrote:

On 27/07/2015 12:45, "Damian, Alexandru" <alexandru.damian@intel.com&= gt;
wrote:

Re-pushed the same branch with IN PROGRESS fixed applied to both build
pages.
Now it seems to be working in both places.

Thanks!

Bel=C3=A9n


Cheers,
Alex


On Mon, Jul 27, 2015 at 12:08 PM, Barros Pena, Belen
<belen.= barros.pena@intel.com> wrote:

Thanks for the poky-based branch Alex! A couple of comments below.

On 24/07/2015 18:10, "toaster-bounces@yoctoproject.org on behalf of
Damian, Alexandru" <toaster-bounces@yoctoproject.org on behalf of alexandru.d= amian@intel.com> wrote:


=E2=80=8BHi,


This is a review request for adamian/bug_fixes
<https://git.yoctoproje= ct.org/cgit/cgit.cgi/poky-contrib/log/?h=3Dadamian/b
u
g_fixes>=E2=80=8B


=E2=80=8BIt contains a previously submitted patchset, and a fix for #7995

bc4ea83f93657d876b43b751549735b683c33040

The builds in progress no longer show in the all builds page, but they
still show in the project builds page.

On the bright side, I know that because I can now reach the project builds<= br> page :) so the patch for 7995 works for me.

Thanks!

Bel=C3=A9n


Please review and submit when possible.


Cheers,
Alex=E2=80=8B




--
Alex Damian
Yocto Project

SSG / OTC












--
Alex Damian
Yocto Project

SSG / OTC





Can you squash these two: ba72e1666796987bdec1bbf34d31a41ecf605936 and 9cce= 8032cbb70f0047f5819127c0c220963f2ce2



a125f3ab34a82eb684c46d5f01ee3544535ab5f4



diff --git a/lib/toaster/bldcontrol/management/commands/checksettings.py b/= lib/toaster/bldcontrol/management/commands/checksettings.py
index 3858b9e..b2631c4 100644
--- a/lib/toaster/bldcontrol/management/commands/checksettings.py
+++ b/lib/toaster/bldcontrol/management/commands/checksettings.py
@@ -99,10 +99,11 @@ class Command(NoArgsCommand):
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 # find configuration files
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0config_files =3D []
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 selected_dirs =3D []
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0for dirname in self._recursive_list_direc= tories(be.sourcedir,2):
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if os.path.exists(os.path.j= oin(dirname, ".templateconf")):
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0import subpro= cess
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 proc =3D subproces= s.Popen('bash -c ". '+os.path.join(dirname, ".templatecon= f")+r'; echo \"$TEMPLATECONF\""', shell=3DTrue,= stdout=3Dsubprocess.PIPE)
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 proc =3D subproces= s.Popen('bash -c ". '+os.path.join(dirname, ".templatecon= f")+r'; echo \"\$TEMPLATECONF\""', shell=3DTrue= , stdout=3Dsubprocess.PIPE)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0conffilepath,= stderroroutput =3D proc.communicate()
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0proc.wait() =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if proc.retur= ncode !=3D 0:
@@ -114,6 +115,15 @@ class Command(NoArgsCommand):
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0continue
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if os.path.ex= ists(candidatefilepath):
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0config_files.append(candidatefilepath)
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 sele= cted_dirs.append(dirname)
+
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 for dirname in self._recursive_list_directorie= s(be.sourcedir,2):


This for loop seems to be duplicated from the one above it checksettings.py= (line 103 and 120) can they not be combined?
However do we actually need to do all this searching? To simplify this coul= dn't we find "meta-yocto/conf/toasterconf.json" in the poky d= ir, if that doesn't exist then try the openembedded one, if that doesn&= #39;t exist, ask? if people want to specify their own config we could have = a -config option to bin/toaster.

Thanks,

Michael







--
_______________________________________________
toaster mailing list
toaster@yocto= project.org
https://lists.yoctoproject.org/listinfo/toaster



--
Alex Damian
Yocto Project
SSG / OTC=C2=A0
--047d7bdc189a322ee1051d33f022-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id BA90BE00A6C; Fri, 14 Aug 2015 09:01:42 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low * trust * [209.85.212.176 listed in list.dnswl.org] Received: from mail-wi0-f176.google.com (mail-wi0-f176.google.com [209.85.212.176]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 64CE5E009EC for ; Fri, 14 Aug 2015 09:01:38 -0700 (PDT) Received: by wijp15 with SMTP id p15so23956898wij.0 for ; Fri, 14 Aug 2015 09:01:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=l63pZZza91Y55wca8eiA40Fbe7aSL5FLClTBQW/fffo=; b=QmKffsJ5hzBGAX3jLeT9M9wJQiAF3Uj9umABLZUeZ+trnprd9J8dqZCodHVS7dDQz/ lfD728Wrj5z9cM3QlPfjzLycDbUJVSMsYWfoviO3fC+mZxOjh9rLoo0jm0bh/BrHAK0E Vndkj5eo1lPYJ+rQNlZChY7ByHbyqjydGBXyUF/g1nIKj1RCyBuIRbwnAGCVKHdHNhx3 AOOpU3+RsMCzuxFCWT9pdtj1luVCMuHPMIybbfyfoMqyNFyZmXkHUkg6FxUIt5W6S7bq aPWKKRt3BCDgAjTESVWi8eFSfQSVnHxYMHIkjqvuqCdyr6zA84HsOdaNfheyaW7NkPgx vwJA== X-Gm-Message-State: ALoCoQk6NwxXpRM1nBDXm6bezm69xljB6L/VVxFF4m/PkjappYo0H7Ewa/i03k0VG4LrQkwF9/u/ X-Received: by 10.194.92.109 with SMTP id cl13mr1140069wjb.156.1439568097513; Fri, 14 Aug 2015 09:01:37 -0700 (PDT) Received: from [192.168.2.117] ([83.217.123.106]) by smtp.googlemail.com with ESMTPSA id o3sm4720544wjx.16.2015.08.14.09.01.36 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 14 Aug 2015 09:01:36 -0700 (PDT) Message-ID: <55CE10DB.3050203@intel.com> Date: Fri, 14 Aug 2015 17:01:31 +0100 From: Michael Wood User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: "Damian, Alexandru" References: <55B8BAE6.8070703@intel.com> In-Reply-To: Cc: "toaster@yoctoproject.org" Subject: Re: [review-request] adamian/bug_fixes X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Aug 2015 16:01:42 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit The branch fails the unit tests because you've removed a used import in d73cc179f3e12a3d3b33a6b0c3884bcea9be84a3 Could future branches be based on poky please as it's easier for me to do testing. Thanks, Michael On 13/08/15 17:36, Damian, Alexandru wrote: > I pushed new version with the requested changes, rebased on the latest > master. > > The branch is the same: > > adamian/bug_fixes > > Cheers, > Alex > > > On Wed, Jul 29, 2015 at 12:37 PM, Michael Wood > > wrote: > > On 27/07/15 13:08, Barros Pena, Belen wrote: > > > On 27/07/2015 12:45, "Damian, Alexandru" > > > wrote: > > Re-pushed the same branch with IN PROGRESS fixed applied > to both build > pages. > > Now it seems to be working in both places. > > Thanks! > > Belén > > > Cheers, > Alex > > > On Mon, Jul 27, 2015 at 12:08 PM, Barros Pena, Belen > > wrote: > > Thanks for the poky-based branch Alex! A couple of > comments below. > > On 24/07/2015 18:10, "toaster-bounces@yoctoproject.org > on behalf of > Damian, Alexandru" on behalf of > alexandru.damian@intel.com > > wrote: > > > ​Hi, > > > This is a review request for adamian/bug_fixes > u > g_fixes>​ > > > ​It contains a previously submitted patchset, and a > fix for #7995 > > > bc4ea83f93657d876b43b751549735b683c33040 > > The builds in progress no longer show in the all builds > page, but they > still show in the project builds page. > > On the bright side, I know that because I can now reach > the project builds > page :) so the patch for 7995 works for me. > > Thanks! > > Belén > > > Please review and submit when possible. > > > Cheers, > Alex​ > > > > > -- > Alex Damian > Yocto Project > > SSG / OTC > > > > > > > > > > > > > -- > Alex Damian > Yocto Project > > SSG / OTC > > > > > > Can you squash these two: ba72e1666796987bdec1bbf34d31a41ecf605936 > and 9cce8032cbb70f0047f5819127c0c220963f2ce2 > > > > a125f3ab34a82eb684c46d5f01ee3544535ab5f4 > > > > diff --git > a/lib/toaster/bldcontrol/management/commands/checksettings.py > b/lib/toaster/bldcontrol/management/commands/checksettings.py > index 3858b9e..b2631c4 100644 > --- a/lib/toaster/bldcontrol/management/commands/checksettings.py > +++ b/lib/toaster/bldcontrol/management/commands/checksettings.py > @@ -99,10 +99,11 @@ class Command(NoArgsCommand): > # find configuration files > config_files = [] > + selected_dirs = [] > for dirname in > self._recursive_list_directories(be.sourcedir,2): > if os.path.exists(os.path.join(dirname, > ".templateconf")): > import subprocess > - proc = subprocess.Popen('bash -c ". > '+os.path.join(dirname, ".templateconf")+r'; echo > \"$TEMPLATECONF\""', shell=True, stdout=subprocess.PIPE) > + proc = subprocess.Popen('bash -c ". > '+os.path.join(dirname, ".templateconf")+r'; echo > \"\$TEMPLATECONF\""', shell=True, stdout=subprocess.PIPE) > conffilepath, stderroroutput = proc.communicate() > proc.wait() > if proc.returncode != 0: > @@ -114,6 +115,15 @@ class Command(NoArgsCommand): > continue > if os.path.exists(candidatefilepath): > config_files.append(candidatefilepath) > + selected_dirs.append(dirname) > + > + for dirname in > self._recursive_list_directories(be.sourcedir,2): > > > This for loop seems to be duplicated from the one above it > checksettings.py (line 103 and 120) can they not be combined? > However do we actually need to do all this searching? To simplify > this couldn't we find "meta-yocto/conf/toasterconf.json" in the > poky dir, if that doesn't exist then try the openembedded one, if > that doesn't exist, ask? if people want to specify their own > config we could have a -config option to bin/toaster. > > Thanks, > > Michael > > > > > > > > -- > _______________________________________________ > toaster mailing list > toaster@yoctoproject.org > https://lists.yoctoproject.org/listinfo/toaster > > > > > -- > Alex Damian > Yocto Project > SSG / OTC > > --------------------------------------------------------------------- > Intel Corporation (UK) Limited > Registered No. 1134945 (England) > Registered Office: Pipers Way, Swindon SN3 1RJ > VAT No: 860 2173 47 > > This e-mail and any attachments may contain confidential material for > the sole use of the intended recipient(s). Any review or distribution > by others is strictly prohibited. If you are not the intended > recipient, please contact the sender and delete all copies. > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 6C3F0E00A9C; Mon, 17 Aug 2015 04:20:01 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,HTML_MESSAGE, RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low * trust * [209.85.223.177 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * 0.0 HTML_MESSAGE BODY: HTML included in message Received: from mail-io0-f177.google.com (mail-io0-f177.google.com [209.85.223.177]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id CB241E006BC for ; Mon, 17 Aug 2015 04:19:54 -0700 (PDT) Received: by iodv127 with SMTP id v127so131137767iod.3 for ; Mon, 17 Aug 2015 04:19:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=RUdI460u7SHUILQQtcayzAOToKAWP8u6chOXgalqTIY=; b=DV0TG2+hogw3sWeSPfat9M5RIJX5INQ1JFqWTYzN7GBB5DvvYWhbD8o1IA+/I4qaE6 9tOTgsh7X3DAVHp5oZdxO+sZe538knmoTyV44vzzT8u7NxzuiRqs4eLz9R48XzdgjJsO GjV5rJBsOPReh7lGi94gKK3hIxHTXuChBMgSMk05amoUFGraxu8CW2LsMcdB/xGhfWnm 5Db3iEwTDn56aEsTHsttn7V8xEOriBHmA+k5a4rutt1rOVqtIj7OVd7VpzTpidimVgtu FXvTfHMPfcmByjoTDmAU1EvzIvGNgpD+5cdDzMnkKFvGHe5ypf3XxXuP2bAy854h4l0f i3cQ== X-Gm-Message-State: ALoCoQmmjfOtfieafH1KNklz0zo1111i4Xkk88umLnnM4QLvgfn5kqldNQ2g5knKY+4azQ2SjDnA X-Received: by 10.107.34.147 with SMTP id i141mr709807ioi.59.1439810394341; Mon, 17 Aug 2015 04:19:54 -0700 (PDT) MIME-Version: 1.0 Received: by 10.79.6.137 with HTTP; Mon, 17 Aug 2015 04:19:34 -0700 (PDT) In-Reply-To: <55CE10DB.3050203@intel.com> References: <55B8BAE6.8070703@intel.com> <55CE10DB.3050203@intel.com> From: "Damian, Alexandru" Date: Mon, 17 Aug 2015 12:19:34 +0100 Message-ID: To: Michael Wood Cc: "toaster@yoctoproject.org" Subject: Re: [review-request] adamian/bug_fixes X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Aug 2015 11:20:01 -0000 Content-Type: multipart/alternative; boundary=001a1140289a1975d4051d7ffbac --001a1140289a1975d4051d7ffbac Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi, Yep, I made a merge mistake. I fixed the issue and rebased everything on top of poky. adamian/20150817_bug_fixes_poky Can you please review and merge ? Cheers, Alex On Fri, Aug 14, 2015 at 5:01 PM, Michael Wood wrote: > The branch fails the unit tests because you've removed a used import in > d73cc179f3e12a3d3b33a6b0c3884bcea9be84a3 > > Could future branches be based on poky please as it's easier for me to do > testing. > > Thanks, > > Michael > > On 13/08/15 17:36, Damian, Alexandru wrote: > >> I pushed new version with the requested changes, rebased on the latest >> master. >> >> The branch is the same: >> >> adamian/bug_fixes >> >> Cheers, >> Alex >> >> >> On Wed, Jul 29, 2015 at 12:37 PM, Michael Wood > > wrote: >> >> On 27/07/15 13:08, Barros Pena, Belen wrote: >> >> >> On 27/07/2015 12:45, "Damian, Alexandru" >> > >> wrote: >> >> Re-pushed the same branch with IN PROGRESS fixed applied >> to both build >> pages. >> >> Now it seems to be working in both places. >> >> Thanks! >> >> Bel=C3=A9n >> >> >> Cheers, >> Alex >> >> >> On Mon, Jul 27, 2015 at 12:08 PM, Barros Pena, Belen >> > > wrote: >> >> Thanks for the poky-based branch Alex! A couple of >> comments below. >> >> On 24/07/2015 18:10, "toaster-bounces@yoctoproject.org >> on behalf of >> Damian, Alexandru" > on behalf of >> alexandru.damian@intel.com >> >> > wrote: >> >> >> =E2=80=8BHi, >> >> >> This is a review request for adamian/bug_fixes >> < >> https://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=3Dadamian= /b >> u >> g_fixes>=E2=80=8B >> >> >> =E2=80=8BIt contains a previously submitted patchset, an= d a >> fix for #7995 >> >> >> bc4ea83f93657d876b43b751549735b683c33040 >> >> The builds in progress no longer show in the all builds >> page, but they >> still show in the project builds page. >> >> On the bright side, I know that because I can now reach >> the project builds >> page :) so the patch for 7995 works for me. >> >> Thanks! >> >> Bel=C3=A9n >> >> >> Please review and submit when possible. >> >> >> Cheers, >> Alex=E2=80=8B >> >> >> >> >> -- >> Alex Damian >> Yocto Project >> >> SSG / OTC >> >> >> >> >> >> >> >> >> >> >> >> >> -- Alex Damian >> Yocto Project >> >> SSG / OTC >> >> >> >> >> >> Can you squash these two: ba72e1666796987bdec1bbf34d31a41ecf605936 >> and 9cce8032cbb70f0047f5819127c0c220963f2ce2 >> >> >> >> a125f3ab34a82eb684c46d5f01ee3544535ab5f4 >> >> >> >> diff --git >> a/lib/toaster/bldcontrol/management/commands/checksettings.py >> b/lib/toaster/bldcontrol/management/commands/checksettings.py >> index 3858b9e..b2631c4 100644 >> --- a/lib/toaster/bldcontrol/management/commands/checksettings.py >> +++ b/lib/toaster/bldcontrol/management/commands/checksettings.py >> @@ -99,10 +99,11 @@ class Command(NoArgsCommand): >> # find configuration files >> config_files =3D [] >> + selected_dirs =3D [] >> for dirname in >> self._recursive_list_directories(be.sourcedir,2): >> if os.path.exists(os.path.join(dirname, >> ".templateconf")): >> import subprocess >> - proc =3D subprocess.Popen('bash -c ". >> '+os.path.join(dirname, ".templateconf")+r'; echo >> \"$TEMPLATECONF\""', shell=3DTrue, stdout=3Dsubprocess.PIPE) >> + proc =3D subprocess.Popen('bash -c ". >> '+os.path.join(dirname, ".templateconf")+r'; echo >> \"\$TEMPLATECONF\""', shell=3DTrue, stdout=3Dsubprocess.PIPE) >> conffilepath, stderroroutput =3D proc.communicate() >> proc.wait() >> if proc.returncode !=3D 0: >> @@ -114,6 +115,15 @@ class Command(NoArgsCommand): >> continue >> if os.path.exists(candidatefilepath): >> config_files.append(candidatefilepath) >> + selected_dirs.append(dirname) >> + >> + for dirname in >> self._recursive_list_directories(be.sourcedir,2): >> >> >> This for loop seems to be duplicated from the one above it >> checksettings.py (line 103 and 120) can they not be combined? >> However do we actually need to do all this searching? To simplify >> this couldn't we find "meta-yocto/conf/toasterconf.json" in the >> poky dir, if that doesn't exist then try the openembedded one, if >> that doesn't exist, ask? if people want to specify their own >> config we could have a -config option to bin/toaster. >> >> Thanks, >> >> Michael >> >> >> >> >> >> >> >> -- _______________________________________________ >> toaster mailing list >> toaster@yoctoproject.org >> https://lists.yoctoproject.org/listinfo/toaster >> >> >> >> >> -- >> Alex Damian >> Yocto Project >> SSG / OTC >> >> --------------------------------------------------------------------- >> Intel Corporation (UK) Limited >> Registered No. 1134945 (England) >> Registered Office: Pipers Way, Swindon SN3 1RJ >> VAT No: 860 2173 47 >> >> This e-mail and any attachments may contain confidential material for >> the sole use of the intended recipient(s). Any review or distribution >> by others is strictly prohibited. If you are not the intended >> recipient, please contact the sender and delete all copies. >> >> > --------------------------------------------------------------------- > Intel Corporation (UK) Limited > Registered No. 1134945 (England) > Registered Office: Pipers Way, Swindon SN3 1RJ > VAT No: 860 2173 47 > > This e-mail and any attachments may contain confidential material for > the sole use of the intended recipient(s). Any review or distribution > by others is strictly prohibited. If you are not the intended > recipient, please contact the sender and delete all copies. > --=20 Alex Damian Yocto Project SSG / OTC --001a1140289a1975d4051d7ffbac Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi,

Yep, I made a merge mistake. I fixed the issue and re= based everything on top of poky.

adamian/20150817_bug_fixes_poky
=
Can you please review and merge ?

Cheers,
Alex

On Fri, Aug 14, = 2015 at 5:01 PM, Michael Wood <michael.g.wood@intel.com> wrote:
The branch fails the unit test= s because you've removed a used import in d73cc179f3e12a3d3b33a6b0c3884= bcea9be84a3

Could future branches be based on poky please as it's easier for me to = do testing.

Thanks,

Michael

On 13/08/15 17:36, Damian, Alexandru wrote:
I pushed new version with the requested changes, rebased on the latest mast= er.

The branch is the same:

adamian/bug_fixes

Cheers,
Alex


 On Wed, Jul 29, 2015 at 12:37 PM, Michael Wood <michael.g.wood@intel.com <mail= to:michael.g.= wood@intel.com>> wrote:

=C2=A0 =C2=A0 On 27/07/15 13:08, Barros Pena, Belen wrote:


=C2=A0 =C2=A0 =C2=A0 =C2=A0 On 27/07/2015 12:45, "Damian, Alexandru&qu= ot;
 =C2=A0 =C2=A0 =C2=A0 =C2=A0 <alexandru.damian@intel.com <mailto:alexandru.damian@intel.= com>>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 wrote:

=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Re-pushed the same branch with IN= PROGRESS fixed applied
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 to both build
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 pages.

=C2=A0 =C2=A0 =C2=A0 =C2=A0 Now it seems to be working in both places.

=C2=A0 =C2=A0 =C2=A0 =C2=A0 Thanks!

=C2=A0 =C2=A0 =C2=A0 =C2=A0 Bel=C3=A9n


=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Cheers,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Alex


=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 On Mon, Jul 27, 2015 at 12:08 PM,= Barros Pena, Belen
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 <belen.barros.pena@intel.com
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 <mailto:belen.barros.pena@intel.com&= gt;> wrote:

=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Thanks for the poky-based branch = Alex! A couple of
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 comments below.

=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 On 24/07/2015 18:10, "toaster-bou= nces@yoctoproject.org
 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 <mailto:toaster-bounces@yoctoprojec= t.org> on behalf of
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Damian, Alexandru" <toaster-bo= unces@yoctoproject.org
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 <mailto:toaster-bounces@yoctoprojec= t.org> on behalf of
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 alexandru.damian@intel.com

=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 <mailto:alexandru.damian@intel.com>= ;> wrote:


=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =E2=80=8BHi,


=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 This is a review re= quest for adamian/bug_fixes
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 <https://git.yoctoproject.org/cgit/cgit.cg= i/poky-contrib/log/?h=3Dadamian/b
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 u
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 g_fixes>=E2=80= =8B


=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =E2=80=8BIt contain= s a previously submitted patchset, and a
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 fix for #7995


=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 bc4ea83f93657d876b43b751549735b68= 3c33040

=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 The builds in progress no longer = show in the all builds
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 page, but they
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 still show in the project builds = page.

=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 On the bright side, I know that b= ecause I can now reach
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 the project builds
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 page :) so the patch for 7995 wor= ks for me.

=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Thanks!

=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Bel=C3=A9n


=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Please review and s= ubmit when possible.


=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Cheers,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Alex=E2=80=8B




=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 --
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Alex Damian
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Yocto Project

=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 SSG / OTC












=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 --=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0Alex Damian
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Yocto Project

=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 SSG / OTC





=C2=A0 =C2=A0 Can you squash these two: ba72e1666796987bdec1bbf34d31a41ecf6= 05936
=C2=A0 =C2=A0 and 9cce8032cbb70f0047f5819127c0c220963f2ce2



=C2=A0 =C2=A0 a125f3ab34a82eb684c46d5f01ee3544535ab5f4



=C2=A0 =C2=A0 diff --git
=C2=A0 =C2=A0 a/lib/toaster/bldcontrol/management/commands/checksettings.py=
=C2=A0 =C2=A0 b/lib/toaster/bldcontrol/management/commands/checksettings.py=
=C2=A0 =C2=A0 index 3858b9e..b2631c4 100644
=C2=A0 =C2=A0 --- a/lib/toaster/bldcontrol/management/commands/checksetting= s.py
=C2=A0 =C2=A0 +++ b/lib/toaster/bldcontrol/management/commands/checksetting= s.py
=C2=A0 =C2=A0 @@ -99,10 +99,11 @@ class Command(NoArgsCommand):
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 # find configuration files=
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0config_files =3D []
=C2=A0 =C2=A0 +=C2=A0 =C2=A0 =C2=A0 =C2=A0 selected_dirs =3D []
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0for dirname in
=C2=A0 =C2=A0 self._recursive_list_directories(be.sourcedir,2):
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if os.path.ex= ists(os.path.join(dirname,
=C2=A0 =C2=A0 ".templateconf")):
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0import subprocess
=C2=A0 =C2=A0 -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 proc= =3D subprocess.Popen('bash -c ".
=C2=A0 =C2=A0 '+os.path.join(dirname, ".templateconf")+r'= ; echo
=C2=A0 =C2=A0 \"$TEMPLATECONF\""', shell=3DTrue, stdout= =3Dsubprocess.PIPE)
=C2=A0 =C2=A0 +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 proc= =3D subprocess.Popen('bash -c ".
=C2=A0 =C2=A0 '+os.path.join(dirname, ".templateconf")+r'= ; echo
=C2=A0 =C2=A0 \"\$TEMPLATECONF\""', shell=3DTrue, stdout= =3Dsubprocess.PIPE)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0conffilepath, stderroroutput =3D proc.communicate()
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0proc.wait()
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0if proc.returncode !=3D 0:
=C2=A0 =C2=A0 @@ -114,6 +115,15 @@ class Command(NoArgsCommand):
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0continue
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0if os.path.exists(candidatefilepath):
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0config_files.append(candidatefilepath)
=C2=A0 =C2=A0 +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 selected_dirs.append(dirname)
=C2=A0 =C2=A0 +
=C2=A0 =C2=A0 +=C2=A0 =C2=A0 =C2=A0 =C2=A0 for dirname in
=C2=A0 =C2=A0 self._recursive_list_directories(be.sourcedir,2):


=C2=A0 =C2=A0 This for loop seems to be duplicated from the one above it =C2=A0 =C2=A0 checksettings.py (line 103 and 120) can they not be combined?=
=C2=A0 =C2=A0 However do we actually need to do all this searching? To simp= lify
=C2=A0 =C2=A0 this couldn't we find "meta-yocto/conf/toasterconf.j= son" in the
=C2=A0 =C2=A0 poky dir, if that doesn't exist then try the openembedded= one, if
=C2=A0 =C2=A0 that doesn't exist, ask? if people want to specify their = own
=C2=A0 =C2=A0 config we could have a -config option to bin/toaster.

=C2=A0 =C2=A0 Thanks,

=C2=A0 =C2=A0 Michael







=C2=A0 =C2=A0 --=C2=A0 =C2=A0 =C2=A0_______________________________________= ________
=C2=A0 =C2=A0 toaster mailing list
=C2=A0 =C2=A0 toaster@yoctoproject.org <mailto:toaster@yoctoproject.org>
=C2=A0 =C2=A0 https://lists.yoctoproject.org/listinfo= /toaster




--
Alex Damian
Yocto Project
SSG / OTC

 ---------------------------------------------------------------------
Intel Corporation (UK) Limited
Registered No. 1134945 (England)
Registered Office: Pipers Way, Swindon SN3 1RJ
VAT No: 860 2173 47

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.


---------------------------------------------------------------------
Intel Corporation (UK) Limited
Registered No. 1134945 (England)
Registered Office: Pipers Way, Swindon SN3 1RJ
VAT No: 860 2173 47

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.



--
Alex Damian
Yocto Project
SSG / = OTC=C2=A0
--001a1140289a1975d4051d7ffbac-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 6B2AEE009F3; Tue, 18 Aug 2015 09:40:02 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low * trust * [209.85.212.176 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Received: from mail-wi0-f176.google.com (mail-wi0-f176.google.com [209.85.212.176]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id E62B9E008EC for ; Tue, 18 Aug 2015 09:39:58 -0700 (PDT) Received: by wicne3 with SMTP id ne3so99996427wic.0 for ; Tue, 18 Aug 2015 09:39:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=Ias2FpcTTQYG3QAWS8k2/7GtarT5wjgIzVeL/mqUPmM=; b=B+UbPkU4FCL4rEfT3TeqjX5XFhBLGnuQ0AOEGSHI8N84tyrpq7Jozqi+fisWnxyi6H a6THUkT78PP73QOeM2dVw99Gs8UIfb/7hlkVdC0k16zPSsn1kv/8rRDs3B6YBXfdwgAX 7NOKs/97N6V1Y+GhmpxffT19pdTLcEfIZ3llCmTKLArU+6AfVQdKyFU+IwpjAK0KHPhl DLXKJJefWjXYWqCitpOOP1Mq3nAJgMe36z9ezlnhtYCoda1/siKtDrZaN871ECC7zUyM oahBXWTFg5C7yWRCQZdieHk3ooDctLNwk+XnSltV8B+DEFUiVJmijA+rSVqGn2Hbs4BS 8tFA== X-Gm-Message-State: ALoCoQkHXaY6JPSCp7oBzb6oi/q3wnpn+3Zp9Y49UG2zHgaZZY4LeO/3Ym0OJM4odsd9+ReHj3XC X-Received: by 10.194.113.101 with SMTP id ix5mr15345597wjb.66.1439915997455; Tue, 18 Aug 2015 09:39:57 -0700 (PDT) Received: from [192.168.0.30] ([90.200.212.221]) by smtp.googlemail.com with ESMTPSA id yu4sm27197596wjc.43.2015.08.18.09.39.55 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 18 Aug 2015 09:39:56 -0700 (PDT) Message-ID: <55D35FDB.1010406@intel.com> Date: Tue, 18 Aug 2015 17:39:55 +0100 From: Michael Wood User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: "Damian, Alexandru" References: <55B8BAE6.8070703@intel.com> <55CE10DB.3050203@intel.com> In-Reply-To: Cc: "toaster@yoctoproject.org" Subject: Re: [review-request] adamian/bug_fixes X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Aug 2015 16:40:02 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Submitted upstream With the exception of ad0470144bcfb19065fa90512bd533754bd26a28 toaster: refactor checksettings.pyThat patch caused the toasterconf.json not to be found and had conflicts when rebased on master so was omitted. Thanks, Michael On 17/08/15 12:19, Damian, Alexandru wrote: > Hi, > > Yep, I made a merge mistake. I fixed the issue and rebased everything > on top of poky. > > adamian/20150817_bug_fixes_poky > > Can you please review and merge ? > > Cheers, > Alex > > On Fri, Aug 14, 2015 at 5:01 PM, Michael Wood > > wrote: > > The branch fails the unit tests because you've removed a used > import in d73cc179f3e12a3d3b33a6b0c3884bcea9be84a3 > > Could future branches be based on poky please as it's easier for > me to do testing. > > Thanks, > > Michael > > On 13/08/15 17:36, Damian, Alexandru wrote: > > I pushed new version with the requested changes, rebased on > the latest master. > > The branch is the same: > > adamian/bug_fixes > > Cheers, > Alex > > > On Wed, Jul 29, 2015 at 12:37 PM, Michael Wood > > >> wrote: > > On 27/07/15 13:08, Barros Pena, Belen wrote: > > > On 27/07/2015 12:45, "Damian, Alexandru" > > >> > wrote: > > Re-pushed the same branch with IN PROGRESS fixed > applied > to both build > pages. > > Now it seems to be working in both places. > > Thanks! > > Belén > > > Cheers, > Alex > > > On Mon, Jul 27, 2015 at 12:08 PM, Barros Pena, Belen > > >> wrote: > > Thanks for the poky-based branch Alex! A couple of > comments below. > > On 24/07/2015 18:10, > "toaster-bounces@yoctoproject.org > > > on behalf of > Damian, Alexandru" > > > on behalf of > alexandru.damian@intel.com > > >> wrote: > > > ​Hi, > > > This is a review request for adamian/bug_fixes > > u > g_fixes>​ > > > ​It contains a previously submitted patchset, > and a > fix for #7995 > > > bc4ea83f93657d876b43b751549735b683c33040 > > The builds in progress no longer show in the all > builds > page, but they > still show in the project builds page. > > On the bright side, I know that because I can now > reach > the project builds > page :) so the patch for 7995 works for me. > > Thanks! > > Belén > > > Please review and submit when possible. > > > Cheers, > Alex​ > > > > > -- > Alex Damian > Yocto Project > > SSG / OTC > > > > > > > > > > > > > -- Alex Damian > Yocto Project > > SSG / OTC > > > > > > Can you squash these two: > ba72e1666796987bdec1bbf34d31a41ecf605936 > and 9cce8032cbb70f0047f5819127c0c220963f2ce2 > > > > a125f3ab34a82eb684c46d5f01ee3544535ab5f4 > > > > diff --git > a/lib/toaster/bldcontrol/management/commands/checksettings.py > b/lib/toaster/bldcontrol/management/commands/checksettings.py > index 3858b9e..b2631c4 100644 > --- > a/lib/toaster/bldcontrol/management/commands/checksettings.py > +++ > b/lib/toaster/bldcontrol/management/commands/checksettings.py > @@ -99,10 +99,11 @@ class Command(NoArgsCommand): > # find configuration files > config_files = [] > + selected_dirs = [] > for dirname in > self._recursive_list_directories(be.sourcedir,2): > if os.path.exists(os.path.join(dirname, > ".templateconf")): > import subprocess > - proc = subprocess.Popen('bash -c ". > '+os.path.join(dirname, ".templateconf")+r'; echo > \"$TEMPLATECONF\""', shell=True, stdout=subprocess.PIPE) > + proc = subprocess.Popen('bash -c ". > '+os.path.join(dirname, ".templateconf")+r'; echo > \"\$TEMPLATECONF\""', shell=True, stdout=subprocess.PIPE) > conffilepath, stderroroutput = > proc.communicate() > proc.wait() > if proc.returncode != 0: > @@ -114,6 +115,15 @@ class Command(NoArgsCommand): > continue > if os.path.exists(candidatefilepath): > config_files.append(candidatefilepath) > + selected_dirs.append(dirname) > + > + for dirname in > self._recursive_list_directories(be.sourcedir,2): > > > This for loop seems to be duplicated from the one above it > checksettings.py (line 103 and 120) can they not be combined? > However do we actually need to do all this searching? To > simplify > this couldn't we find "meta-yocto/conf/toasterconf.json" > in the > poky dir, if that doesn't exist then try the openembedded > one, if > that doesn't exist, ask? if people want to specify their own > config we could have a -config option to bin/toaster. > > Thanks, > > Michael > > > > > > > > -- _______________________________________________ > toaster mailing list > toaster@yoctoproject.org > > > https://lists.yoctoproject.org/listinfo/toaster > > > > > -- > Alex Damian > Yocto Project > SSG / OTC > > --------------------------------------------------------------------- > Intel Corporation (UK) Limited > Registered No. 1134945 (England) > Registered Office: Pipers Way, Swindon SN3 1RJ > VAT No: 860 2173 47 > > This e-mail and any attachments may contain confidential > material for > the sole use of the intended recipient(s). Any review or > distribution > by others is strictly prohibited. If you are not the intended > recipient, please contact the sender and delete all copies. > > > --------------------------------------------------------------------- > Intel Corporation (UK) Limited > Registered No. 1134945 (England) > Registered Office: Pipers Way, Swindon SN3 1RJ > VAT No: 860 2173 47 > > This e-mail and any attachments may contain confidential material for > the sole use of the intended recipient(s). Any review or distribution > by others is strictly prohibited. If you are not the intended > recipient, please contact the sender and delete all copies. > > > > > -- > Alex Damian > Yocto Project > SSG / OTC > > --------------------------------------------------------------------- > Intel Corporation (UK) Limited > Registered No. 1134945 (England) > Registered Office: Pipers Way, Swindon SN3 1RJ > VAT No: 860 2173 47 > > This e-mail and any attachments may contain confidential material for > the sole use of the intended recipient(s). Any review or distribution > by others is strictly prohibited. If you are not the intended > recipient, please contact the sender and delete all copies. >