From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56918) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZRn8Y-0003G7-62 for qemu-devel@nongnu.org; Tue, 18 Aug 2015 16:05:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZRn8U-0008Iy-LP for qemu-devel@nongnu.org; Tue, 18 Aug 2015 16:05:33 -0400 Message-ID: <55D39005.1040403@weilnetz.de> Date: Tue, 18 Aug 2015 22:05:25 +0200 From: Stefan Weil MIME-Version: 1.0 References: <1439868498-2740-1-git-send-email-crosthwaite.peter@gmail.com> In-Reply-To: <1439868498-2740-1-git-send-email-crosthwaite.peter@gmail.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] exec-all: Translate TCI return addresses backwards too List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, Peter Crosthwaite , qemu-stable@nongnu.org, Paolo Bonzini , rth@twiddle.net Am 18.08.2015 um 05:28 schrieb Peter Crosthwaite: > This subtraction of return addresses applies directly to TCI as well as > host-TCG. This fixes Linux boots for at least Microblaze, CRIS, ARM and > SH4 when using TCI. > > Reviewed-by: Richard Henderson > Signed-off-by: Peter Crosthwaite > --- > Changed since v1: > Wrote commit message. > --- > include/exec/exec-all.h | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/include/exec/exec-all.h b/include/exec/exec-all.h > index a6fce04..31c2405 100644 > --- a/include/exec/exec-all.h > +++ b/include/exec/exec-all.h > @@ -308,11 +308,7 @@ extern uintptr_t tci_tb_ptr; > to indicate the compressed mode; subtracting two works around that. It > is also the case that there are no host isas that contain a call insn > smaller than 4 bytes, so we don't worry about special-casing this. */ > -#if defined(CONFIG_TCG_INTERPRETER) > -# define GETPC_ADJ 0 > -#else > # define GETPC_ADJ 2 > -#endif > > #define GETPC() (GETRA() - GETPC_ADJ) Who should send the pull request? Me because it is TCI related? I won't be able to send one before next week. I also suggest to remove the indentation which is no longer useful: #define GETPC_ADJ 2 instead of # define GETPC_ADJ 2 Maybe this can be done by the person who requests the pull. Stefan