All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Ahern <dsa@cumulusnetworks.com>
To: Nikolay Aleksandrov <razor@blackwall.org>, netdev@vger.kernel.org
Cc: shm@cumulusnetworks.com, davem@davemloft.net,
	Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Subject: Re: [PATCH net-next v2] vrf: vrf_master_ifindex_rcu is not always called with rcu read lock
Date: Tue, 18 Aug 2015 14:10:16 -0600	[thread overview]
Message-ID: <55D39128.1040804@cumulusnetworks.com> (raw)
In-Reply-To: <1439921754-19715-1-git-send-email-razor@blackwall.org>

On 8/18/15 12:15 PM, Nikolay Aleksandrov wrote:
> diff --git a/include/net/vrf.h b/include/net/vrf.h
> index 3bb4af462ed6..b039850a94a3 100644
> --- a/include/net/vrf.h
> +++ b/include/net/vrf.h
> @@ -34,7 +34,6 @@ struct net_vrf {
>
>
>   #if IS_ENABLED(CONFIG_NET_VRF)
> -/* called with rcu_read_lock() */
>   static inline int vrf_master_ifindex_rcu(const struct net_device *dev)
>   {
>   	struct net_vrf_dev *vrf_ptr;

That comment is true for this version.

David

  reply	other threads:[~2015-08-18 20:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-18 16:17 [PATCH net-next] vrf: vrf_master_ifindex_rcu is not always called with rcu read lock Nikolay Aleksandrov
2015-08-18 18:15 ` [PATCH net-next v2] " Nikolay Aleksandrov
2015-08-18 20:10   ` David Ahern [this message]
2015-08-18 20:24     ` Nikolay Aleksandrov
2015-08-18 18:40 ` [PATCH net-next v3] " Nikolay Aleksandrov
2015-08-19  3:24   ` David Miller
2015-08-18 19:45 ` [PATCH net-next] " David Ahern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55D39128.1040804@cumulusnetworks.com \
    --to=dsa@cumulusnetworks.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=nikolay@cumulusnetworks.com \
    --cc=razor@blackwall.org \
    --cc=shm@cumulusnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.