From: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
To: Michael Neuling <mikey@neuling.org>,
Michael Ellerman <mpe@ellerman.id.au>
Cc: linuxppc-dev@ozlabs.org, imunsie@au1.ibm.com, dja@axtens.net
Subject: Re: [PATCH] cxl: Allow release of contexts which have been OPENED but not STARTED
Date: Wed, 19 Aug 2015 09:10:53 +1000 [thread overview]
Message-ID: <55D3BB7D.9040402@au1.ibm.com> (raw)
In-Reply-To: <1439914990.1628.6.camel@neuling.org>
On 19/08/15 02:23, Michael Neuling wrote:
>> So this doesn't break when you add a new state, is it worth writing it as:
>>
>> if (ctx->status >= STARTED)
>> return -EBUSY;
>>
>> ?
>
> Yeah I think that would be more future proof, although it won't make a
> difference with the current code.
Sounds reasonable, I'll submit a V2.
Andrew
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnellan@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work) IBM Australia Limited
prev parent reply other threads:[~2015-08-18 23:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-18 6:30 [PATCH] cxl: Allow release of contexts which have been OPENED but not STARTED Andrew Donnellan
2015-08-18 6:36 ` Ian Munsie
2015-08-18 9:19 ` Michael Ellerman
2015-08-18 16:23 ` Michael Neuling
2015-08-18 23:10 ` Andrew Donnellan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55D3BB7D.9040402@au1.ibm.com \
--to=andrew.donnellan@au1.ibm.com \
--cc=dja@axtens.net \
--cc=imunsie@au1.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=mikey@neuling.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.