Re: [Qemu-devel] [PATCH RFC 02/11] ide: necessary fields for ATAPI-SCSI bridge added

[Thomas Huth <thuth@redhat.com>]

On 17/08/15 16:42, Alexander Bezzubikov wrote:
> Signed-off-by: Alexander Bezzubikov <abezzubikov@ispras.ru>
> ---
>  hw/ide/internal.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/hw/ide/internal.h b/hw/ide/internal.h
> index f2999ce..3ebc63c 100644
> --- a/hw/ide/internal.h
> +++ b/hw/ide/internal.h
> @@ -429,6 +429,8 @@ struct IDEState {
>      uint8_t *smart_selftest_data;
>      /* AHCI */
>      int ncq_queues;
> +    /* ATAPI-SCSI bridge */
> +    SCSIRequest *cur_req;

Considering that you're extending struct *IDEState* here, I think the
name "cur_req" might be a little bit misleading? Maybe rather name it
"scsi_req" or "atapi_req"?

 Thomas