From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46694) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZS2xG-0004fb-9V for qemu-devel@nongnu.org; Wed, 19 Aug 2015 08:58:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZS2xC-0007EX-9h for qemu-devel@nongnu.org; Wed, 19 Aug 2015 08:58:58 -0400 Received: from mx2.suse.de ([195.135.220.15]:42370) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZS2xC-0007EJ-3j for qemu-devel@nongnu.org; Wed, 19 Aug 2015 08:58:54 -0400 Message-ID: <55D47D8B.9090009@suse.de> Date: Wed, 19 Aug 2015 14:58:51 +0200 From: Hannes Reinecke MIME-Version: 1.0 References: <1439988561-5600-1-git-send-email-abezzubikov@ispras.ru> In-Reply-To: <1439988561-5600-1-git-send-email-abezzubikov@ispras.ru> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH RFC v4 0/5] QEMU ATAPI-SCSI bridge GSoC project List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Bezzubikov , qemu-devel@nongnu.org Cc: jsnow@redhat.com, abezzubikov@ispras.ru On 08/19/2015 02:49 PM, Alexander Bezzubikov wrote: > This is my QEMU Google Summer of Code project. > Here I introduce new device - ATAPI-SCSI bridge. > Its purpose is to unify IDE ATAPI CD-ROM emulation > with SCSI CD-ROM emulation to reduce code duplication and squash bugs. > It's purpose is simple - it just forwards ATAPI commands > to SCSI side for parsing and execution. >=20 > Example of using: > qemu-system-x86_64 \ > -drive if=3Dnone,file=3D,id=3Dcdrom \ > -drive if=3Dnone,id=3Dfake \ > -device ide-bridge,id=3Dbridge,drive=3Dfake \ > -device scsi-cd,drive=3Dcdrom,bus=3Dbridge.0 \ > -hda diskimage \ > -m 1024 >=20 > Alexander Bezzubikov (5): > ide: ATAPI-SCSI bridge TypeInfo and init function created > scsi: SCSIDiskReq declaration moved to header > ide: necessary checks corrected to treat ATAPI-SCSI bridge as CDROM > ATAPI-SCSI bridge functions created an can be used by bridge > ide: ATAPI-SCSI bridge transfer is treated as PIO >=20 > hw/ide/Makefile.objs | 2 +- > hw/ide/atapi.c | 20 ++++++++- > hw/ide/bridge.c | 114 +++++++++++++++++++++++++++++++++++++++++= ++++++++ > hw/ide/bridge.h | 10 +++++ > hw/ide/core.c | 28 +++++++----- > hw/ide/internal.h | 6 ++- > hw/ide/qdev.c | 43 ++++++++++++++++++- > hw/scsi/scsi-disk.c | 55 ++++++++++++++++++------ > include/hw/scsi/scsi.h | 16 +++++++ > 9 files changed, 267 insertions(+), 27 deletions(-) > create mode 100644 hw/ide/bridge.c > create mode 100644 hw/ide/bridge.h >=20 Very nice patchset. Thanks a lot for doing that. For the entire series: Acked-by: Hannes Reinecke Cheers, Hannes --=20 Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N=FCrnberg GF: F. Imend=F6rffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG N=FCrnberg)