From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tetsuya Mukawa Subject: Re: [PATCH v1] Return ENOMEM during mpipe_devinit failure Date: Thu, 20 Aug 2015 11:07:05 +0900 Message-ID: <55D53649.7040901@igel.co.jp> References: <1440014407-3233-1-git-send-email-rkerur@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-2022-jp Content-Transfer-Encoding: 7bit To: Ravi Kerur , "dev@dpdk.org" Return-path: Received: from mail-pa0-f53.google.com (mail-pa0-f53.google.com [209.85.220.53]) by dpdk.org (Postfix) with ESMTP id 9C80E5A0F for ; Thu, 20 Aug 2015 04:07:09 +0200 (CEST) Received: by padfo6 with SMTP id fo6so9867466pad.0 for ; Wed, 19 Aug 2015 19:07:08 -0700 (PDT) In-Reply-To: <1440014407-3233-1-git-send-email-rkerur@gmail.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2015/08/20 5:00, Ravi Kerur wrote: > In function rte_pmd_mpipe_devinit, if rte_eth_dev_allocate > fails return error which is inline with other drivers. > > Signed-off-by: Ravi Kerur > --- > drivers/net/mpipe/mpipe_tilegx.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/mpipe/mpipe_tilegx.c b/drivers/net/mpipe/mpipe_tilegx.c > index 743feef..6e3e304 100644 > --- a/drivers/net/mpipe/mpipe_tilegx.c > +++ b/drivers/net/mpipe/mpipe_tilegx.c > @@ -1582,6 +1582,7 @@ rte_pmd_mpipe_devinit(const char *ifname, > if (!eth_dev) { > RTE_LOG(ERR, PMD, "%s: Failed to allocate device.\n", ifname); > rte_free(priv); > + return -ENOMEM; > } > > RTE_LOG(INFO, PMD, "%s: Initialized mpipe device" Acked-by: Tetsuya Mukawa