From mboxrd@z Thu Jan 1 00:00:00 1970 From: Archit Taneja Subject: Re: [PATCH v3 0/14] Add Analogix Core Display Port Driver Date: Thu, 20 Aug 2015 09:59:49 +0530 Message-ID: <55D557BD.8070004@codeaurora.org> References: <1439995728-18046-1-git-send-email-ykk@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1439995728-18046-1-git-send-email-ykk@rock-chips.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Yakir Yang , Heiko Stuebner , Thierry Reding , Jingoo Han , Fabio Estevam , Inki Dae , joe@perches.com, Russell King Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Vincent Palatin , Pawel Moll , seanpaul@google.com, linux-rockchip@lists.infradead.org, Ian Campbell , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Kishon Vijay Abraham I , Andrzej Hajda , Kyungmin Park , Rob Herring , djkurtz@google.com, Kumar Gala , ajaynumb@gmail.com, Andy Yan , dianders@google.com, Gustavo Padovan , linux-arm-kernel@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org SGksCgpPbiAwOC8xOS8yMDE1IDA4OjE4IFBNLCBZYWtpciBZYW5nIHdyb3RlOgo+Cj4gSGkgYWxs LAo+ICAgICBUaGUgU2Ftc3VuZyBFeHlub3MgZURQIGNvbnRyb2xsZXIgYW5kIFJvY2tjaGlwIFJL MzI4OCBlRFAgY29udHJvbGxlcgo+IHNoYXJlIHRoZSBzYW1lIElQLCBzbyBhIGxvdCBvZiBwYXJ0 cyBjYW4gYmUgcmUtdXNlZC4gSSBzcGxpdCB0aGUgY29tbW9uCj4gY29kZSBpbnRvIGJyaWRnZSBk aXJlY3RvcnksIHRoZW4gcmszMjg4IGFuZCBleHlub3Mgb25seSBuZWVkIHRvIGtlZXAKPiBzb21l IHBsYXRmb3JtIGNvZGUuIENhdXNlIEkgY2FuJ3QgZmluZCB0aGUgZXhhY3QgSVAgbmFtZSBvZiBl eHlub3MgZHAKPiBjb250cm9sbGVyLCBzbyBJIGRlY2lkZSB0byBuYW1lIGRwIGNvcmUgZHJpdmVy IHdpdGggImFuYWxvZ2l4IiB3aGljaCBJCj4gZmluZCBpbiByazMyODggZURQIFRSTSA7KQo+Cj4g QmV5b25kIHRoYXQsIHRoZXJlIGFyZSB0aHJlZSBsaWdodCByZWdpc3RlcnMgc2V0dGluZyBkaWZm ZXJlbnRzIGJld3RlZW4KPiBleHlub3MgYW5kIHJrMzI4OC4KPiAxLiBSSzMyODggaGF2ZSBmaXZl IHNwZWNpYWwgcGxsIHJlc2lndGVycyB3aGljaCBub3QgaW5kaWNhdGEgaW4gZXh5bm9zCj4gICAg IGRwIGNvbnRyb2xsZXIuCj4gMi4gVGhlIGFkZHJlc3Mgb2YgRFBfUEhZX1BEKGRwIHBoeSBwb3dl ciBtYW5hZ2VyIHJlZ2lzdGVyKSBhcmUgZGlmZmVyZW50Cj4gICAgIGJldHdlZW4gcmszMjg4IGFu ZCBleHlub3MuCj4gMy4gUmszMjg4IGFuZCBleHlub3MgaGF2ZSBkaWZmZXJlbnQgc2V0dGluZyB3 aXRoIEFVWF9IV19SRVRSWV9DVEwoZHAgZGVidWcKPiAgICAgcmVnaXN0ZXIpLgo+Cj4gSSBoYXZl IHZlcmlmaWVkIHRoaXMgc2VyaWVzIG9uIHR3byBraW5kcyBvZiByb2NrY2hpcCBwbGF0Zm9ybSBi b2FyZCwgb25lCj4gaXMgcmszMjg4IHNkayBib2FyZCB3aGljaCBjb25uZWN0IHdpdGggYSAySyBk aXNwbGF5IHBvcnQgbW9uaXRvciwgdGhlIG90aGVyCj4gaXMgZ29vZ2xlIGplcnJ5IGNocm9tZWJv b2sgd2hpY2ggY29ubmVjdCB3aXRoIGEgZURQIHNjcmVlbiAiY25tLG4xMTZiZ2VlYTIiLAo+IGJv dGggb2YgdGhlbSB3b3JrcyByaWdodGxseS4KPgo+IEkgaGF2ZW4ndCB2ZXJpZmllZCB0aGUgZHAg ZnVuY3Rpb24gb24gc2Ftc3VuZyBwbGF0Zm9ybSwgY2F1c2UgSSBoYXZlbid0IGdvdAo+IGV4eW5v cyBib2FyZHMuIEkgY2FuIG9ubHkgZW5zdXJlIHRoYXQgdGhlcmUgYXJlIG5vIGJ1aWxkIGVycm9y IG9uIHNhbXN1bmcKPiBwbGF0Zm9ybSwgd2lzaCBzb21lIHNhbXN1bmcgZ3V5cyBoZWxwIHRvIHRl c3QuIDspCj4KPiBUaGFua3MsCj4gLSBZYWtpcgo+Cj4gQ2hhbmdlcyBpbiB2MzoKPiAtIFRha2Ug VGhpZXJyeSBSZWRpbmcgc3VnZ2VzdCwgbW92ZSBleHlub3MncyB2aWRlb190aW1pbmcgY29kZQo+ ICAgIHRvIGFuYWxvZ2l4X2RwLWV4eW5vcyBwbGF0Zm9ybSBkcml2ZXIsIGFkZCBnZXRfbW9kZXMg bWV0aG9kCj4gICAgdG8gc3RydWN0IGFuYWxvZ2l4X2RwX3BsYXRfZGF0YS4KPiAtIFRha2UgSGVp a28gc3VnZ2VzdCwgcmVuYW1lIHNvbWUgInNhbXN1bmcqIiBkdHMgcHJvcGVyeSB0byAiYW5hbG9n aXgqIi4KPiAtIFRha2UgVGhpZXJyeSBSZWRpbmcgc3VnZ2VzdCwgZHluYW1pYyBwYXJzZSB2aWRl byB0aW1pbmcgaW5mbyBmcm9tCj4gICAgc3RydWN0IGRybV9kaXNwbGF5X21vZGUgYW5kIHN0cnVj dCBkcm1fZGlzcGxheV9pbmZvLgo+IC0gVGFrZSBUaGllcnJ5IFJlZGluZyBzdWdnZXN0LCBsaW5r X3JhdGUgYW5kIGxhbmVfY291bnQgc2hvdWxkbid0IGNvbmZpZyB0bwo+ICAgIHRoZSBEVCBwcm9w ZXJ0eSB2YWx1ZSBkaXJlY3RseSwgYnV0IHdlIGNhbiB0YWtlIHRob3NlIGFzIGhhcmR3YXJlIGxp bWl0ZS4KPiAgICBGb3IgZXhhbXBsZSwgUkszMjg4IG9ubHkgc3VwcG9ydCA0IHBoeXNpY2FsIGxh bmVzIG9mIDIuNy8xLjYyIEdicHMvbGFuZSwKPiAgICBzbyBEVCBwcm9wZXJ0eSB3b3VsZCBsaWtl ICJsaW5rLXJhdGUgPSAweDBhIiAibGFuZS1jb3VudCA9IDQiLgo+IC0gVGFrZSBIZWlrbyBzdWdn ZXN0LCBhZGQgZGV2aWNldHJlZSBiaW5kaW5nIGRvY3VtZW50cy4KPiAtIFRha2UgVGhpZXJyeSBS ZWRpbmcgc3VnZ2VzdCwgcmVtb3ZlIHN5bmMgcG9sICYgY29sb3JpbWV0cnkgcHJvcGVyaWVzCj4g ICAgZnJvbSB0aGUgbmV3IGFuYWxvZ2l4IGRwIGRyaXZlciBkZXZpY2V0cmVlIGJpbmRpbmcuCj4g LSBVcGRhdGUgdGhlIGV4aXN0IGV4eW5vcyBkdHNpIGZpbGUgd2l0aCB0aGUgbGF0ZXN0IERQIERU IHByb3Blcmllcy4KPiAtIFRha2UgVGhpZXJyeSBSZWRpbmcgYW5kIEhlaWtvIHN1Z2dlc3QsIGxl YXZlICJzY2xrX2VkcF8yNG0iIHRvIHJvY2tjaGlwCj4gICAgZHAgcGh5IGRyaXZlciB3aGljaCBu YW1lIHRvICIyNG0iLCBhbmQgbGVhdmUgInNjbGtfZWRwIiB0byBhbmFsb2dpeCBkcAo+ICAgIGNv cmUgZHJpdmVyIHdoaWNoIG5hbWUgdG8gImRwIiwgYW5kIGxlYXZlICJwY2xrX2VkcCIgdG8gcm9j a2NoaXAgZHAgcGxhdGZvcm0KPiAgICBkcml2ZXIgd2hpY2ggbmFtZSB0byAicGNsayIuCj4gLSBU YWtlIEhlaWtvIHN1Z2dlc3QsIGFkZCBkZXZpY2V0cmVlIGJpbmRpbmcgZG9jdW1lbnQuCj4gLSBU YWtlIEhlaWtvIHN1Z2dlc3QsIHJlbW92ZSAicm9ja2NoaXAscGFuZWwiIERUIHByb3BlcnR5LCB0 YWtlIHVzZSBvZiByZW1vdGUKPiAgICBwb2ludCB0byBnZXQgcGFuZWwgbm9kZS4KPiAtIEFkZCB0 aGUgbmV3IGZ1bmN0aW9uIHBvaW50IGFuYWxvZ2l4X2RwX3BsYXRkYXRhLmdldF9tb2RlcyBpbml0 Lgo+IC0gVGFrZSBIZWlrbyBzdWdnZXN0LCBhZGQgcm9ja2NoaXAgZHAgcGh5IGRyaXZlciwKPiAg ICBjb2xsZWN0IHRoZSBwaHkgY2xvY2tzIGFuZCBwb3dlciBjb250cm9sLgo+IC0gQWRkICJhbmFs b2dpeCxuZWVkLWZvcmNlLWhwZCIgdG8gaW5kaWNhdGUgd2hldGhlciBkcml2ZXIgbmVlZCBmb2Nl Cj4gICAgaHBkIHdoZW4gaHBkIGRldGVjdCBmYWlsZWQuCj4gLSBtb3ZlIGRwIGhwZCBkZXRlY3Qg dG8gY29ubmVjdG9yIGRldGVjdCBmdW5jdGlvbi4KPiAtIEFkZCBlZGlkIG1vZGVzIHBhcnNlIHN1 cHBvcnQKPgo+IENoYW5nZXMgaW4gdjI6Cj4gLSBUYWtlIEpvZSBQcmVjaGVzIGFkdmlzZSwgaW1w cm92ZWQgY29tbWl0IG1lc3NhZ2UgbW9yZSByZWFkYWJsZSwgYW5kCj4gICAgYXZvaWQgdXNpbmcg c29tZSB1bmNvbW1vbiBzdHlsZSBsaWtlIGJlbGxvdzoKPiAgICAtICByZXR2YWwgPSBleHlub3Nf ZHBfcmVhZF9ieXRlc19mcm9tX2kyYyguLi4KPiAJCQkJLi4uKQo+ICAgICsgIHJldHZhbCA9Cj4g ICAgKyAgZXh5bm9zX2RwX3JlYWRfYnl0ZXNfZnJvbV9pMmMoLi4uLi4uKTsKPiAtIFRha2UgSmlu Z29vIEhhbiBzdWdnZXN0LCBqdXN0IHJlbW92ZSBteSBuYW1lIGZyb20gYXV0aG9yIGxpc3QuCj4g LSBUYWtlIEppbmdvbyBIYW4gc3VnZ2VzdCwgcmVtb3ZlIG5ldyBjb3B5cmlnaHQKPiAtIEZpeCBj b21waWxlZCBmYWlsZWQgZHV0IHRvIGFuYWxvZ2l4X2RwX2RldmljZSBtaXNzcGVsbAo+IC0gVGFr ZSBIZWlrbyBzdWdnZXN0LCBnZXQgcGFuZWwgbm9kZSB3aXRoIHJlbW90ZS1lbmRwb2ludCBtZXRo b2QsCj4gICAgYW5kIGNyZWF0ZSBkZXZpY2V0cmVlIGJpbmRpbmcgZm9yIGRyaXZlci4KPiAtIFJl bW92ZSB0aGUgY2xvY2sgZW5hYmxlL2Rpc2JhbGUgd2l0aCAic2Nsa19lZHAiICYgInNjbGtfZWRw XzI0bSIsCj4gICAgbGVhdmUgdGhvc2UgY2xvY2sgdG8gcm9ja2NoaXAgZHAgcGh5IGRyaXZlci4K PiAtIEFkZCBHTlUgbGljZW5zZSB2MiBkZWNsYXJlZCBhbmQgc2Ftc3VuZyBjb3B5cmlnaHQKPiAt IEZpeCBjb21waWxlIGZhaWxlZCBkdXQgdG8gcGh5X3BkX2FkZHIgdmFyaWFibGUgbWlzc3BlbGwg ZXJyb3IKPgo+IFlha2lyIFlhbmcgKDE0KToKPiAgICBkcm06IGV4eW5vcy9kcDogZml4IGNvZGUg c3R5bGUKPiAgICBkcm06IGV4eW5vcy9kcDogY29udmVydCB0byBkcm0gYnJpZGdlIG1vZGUKPiAg ICBkcm06IGJyaWRnZTogYW5hbG9naXhfZHA6IHNwbGl0IGV4eW5vcyBkcCBkcml2ZXIgdG8gYnJp ZGdlIGRpcgo+ICAgIGRybTogYnJpZGdlL2FuYWxvZ2l4X2RwOiBkeW5hbWljIHBhcnNlIHN5bmNf cG9sICYgaW50ZXJsYWNlICYKPiAgICAgIGNvbG9yaW1ldHJ5Cj4gICAgZHJtOiBicmlkZ2UvYW5h bG9naXhfZHA6IGZpeCBsaW5rX3JhdGUgJiBsYW5lX2NvdW50IGJ1Zwo+ICAgIERvY3VtZW50YXRp b246IGRybS9icmlkZ2U6IGFkZCBkb2N1bWVudCBmb3IgYW5hbG9naXhfZHAKPiAgICBkcm06IHJv Y2tjaGlwL2RwOiBhZGQgcm9ja2NoaXAgcGxhdGZvcm0gZHAgZHJpdmVyCj4gICAgcGh5OiBBZGQg ZHJpdmVyIGZvciByb2NrY2hpcCBEaXNwbGF5IFBvcnQgUEhZCj4gICAgZHJtOiBicmlkZ2UvYW5h bG9naXhfZHA6IGFkZCBwbGF0Zm9ybSBkZXZpY2UgdHlwZSBzdXBwb3J0Cj4gICAgZHJtOiBicmlk Z2U6IGFuYWxvZ2l4X2RwOiBhZGQgc29tZSByazMyODggc3BlY2lhbCByZWdpc3RlcnMgc2V0dGlu Zwo+ICAgIGRybTogYnJpZGdlOiBhbmFsb2dpeF9kcDogdHJ5IGZvcmNlIGhwZCBhZnRlciBwbHVn IGluIGxvb2t1cCBmYWlsZWQKPiAgICBkcm06IGJyaWRnZS9hbmFsb2dpeF9kcDogZXhwYW5kIHRo ZSBkZWxheSB0aW1lIGZvciBocGQgZGV0ZWN0Cj4gICAgZHJtOiBicmlkZ2UvYW5hbG9naXhfZHA6 IG1vdmUgaHBkIGRldGVjdCB0byBjb25uZWN0b3IgZGV0ZWN0IGZ1bmN0aW9uCj4gICAgZHJtOiBi cmlkZ2UvYW5hbG9naXhfZHA6IGFkZCBlZGlkIG1vZGVzIHBhcnNlIGluIGdldF9tb2RlcyBtZXRo b2QKPgo+ICAgLi4uL2RldmljZXRyZWUvYmluZGluZ3MvZHJtL2JyaWRnZS9hbmFsb2dpeF9kcC50 eHQgfCAgIDczICsKPiAgIC4uLi9kZXZpY2V0cmVlL2JpbmRpbmdzL3BoeS9yb2NrY2hpcC1kcC1w aHkudHh0ICAgIHwgICAyNiArCj4gICAuLi4vYmluZGluZ3MvdmlkZW8vYW5hbG9naXhfZHAtcm9j a2NoaXAudHh0ICAgICAgICB8ICAgODMgKysKPiAgIC4uLi9kZXZpY2V0cmVlL2JpbmRpbmdzL3Zp ZGVvL2V4eW5vc19kcC50eHQgICAgICAgIHwgICA1MSArLQo+ICAgYXJjaC9hcm0vYm9vdC9kdHMv ZXh5bm9zNTI1MC1hcm5kYWxlLmR0cyAgICAgICAgICAgfCAgIDEwICstCj4gICBhcmNoL2FybS9i b290L2R0cy9leHlub3M1MjUwLXNtZGs1MjUwLmR0cyAgICAgICAgICB8ICAgMTAgKy0KPiAgIGFy Y2gvYXJtL2Jvb3QvZHRzL2V4eW5vczUyNTAtc25vdy5kdHMgICAgICAgICAgICAgIHwgICAxMiAr LQo+ICAgYXJjaC9hcm0vYm9vdC9kdHMvZXh5bm9zNTI1MC1zcHJpbmcuZHRzICAgICAgICAgICAg fCAgIDEyICstCj4gICBhcmNoL2FybS9ib290L2R0cy9leHlub3M1NDIwLXBlYWNoLXBpdC5kdHMg ICAgICAgICB8ICAgMTIgKy0KPiAgIGFyY2gvYXJtL2Jvb3QvZHRzL2V4eW5vczU0MjAtc21kazU0 MjAuZHRzICAgICAgICAgIHwgICAxMCArLQo+ICAgYXJjaC9hcm0vYm9vdC9kdHMvZXh5bm9zNTgw MC1wZWFjaC1waS5kdHMgICAgICAgICAgfCAgIDEyICstCj4gICBkcml2ZXJzL2dwdS9kcm0vYnJp ZGdlL0tjb25maWcgICAgICAgICAgICAgICAgICAgICB8ICAgIDUgKwo+ICAgZHJpdmVycy9ncHUv ZHJtL2JyaWRnZS9NYWtlZmlsZSAgICAgICAgICAgICAgICAgICAgfCAgICAxICsKPiAgIGRyaXZl cnMvZ3B1L2RybS9icmlkZ2UvYW5hbG9naXhfZHBfY29yZS5jICAgICAgICAgIHwgMTM4MiArKysr KysrKysrKysrKysrKysrCj4gICBkcml2ZXJzL2dwdS9kcm0vYnJpZGdlL2FuYWxvZ2l4X2RwX2Nv cmUuaCAgICAgICAgICB8ICAyODYgKysrKwo+ICAgZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9hbmFs b2dpeF9kcF9yZWcuYyAgICAgICAgICAgfCAxMjk0ICsrKysrKysrKysrKysrKysrKwo+ICAgLi4u L2V4eW5vc19kcF9yZWcuaCA9PiBicmlkZ2UvYW5hbG9naXhfZHBfcmVnLmh9ICAgfCAgMjcwICsr LS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9leHlub3MvS2NvbmZpZyAgICAgICAgICAgICAgICAgICAg IHwgICAgNSArLQo+ICAgZHJpdmVycy9ncHUvZHJtL2V4eW5vcy9NYWtlZmlsZSAgICAgICAgICAg ICAgICAgICAgfCAgICAyICstCj4gICBkcml2ZXJzL2dwdS9kcm0vZXh5bm9zL2FuYWxvZ2l4X2Rw LWV4eW5vcy5jICAgICAgICB8ICAzNDcgKysrKysKPiAgIGRyaXZlcnMvZ3B1L2RybS9leHlub3Mv ZXh5bm9zX2RwX2NvcmUuYyAgICAgICAgICAgIHwgMTQxNiAtLS0tLS0tLS0tLS0tLS0tLS0tLQo+ ICAgZHJpdmVycy9ncHUvZHJtL2V4eW5vcy9leHlub3NfZHBfY29yZS5oICAgICAgICAgICAgfCAg MjgyIC0tLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9leHlub3MvZXh5bm9zX2RwX3JlZy5jICAgICAg ICAgICAgIHwgMTI2MyAtLS0tLS0tLS0tLS0tLS0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL3JvY2tj aGlwL0tjb25maWcgICAgICAgICAgICAgICAgICAgfCAgICA5ICsKPiAgIGRyaXZlcnMvZ3B1L2Ry bS9yb2NrY2hpcC9NYWtlZmlsZSAgICAgICAgICAgICAgICAgIHwgICAgMSArCj4gICBkcml2ZXJz L2dwdS9kcm0vcm9ja2NoaXAvYW5hbG9naXhfZHAtcm9ja2NoaXAuYyAgICB8ICAzOTAgKysrKysr Cj4gICBkcml2ZXJzL3BoeS9LY29uZmlnICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8 ICAgIDcgKwo+ICAgZHJpdmVycy9waHkvTWFrZWZpbGUgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgfCAgICAxICsKPiAgIGRyaXZlcnMvcGh5L3BoeS1yb2NrY2hpcC1kcC5jICAgICAgICAg ICAgICAgICAgICAgIHwgIDE4NSArKysKPiAgIGluY2x1ZGUvZHJtL2JyaWRnZS9hbmFsb2dpeF9k cC5oICAgICAgICAgICAgICAgICAgIHwgICA0MCArCj4gICAzMCBmaWxlcyBjaGFuZ2VkLCA0MzI1 IGluc2VydGlvbnMoKyksIDMxNzIgZGVsZXRpb25zKC0pCj4gICBjcmVhdGUgbW9kZSAxMDA2NDQg RG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2RybS9icmlkZ2UvYW5hbG9naXhfZHAu dHh0Cj4gICBjcmVhdGUgbW9kZSAxMDA2NDQgRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRp bmdzL3BoeS9yb2NrY2hpcC1kcC1waHkudHh0Cj4gICBjcmVhdGUgbW9kZSAxMDA2NDQgRG9jdW1l bnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3ZpZGVvL2FuYWxvZ2l4X2RwLXJvY2tjaGlwLnR4 dAo+ICAgY3JlYXRlIG1vZGUgMTAwNjQ0IGRyaXZlcnMvZ3B1L2RybS9icmlkZ2UvYW5hbG9naXhf ZHBfY29yZS5jCj4gICBjcmVhdGUgbW9kZSAxMDA2NDQgZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9h bmFsb2dpeF9kcF9jb3JlLmgKPiAgIGNyZWF0ZSBtb2RlIDEwMDY0NCBkcml2ZXJzL2dwdS9kcm0v YnJpZGdlL2FuYWxvZ2l4X2RwX3JlZy5jCgpNaW5vciBjb21tZW50OiBTaW5jZSB0aGVyZSBhcmUg YSBmZXcgZmlsZXMgcmVxdWlyZWQgZm9yIHRoZSBkcml2ZXIsCmNvdWxkIHlvdSBjcmVhdGUgYSBz ZXBhcmF0ZSBmb2xkZXIgd2l0aGluIGRyaXZlcnMvZ3B1L2RybS9icmlkZ2U/CgpUaGFua3MsCkFy Y2hpdAoKLS0gClF1YWxjb21tIElubm92YXRpb24gQ2VudGVyLCBJbmMuIGlzIGEgbWVtYmVyIG9m IENvZGUgQXVyb3JhIEZvcnVtLAphIExpbnV4IEZvdW5kYXRpb24gQ29sbGFib3JhdGl2ZSBQcm9q ZWN0Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1k ZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: architt@codeaurora.org (Archit Taneja) Date: Thu, 20 Aug 2015 09:59:49 +0530 Subject: [PATCH v3 0/14] Add Analogix Core Display Port Driver In-Reply-To: <1439995728-18046-1-git-send-email-ykk@rock-chips.com> References: <1439995728-18046-1-git-send-email-ykk@rock-chips.com> Message-ID: <55D557BD.8070004@codeaurora.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On 08/19/2015 08:18 PM, Yakir Yang wrote: > > Hi all, > The Samsung Exynos eDP controller and Rockchip RK3288 eDP controller > share the same IP, so a lot of parts can be re-used. I split the common > code into bridge directory, then rk3288 and exynos only need to keep > some platform code. Cause I can't find the exact IP name of exynos dp > controller, so I decide to name dp core driver with "analogix" which I > find in rk3288 eDP TRM ;) > > Beyond that, there are three light registers setting differents bewteen > exynos and rk3288. > 1. RK3288 have five special pll resigters which not indicata in exynos > dp controller. > 2. The address of DP_PHY_PD(dp phy power manager register) are different > between rk3288 and exynos. > 3. Rk3288 and exynos have different setting with AUX_HW_RETRY_CTL(dp debug > register). > > I have verified this series on two kinds of rockchip platform board, one > is rk3288 sdk board which connect with a 2K display port monitor, the other > is google jerry chromebook which connect with a eDP screen "cnm,n116bgeea2", > both of them works rightlly. > > I haven't verified the dp function on samsung platform, cause I haven't got > exynos boards. I can only ensure that there are no build error on samsung > platform, wish some samsung guys help to test. ;) > > Thanks, > - Yakir > > Changes in v3: > - Take Thierry Reding suggest, move exynos's video_timing code > to analogix_dp-exynos platform driver, add get_modes method > to struct analogix_dp_plat_data. > - Take Heiko suggest, rename some "samsung*" dts propery to "analogix*". > - Take Thierry Reding suggest, dynamic parse video timing info from > struct drm_display_mode and struct drm_display_info. > - Take Thierry Reding suggest, link_rate and lane_count shouldn't config to > the DT property value directly, but we can take those as hardware limite. > For example, RK3288 only support 4 physical lanes of 2.7/1.62 Gbps/lane, > so DT property would like "link-rate = 0x0a" "lane-count = 4". > - Take Heiko suggest, add devicetree binding documents. > - Take Thierry Reding suggest, remove sync pol & colorimetry properies > from the new analogix dp driver devicetree binding. > - Update the exist exynos dtsi file with the latest DP DT properies. > - Take Thierry Reding and Heiko suggest, leave "sclk_edp_24m" to rockchip > dp phy driver which name to "24m", and leave "sclk_edp" to analogix dp > core driver which name to "dp", and leave "pclk_edp" to rockchip dp platform > driver which name to "pclk". > - Take Heiko suggest, add devicetree binding document. > - Take Heiko suggest, remove "rockchip,panel" DT property, take use of remote > point to get panel node. > - Add the new function point analogix_dp_platdata.get_modes init. > - Take Heiko suggest, add rockchip dp phy driver, > collect the phy clocks and power control. > - Add "analogix,need-force-hpd" to indicate whether driver need foce > hpd when hpd detect failed. > - move dp hpd detect to connector detect function. > - Add edid modes parse support > > Changes in v2: > - Take Joe Preches advise, improved commit message more readable, and > avoid using some uncommon style like bellow: > - retval = exynos_dp_read_bytes_from_i2c(... > ...) > + retval = > + exynos_dp_read_bytes_from_i2c(......); > - Take Jingoo Han suggest, just remove my name from author list. > - Take Jingoo Han suggest, remove new copyright > - Fix compiled failed dut to analogix_dp_device misspell > - Take Heiko suggest, get panel node with remote-endpoint method, > and create devicetree binding for driver. > - Remove the clock enable/disbale with "sclk_edp" & "sclk_edp_24m", > leave those clock to rockchip dp phy driver. > - Add GNU license v2 declared and samsung copyright > - Fix compile failed dut to phy_pd_addr variable misspell error > > Yakir Yang (14): > drm: exynos/dp: fix code style > drm: exynos/dp: convert to drm bridge mode > drm: bridge: analogix_dp: split exynos dp driver to bridge dir > drm: bridge/analogix_dp: dynamic parse sync_pol & interlace & > colorimetry > drm: bridge/analogix_dp: fix link_rate & lane_count bug > Documentation: drm/bridge: add document for analogix_dp > drm: rockchip/dp: add rockchip platform dp driver > phy: Add driver for rockchip Display Port PHY > drm: bridge/analogix_dp: add platform device type support > drm: bridge: analogix_dp: add some rk3288 special registers setting > drm: bridge: analogix_dp: try force hpd after plug in lookup failed > drm: bridge/analogix_dp: expand the delay time for hpd detect > drm: bridge/analogix_dp: move hpd detect to connector detect function > drm: bridge/analogix_dp: add edid modes parse in get_modes method > > .../devicetree/bindings/drm/bridge/analogix_dp.txt | 73 + > .../devicetree/bindings/phy/rockchip-dp-phy.txt | 26 + > .../bindings/video/analogix_dp-rockchip.txt | 83 ++ > .../devicetree/bindings/video/exynos_dp.txt | 51 +- > arch/arm/boot/dts/exynos5250-arndale.dts | 10 +- > arch/arm/boot/dts/exynos5250-smdk5250.dts | 10 +- > arch/arm/boot/dts/exynos5250-snow.dts | 12 +- > arch/arm/boot/dts/exynos5250-spring.dts | 12 +- > arch/arm/boot/dts/exynos5420-peach-pit.dts | 12 +- > arch/arm/boot/dts/exynos5420-smdk5420.dts | 10 +- > arch/arm/boot/dts/exynos5800-peach-pi.dts | 12 +- > drivers/gpu/drm/bridge/Kconfig | 5 + > drivers/gpu/drm/bridge/Makefile | 1 + > drivers/gpu/drm/bridge/analogix_dp_core.c | 1382 +++++++++++++++++++ > drivers/gpu/drm/bridge/analogix_dp_core.h | 286 ++++ > drivers/gpu/drm/bridge/analogix_dp_reg.c | 1294 ++++++++++++++++++ > .../exynos_dp_reg.h => bridge/analogix_dp_reg.h} | 270 ++-- > drivers/gpu/drm/exynos/Kconfig | 5 +- > drivers/gpu/drm/exynos/Makefile | 2 +- > drivers/gpu/drm/exynos/analogix_dp-exynos.c | 347 +++++ > drivers/gpu/drm/exynos/exynos_dp_core.c | 1416 -------------------- > drivers/gpu/drm/exynos/exynos_dp_core.h | 282 ---- > drivers/gpu/drm/exynos/exynos_dp_reg.c | 1263 ----------------- > drivers/gpu/drm/rockchip/Kconfig | 9 + > drivers/gpu/drm/rockchip/Makefile | 1 + > drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 390 ++++++ > drivers/phy/Kconfig | 7 + > drivers/phy/Makefile | 1 + > drivers/phy/phy-rockchip-dp.c | 185 +++ > include/drm/bridge/analogix_dp.h | 40 + > 30 files changed, 4325 insertions(+), 3172 deletions(-) > create mode 100644 Documentation/devicetree/bindings/drm/bridge/analogix_dp.txt > create mode 100644 Documentation/devicetree/bindings/phy/rockchip-dp-phy.txt > create mode 100644 Documentation/devicetree/bindings/video/analogix_dp-rockchip.txt > create mode 100644 drivers/gpu/drm/bridge/analogix_dp_core.c > create mode 100644 drivers/gpu/drm/bridge/analogix_dp_core.h > create mode 100644 drivers/gpu/drm/bridge/analogix_dp_reg.c Minor comment: Since there are a few files required for the driver, could you create a separate folder within drivers/gpu/drm/bridge? Thanks, Archit -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751250AbbHTEaF (ORCPT ); Thu, 20 Aug 2015 00:30:05 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:60047 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750789AbbHTEaB (ORCPT ); Thu, 20 Aug 2015 00:30:01 -0400 Message-ID: <55D557BD.8070004@codeaurora.org> Date: Thu, 20 Aug 2015 09:59:49 +0530 From: Archit Taneja User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Yakir Yang , Heiko Stuebner , Thierry Reding , Jingoo Han , Fabio Estevam , Inki Dae , joe@perches.com, Russell King CC: seanpaul@google.com, dri-devel@lists.freedesktop.org, Andrzej Hajda , Gustavo Padovan , linux-samsung-soc@vger.kernel.org, Vincent Palatin , linux-rockchip@lists.infradead.org, Kishon Vijay Abraham I , devicetree@vger.kernel.org, Pawel Moll , Ian Campbell , dianders@google.com, Rob Herring , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Kyungmin Park , djkurtz@google.com, Kumar Gala , ajaynumb@gmail.com, Andy Yan Subject: Re: [PATCH v3 0/14] Add Analogix Core Display Port Driver References: <1439995728-18046-1-git-send-email-ykk@rock-chips.com> In-Reply-To: <1439995728-18046-1-git-send-email-ykk@rock-chips.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 08/19/2015 08:18 PM, Yakir Yang wrote: > > Hi all, > The Samsung Exynos eDP controller and Rockchip RK3288 eDP controller > share the same IP, so a lot of parts can be re-used. I split the common > code into bridge directory, then rk3288 and exynos only need to keep > some platform code. Cause I can't find the exact IP name of exynos dp > controller, so I decide to name dp core driver with "analogix" which I > find in rk3288 eDP TRM ;) > > Beyond that, there are three light registers setting differents bewteen > exynos and rk3288. > 1. RK3288 have five special pll resigters which not indicata in exynos > dp controller. > 2. The address of DP_PHY_PD(dp phy power manager register) are different > between rk3288 and exynos. > 3. Rk3288 and exynos have different setting with AUX_HW_RETRY_CTL(dp debug > register). > > I have verified this series on two kinds of rockchip platform board, one > is rk3288 sdk board which connect with a 2K display port monitor, the other > is google jerry chromebook which connect with a eDP screen "cnm,n116bgeea2", > both of them works rightlly. > > I haven't verified the dp function on samsung platform, cause I haven't got > exynos boards. I can only ensure that there are no build error on samsung > platform, wish some samsung guys help to test. ;) > > Thanks, > - Yakir > > Changes in v3: > - Take Thierry Reding suggest, move exynos's video_timing code > to analogix_dp-exynos platform driver, add get_modes method > to struct analogix_dp_plat_data. > - Take Heiko suggest, rename some "samsung*" dts propery to "analogix*". > - Take Thierry Reding suggest, dynamic parse video timing info from > struct drm_display_mode and struct drm_display_info. > - Take Thierry Reding suggest, link_rate and lane_count shouldn't config to > the DT property value directly, but we can take those as hardware limite. > For example, RK3288 only support 4 physical lanes of 2.7/1.62 Gbps/lane, > so DT property would like "link-rate = 0x0a" "lane-count = 4". > - Take Heiko suggest, add devicetree binding documents. > - Take Thierry Reding suggest, remove sync pol & colorimetry properies > from the new analogix dp driver devicetree binding. > - Update the exist exynos dtsi file with the latest DP DT properies. > - Take Thierry Reding and Heiko suggest, leave "sclk_edp_24m" to rockchip > dp phy driver which name to "24m", and leave "sclk_edp" to analogix dp > core driver which name to "dp", and leave "pclk_edp" to rockchip dp platform > driver which name to "pclk". > - Take Heiko suggest, add devicetree binding document. > - Take Heiko suggest, remove "rockchip,panel" DT property, take use of remote > point to get panel node. > - Add the new function point analogix_dp_platdata.get_modes init. > - Take Heiko suggest, add rockchip dp phy driver, > collect the phy clocks and power control. > - Add "analogix,need-force-hpd" to indicate whether driver need foce > hpd when hpd detect failed. > - move dp hpd detect to connector detect function. > - Add edid modes parse support > > Changes in v2: > - Take Joe Preches advise, improved commit message more readable, and > avoid using some uncommon style like bellow: > - retval = exynos_dp_read_bytes_from_i2c(... > ...) > + retval = > + exynos_dp_read_bytes_from_i2c(......); > - Take Jingoo Han suggest, just remove my name from author list. > - Take Jingoo Han suggest, remove new copyright > - Fix compiled failed dut to analogix_dp_device misspell > - Take Heiko suggest, get panel node with remote-endpoint method, > and create devicetree binding for driver. > - Remove the clock enable/disbale with "sclk_edp" & "sclk_edp_24m", > leave those clock to rockchip dp phy driver. > - Add GNU license v2 declared and samsung copyright > - Fix compile failed dut to phy_pd_addr variable misspell error > > Yakir Yang (14): > drm: exynos/dp: fix code style > drm: exynos/dp: convert to drm bridge mode > drm: bridge: analogix_dp: split exynos dp driver to bridge dir > drm: bridge/analogix_dp: dynamic parse sync_pol & interlace & > colorimetry > drm: bridge/analogix_dp: fix link_rate & lane_count bug > Documentation: drm/bridge: add document for analogix_dp > drm: rockchip/dp: add rockchip platform dp driver > phy: Add driver for rockchip Display Port PHY > drm: bridge/analogix_dp: add platform device type support > drm: bridge: analogix_dp: add some rk3288 special registers setting > drm: bridge: analogix_dp: try force hpd after plug in lookup failed > drm: bridge/analogix_dp: expand the delay time for hpd detect > drm: bridge/analogix_dp: move hpd detect to connector detect function > drm: bridge/analogix_dp: add edid modes parse in get_modes method > > .../devicetree/bindings/drm/bridge/analogix_dp.txt | 73 + > .../devicetree/bindings/phy/rockchip-dp-phy.txt | 26 + > .../bindings/video/analogix_dp-rockchip.txt | 83 ++ > .../devicetree/bindings/video/exynos_dp.txt | 51 +- > arch/arm/boot/dts/exynos5250-arndale.dts | 10 +- > arch/arm/boot/dts/exynos5250-smdk5250.dts | 10 +- > arch/arm/boot/dts/exynos5250-snow.dts | 12 +- > arch/arm/boot/dts/exynos5250-spring.dts | 12 +- > arch/arm/boot/dts/exynos5420-peach-pit.dts | 12 +- > arch/arm/boot/dts/exynos5420-smdk5420.dts | 10 +- > arch/arm/boot/dts/exynos5800-peach-pi.dts | 12 +- > drivers/gpu/drm/bridge/Kconfig | 5 + > drivers/gpu/drm/bridge/Makefile | 1 + > drivers/gpu/drm/bridge/analogix_dp_core.c | 1382 +++++++++++++++++++ > drivers/gpu/drm/bridge/analogix_dp_core.h | 286 ++++ > drivers/gpu/drm/bridge/analogix_dp_reg.c | 1294 ++++++++++++++++++ > .../exynos_dp_reg.h => bridge/analogix_dp_reg.h} | 270 ++-- > drivers/gpu/drm/exynos/Kconfig | 5 +- > drivers/gpu/drm/exynos/Makefile | 2 +- > drivers/gpu/drm/exynos/analogix_dp-exynos.c | 347 +++++ > drivers/gpu/drm/exynos/exynos_dp_core.c | 1416 -------------------- > drivers/gpu/drm/exynos/exynos_dp_core.h | 282 ---- > drivers/gpu/drm/exynos/exynos_dp_reg.c | 1263 ----------------- > drivers/gpu/drm/rockchip/Kconfig | 9 + > drivers/gpu/drm/rockchip/Makefile | 1 + > drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 390 ++++++ > drivers/phy/Kconfig | 7 + > drivers/phy/Makefile | 1 + > drivers/phy/phy-rockchip-dp.c | 185 +++ > include/drm/bridge/analogix_dp.h | 40 + > 30 files changed, 4325 insertions(+), 3172 deletions(-) > create mode 100644 Documentation/devicetree/bindings/drm/bridge/analogix_dp.txt > create mode 100644 Documentation/devicetree/bindings/phy/rockchip-dp-phy.txt > create mode 100644 Documentation/devicetree/bindings/video/analogix_dp-rockchip.txt > create mode 100644 drivers/gpu/drm/bridge/analogix_dp_core.c > create mode 100644 drivers/gpu/drm/bridge/analogix_dp_core.h > create mode 100644 drivers/gpu/drm/bridge/analogix_dp_reg.c Minor comment: Since there are a few files required for the driver, could you create a separate folder within drivers/gpu/drm/bridge? Thanks, Archit -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project