From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: Design doc of adding ACPI support for arm64 on Xen - version 4 Date: Wed, 19 Aug 2015 21:58:13 -0700 Message-ID: <55D55E65.3030706@citrix.com> References: <55D472D4.9010007@huawei.com> <55D49AA1.3030702@citrix.com> <55D54483.5000103@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <55D54483.5000103@huawei.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Shannon Zhao , =?windows-1252?Q?Roger_Pau?= =?windows-1252?Q?_Monn=E9?= , xen-devel , Christoffer Dall , Ian Campbell , Stefano Stabellini , Stefano Stabellini , Jan Beulich , Parth Dixit , andrew@fubar.geek.nz, Boris Ostrovsky , David Vrabel Cc: Hangaohuai , "Huangpeng (Peter)" , Shannon Zhao List-Id: xen-devel@lists.xenproject.org On 19/08/2015 20:07, Shannon Zhao wrote: >> and I >> don't think the domid field needs an explanation TBH. >> >>> >>> Within the register, check if the device is newly added, then call >>> hypercall XENMEM_add_to_physmap to map the mmio regions. >>> >>> For PCI bus device, it could reuse the existing PCI bus_notifier like >>> X86. >> >> What is a PCI bus_notifier? I don't see any mention of bus_notifier in >> Xen code. >> > I thought You konw what I mean here. If not, what should I do! Yeah, as > you said, I will change the description. Please remember that not everyone on the mailing list knows how work the internal of linux is working. The goal of the design doc is to explain to them in simple way what we are planning to do. > > But I want to say that the purpose of this document is to explain some > important implementation details for ACPI support on ARM, which have > some divergence before. I don't hope this doc to be official but I do > hope this lets us reach an agreement on the approach before respinning > the patches. If we focus on the words or description or even > word-splitting, it doesn't help to make this move on! I think you misunderstood what is the design doc. It's an high level description about what will be implemented and official. If people doesn't understand what you meant in the design doc, I don't see how they will be able to check that what you've implemented will be match what we agree. So the wording, description ... is really important. Regards, -- Julien Grall