From mboxrd@z Thu Jan 1 00:00:00 1970 From: roger.pau@citrix.com (=?UTF-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?=) Date: Thu, 20 Aug 2015 09:33:12 +0200 Subject: [PATCH v3 08/20] block/xen-blkfront: split get_grant in 2 In-Reply-To: <1438966019-19322-9-git-send-email-julien.grall@citrix.com> References: <1438966019-19322-1-git-send-email-julien.grall@citrix.com> <1438966019-19322-9-git-send-email-julien.grall@citrix.com> Message-ID: <55D582B8.5030602@citrix.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org El 07/08/15 a les 18.46, Julien Grall ha escrit: > Prepare the code to support 64KB page granularity. The first > implementation will use a full Linux page per indirect and persistent > grant. When non-persistent grant is used, each page of a bio request > may be split in multiple grant. > > Furthermore, the field page of the grant structure is only used to copy > data from persistent grant or indirect grant. Avoid to set it for other > use case as it will have no meaning given the page will be split in > multiple grant. > > Provide 2 functions, to setup indirect grant, the other for bio page. > > Signed-off-by: Julien Grall Thanks, this looks fine: Acked-by: Roger Pau Monn? Roger. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752518AbbHTHdR (ORCPT ); Thu, 20 Aug 2015 03:33:17 -0400 Received: from smtp.citrix.com ([66.165.176.89]:2293 "EHLO SMTP.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751638AbbHTHdQ (ORCPT ); Thu, 20 Aug 2015 03:33:16 -0400 X-IronPort-AV: E=Sophos;i="5.15,714,1432598400"; d="scan'208";a="292828746" Message-ID: <55D582B8.5030602@citrix.com> Date: Thu, 20 Aug 2015 09:33:12 +0200 From: =?UTF-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Julien Grall , CC: , , , , "Konrad Rzeszutek Wilk" , Boris Ostrovsky , David Vrabel Subject: Re: [PATCH v3 08/20] block/xen-blkfront: split get_grant in 2 References: <1438966019-19322-1-git-send-email-julien.grall@citrix.com> <1438966019-19322-9-git-send-email-julien.grall@citrix.com> In-Reply-To: <1438966019-19322-9-git-send-email-julien.grall@citrix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-DLP: MIA1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org El 07/08/15 a les 18.46, Julien Grall ha escrit: > Prepare the code to support 64KB page granularity. The first > implementation will use a full Linux page per indirect and persistent > grant. When non-persistent grant is used, each page of a bio request > may be split in multiple grant. > > Furthermore, the field page of the grant structure is only used to copy > data from persistent grant or indirect grant. Avoid to set it for other > use case as it will have no meaning given the page will be split in > multiple grant. > > Provide 2 functions, to setup indirect grant, the other for bio page. > > Signed-off-by: Julien Grall Thanks, this looks fine: Acked-by: Roger Pau Monné Roger.